From: Conor Dooley <conor@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: Add ROHM BD79703
Date: Thu, 19 Dec 2024 18:59:53 +0000 [thread overview]
Message-ID: <20241219-acts-glare-2bc1e723ab20@spud> (raw)
In-Reply-To: <51ed31c494ea7385940b59500e8592d12558e291.1734608215.git.mazziesaccount@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 550 bytes --]
On Thu, Dec 19, 2024 at 01:39:11PM +0200, Matti Vaittinen wrote:
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + dac@0 {
nit: should be a blank line before the child node.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
> + compatible = "rohm,bd79703";
> + reg = <0>;
> + spi-max-frequency = <30000000>;
> + vcc-supply = <&vcc>;
> + vfs-supply = <&vref>;
> + };
> + };
> +...
> --
> 2.47.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-12-19 18:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 11:38 [PATCH 0/3] Support ROHM BD79703 DAC Matti Vaittinen
2024-12-19 11:39 ` [PATCH 1/3] dt-bindings: Add ROHM BD79703 Matti Vaittinen
2024-12-19 18:59 ` Conor Dooley [this message]
2024-12-19 11:39 ` [PATCH 2/3] iio: dac: Support ROHM BD79703 DAC Matti Vaittinen
2024-12-19 12:34 ` Jonathan Cameron
2024-12-19 11:39 ` [PATCH 3/3] MAINTAINERS: Add maintainer for ROHM BD79703 Matti Vaittinen
2024-12-20 19:12 ` [PATCH 0/3] Support ROHM BD79703 DAC Jonathan Cameron
2024-12-22 9:21 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241219-acts-glare-2bc1e723ab20@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox