From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7B66224AFB; Thu, 19 Dec 2024 14:12:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.153.233 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734617554; cv=none; b=F6y/W9+L+s0PymCkbgSMQeikacbRKJEK71trUv5Ee5x+DJgzxviiBGzb9hG1aDe8sb6taajUbuTOvvhiL90yW/97sHQsgSxtEUCtP57gOwaZ0MIBUqieW3+OBp7GAevzzKAr22ENMrhV19KTEDrgL602Q0O04ARE07R1iq7M/Mw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734617554; c=relaxed/simple; bh=rL4bZKisA1ewY6FNSKjR35HRt9SyWoP4I/W6Geur4+Q=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sCd8G3jdQ/hSgRbqM/U9cs3vFdxqCUpwWRunx74aAx2fSJrzXGhWkJ1lkgv72lq4/szHJ6C4nXDo5kImUBRzm34k/jnGywch6q8VbW0nakdOLQwEEgwzFiZYoyF/HrqkPWDNz3jpIRAIhqrlFul9oGc9u/Xwwm0UZAVfm465ObA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=zPKefTSV; arc=none smtp.client-ip=68.232.153.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="zPKefTSV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1734617552; x=1766153552; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rL4bZKisA1ewY6FNSKjR35HRt9SyWoP4I/W6Geur4+Q=; b=zPKefTSV4TDq7c9DUpS+D8hlolthQb24Br23tYqKDVNxsHQ4o2tFL/vf jUFaulqGiutwCn2THhsiUDCRf7Qqz0bYnCe11HIqocwgYdCqMh13yC18E CBtc/EV5uREEPVxJGdWFRLxUsD6VNQfjqW8hPJgYZ3JPGD1m5idzXO2LF UzY6/GLu7sJatGjkqLbeFWb5WNzio4SmbASvqcIf3F1ItUssaUwmEsUPB oifHsQyktx21CE35DRVsghg+20LGaSU+px29iOMxZrjV4QLH4M/9CIjC7 oO+QceJ0D3XN5PPeMsW0YjuO7LVwjU34CdyoG6dD/9Is/I00lubtHs2UV A==; X-CSE-ConnectionGUID: duLIUFe6TgyylrqHBIcnZA== X-CSE-MsgGUID: IHx9uQXnT4KVcyij0LTx5Q== X-IronPort-AV: E=Sophos;i="6.12,247,1728975600"; d="asc'?scan'208";a="39491699" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 Dec 2024 07:12:31 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 19 Dec 2024 07:12:28 -0700 Received: from wendy (10.10.85.11) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 19 Dec 2024 07:12:25 -0700 Date: Thu, 19 Dec 2024 14:11:53 +0000 From: Conor Dooley To: Tudor Ambarus CC: Jassi Brar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , , , , , , , , , Subject: Re: [PATCH 1/2] dt-bindings: mailbox: add support for referencing controllers solely by node Message-ID: <20241219-recent-everyone-865b19864693@wendy> References: <20241219-mbox_request_channel_by_args-v1-0-617a6910f842@linaro.org> <20241219-mbox_request_channel_by_args-v1-1-617a6910f842@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AgDRwXcwVb4K00Cs" Content-Disposition: inline In-Reply-To: <20241219-mbox_request_channel_by_args-v1-1-617a6910f842@linaro.org> --AgDRwXcwVb4K00Cs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 19, 2024 at 01:07:46PM +0000, Tudor Ambarus wrote: > There are mailbox clients that can discover the mailbox channel ID at > run-time. For such cases passing the channel identifier via DT is > redundant. Add support for referencing controllers solely by node. I don't really get your implementation, why not just allow #mbox-cells =3D = 0? That's what's done for things like fixed frequency clocks that only have a single output. Cheers, Conor. >=20 > Signed-off-by: Tudor Ambarus > --- > Documentation/devicetree/bindings/mailbox/mailbox.txt | 19 +++++++++++++= ++---- > 1 file changed, 15 insertions(+), 4 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/mailbox/mailbox.txt b/Docu= mentation/devicetree/bindings/mailbox/mailbox.txt > index af8ecee2ac68..0c4295a62f61 100644 > --- a/Documentation/devicetree/bindings/mailbox/mailbox.txt > +++ b/Documentation/devicetree/bindings/mailbox/mailbox.txt > @@ -5,9 +5,10 @@ assign appropriate mailbox channel to client drivers. > =20 > * Mailbox Controller > =20 > -Required property: > -- #mbox-cells: Must be at least 1. Number of cells in a mailbox > - specifier. > +Optional property: > +- #mbox-cells: Must be at least 1. Number of cells in a mailbox specifie= r. > + The property becomes mandatory for the cases where the cl= ients > + reference the controller via the mboxes property. > =20 > Example: > mailbox: mailbox { > @@ -19,7 +20,11 @@ Example: > * Mailbox Client > =20 > Required property: > +Clients must reference the mailbox controller either via the mboxes or m= box > +properties. > - mboxes: List of phandle and mailbox channel specifiers. > +- mbox: phandle pointing to the controller. Used by clients that can dis= cover > + the channel identifiers at runtime. > =20 > Optional property: > - mbox-names: List of identifier strings for each mailbox channel. > @@ -29,7 +34,13 @@ Optional property: > communication between the mailbox client and the remote. > =20 > =20 > -Example: > +Example using mbox: > + power-management { > + ... > + mbox =3D <&mailbox>; > + }; > + > +Example using mboxes: > pwr_cntrl: power { > ... > mbox-names =3D "pwr-ctrl", "rpc"; >=20 > --=20 > 2.47.1.613.gc27f4b7a9f-goog >=20 --AgDRwXcwVb4K00Cs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZ2QpqQAKCRB4tDGHoIJi 0jNPAP4jwBK4hw6Sni3HTWgBfvx9OY6ivkQ6KxloApXofanz+gD+LuAhHCXALmhe kUsX/G4V8KQ7n/DEcofRph3WgvdBCg4= =Kz4z -----END PGP SIGNATURE----- --AgDRwXcwVb4K00Cs--