[PATCH 1/2] dt-bindings: connector: Add time property for sender response

[PATCH 1/2] dt-bindings: connector: Add time property for sender response

[joswang]

From: Jos Wang <joswang@lenovo.com>

This commit adds the following properties:
  * pd2-sender-response-time-ms
  * pd3-sender-response-time-ms

This is to enable setting of platform/board specific timer values as
these timers have a range of acceptable values.

Signed-off-by: Jos Wang <joswang@lenovo.com>
---
 .../bindings/connector/usb-connector.yaml     | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
index 67700440e23b..83be66f6d406 100644
--- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
+++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
@@ -293,6 +293,26 @@ properties:
       PD negotiation till BC1.2 detection completes.
     default: 0
 
+  pd2-sender-response-time-ms:
+    description: Represents the PD20 max time in ms that port started from
+      the time the last bit of the GoodCRC Message EOP has been received by
+      the Physical Layer, it shall be stopped when the last bit of the expected
+      response Message EOP has been received by the Physical Layer. A timeout
+      leads to a hard reset message by the port.
+    minimum: 24
+    maximum: 30
+    default: 27
+
+  pd3-sender-response-time-ms:
+    description: Represents the PD30 max time in ms that port started from
+      the time the last bit of the GoodCRC Message EOP has been received by
+      the Physical Layer, it shall be stopped when the last bit of the expected
+      response Message EOP has been received by the Physical Layer. A timeout
+      leads to a hard reset message by the port.
+    minimum: 27
+    maximum: 33
+    default: 30
+
 dependencies:
   sink-vdos-v1: [ sink-vdos ]
   sink-vdos: [ sink-vdos-v1 ]
-- 
2.17.1

Re: [PATCH 1/2] dt-bindings: connector: Add time property for sender response

[Krzysztof Kozlowski]

On 15/12/2024 13:46, joswang wrote:
> From: Jos Wang <joswang@lenovo.com>
> 
> This commit adds the following properties:

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

>   * pd2-sender-response-time-ms
>   * pd3-sender-response-time-ms
> 
> This is to enable setting of platform/board specific timer values as
> these timers have a range of acceptable values.

Some explanation from where do they come would be useful.

> 
> Signed-off-by: Jos Wang <joswang@lenovo.com>

Your second patch did not make it.

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: connector: Add time property for sender response

[Greg KH]

On Sun, Dec 15, 2024 at 08:46:27PM +0800, joswang wrote:
> From: Jos Wang <joswang@lenovo.com>
> 
> This commit adds the following properties:
>   * pd2-sender-response-time-ms
>   * pd3-sender-response-time-ms
> 
> This is to enable setting of platform/board specific timer values as
> these timers have a range of acceptable values.
> 
> Signed-off-by: Jos Wang <joswang@lenovo.com>
> ---
>  .../bindings/connector/usb-connector.yaml     | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)

Where is patch 2/2?  Oh, I now see it, but our tools do not :(

Please make them properly linked together, normally something like 'git
send-email' will do that for you.

thakns,

greg k-h

Re: [PATCH 1/2] dt-bindings: connector: Add time property for sender response

[Jos Wang]

Thank you for your help in reviewing the code.

I will resubmit the code as soon as possible, put patch 1/2 and 2/2 in
the same thread.


On Tue, Dec 17, 2024 at 3:35 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 15/12/2024 13:46, joswang wrote:
> > From: Jos Wang <joswang@lenovo.com>
> >
> > This commit adds the following properties:
>
> Please do not use "This commit/patch/change", but imperative mood. See
> longer explanation here:
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
>
> >   * pd2-sender-response-time-ms
> >   * pd3-sender-response-time-ms
> >
> > This is to enable setting of platform/board specific timer values as
> > these timers have a range of acceptable values.
>
> Some explanation from where do they come would be useful.
>
> >
> > Signed-off-by: Jos Wang <joswang@lenovo.com>
>
> Your second patch did not make it.
>
> Best regards,
> Krzysztof

Re: [PATCH 1/2] dt-bindings: connector: Add time property for sender response

[Jos Wang]

Thank you for your help in reviewing the code.

I will resubmit the V2 version as soon as possible，put patch 1/2 and
2/2 in the same thread.

Thank

Jos Wang

On Fri, Dec 20, 2024 at 8:25 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sun, Dec 15, 2024 at 08:46:27PM +0800, joswang wrote:
> > From: Jos Wang <joswang@lenovo.com>
> >
> > This commit adds the following properties:
> >   * pd2-sender-response-time-ms
> >   * pd3-sender-response-time-ms
> >
> > This is to enable setting of platform/board specific timer values as
> > these timers have a range of acceptable values.
> >
> > Signed-off-by: Jos Wang <joswang@lenovo.com>
> > ---
> >  .../bindings/connector/usb-connector.yaml     | 20 +++++++++++++++++++
> >  1 file changed, 20 insertions(+)
>
> Where is patch 2/2?  Oh, I now see it, but our tools do not :(
>
> Please make them properly linked together, normally something like 'git
> send-email' will do that for you.
>
> thakns,
>
> greg k-h