Re: [PATCH 2/2] arm64: dts: mediatek: mt8192: Drop Chromebook variants that never shipped

Chen-Yu Tsai
2024-12-23T11:01:00Z

On Mon, Dec 23, 2024 at 6:14 PM Chen-Yu Tsai <wenst@chromium.org> wrote:
>
> The Hayato rev5 sku2 and Spherion rev4 variants were designed in
> anticipation of shortages of the headphone codec. This never happened.
> As far as our records show: the variants were never produced or
> shipped, and no such devices were deployed to any lab.
>
> Drop them.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
> .../mt8192-asurada-hayato-r5-sku2.dts | 65 ----------------
> .../mediatek/mt8192-asurada-spherion-r4.dts | 78 -------------------

Please ignore this version. I forgot to remove them from the Makefile.

I will send a v2 tomorrow.

ChenYu

> 2 files changed, 143 deletions(-)
> delete mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r5-sku2.dts
> delete mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r4.dts
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r5-sku2.dts b/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r5-sku2.dts
> deleted file mode 100644
> index cd86ad9ba28a..000000000000
> --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r5-sku2.dts
> +++ /dev/null
> @@ -1,65 +0,0 @@
> -// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> -/*
> - * Copyright 2022 Google LLC
> - */
> -/dts-v1/;
> -#include "mt8192-asurada.dtsi"
> -
> -/ {
> - model = "Google Hayato rev5";
> - chassis-type = "convertible";
> - compatible = "google,hayato-rev5-sku2", "google,hayato-sku2",
> - "google,hayato", "mediatek,mt8192";
> -};
> -
> -&keyboard_controller {
> - function-row-physmap = <
> - MATRIX_KEY(0x00, 0x02, 0) /* T1 */
> - MATRIX_KEY(0x03, 0x02, 0) /* T2 */
> - MATRIX_KEY(0x02, 0x02, 0) /* T3 */
> - MATRIX_KEY(0x01, 0x02, 0) /* T4 */
> - MATRIX_KEY(0x03, 0x04, 0) /* T5 */
> - MATRIX_KEY(0x02, 0x04, 0) /* T6 */
> - MATRIX_KEY(0x01, 0x04, 0) /* T7 */
> - MATRIX_KEY(0x02, 0x09, 0) /* T8 */
> - MATRIX_KEY(0x01, 0x09, 0) /* T9 */
> - MATRIX_KEY(0x00, 0x04, 0) /* T10 */
> - >;
> - linux,keymap = <
> - MATRIX_KEY(0x00, 0x02, KEY_BACK)
> - MATRIX_KEY(0x03, 0x02, KEY_FORWARD)
> - MATRIX_KEY(0x02, 0x02, KEY_REFRESH)
> - MATRIX_KEY(0x01, 0x02, KEY_FULL_SCREEN)
> - MATRIX_KEY(0x03, 0x04, KEY_SCALE)
> - MATRIX_KEY(0x02, 0x04, KEY_BRIGHTNESSDOWN)
> - MATRIX_KEY(0x01, 0x04, KEY_BRIGHTNESSUP)
> - MATRIX_KEY(0x02, 0x09, KEY_MUTE)
> - MATRIX_KEY(0x01, 0x09, KEY_VOLUMEDOWN)
> - MATRIX_KEY(0x00, 0x04, KEY_VOLUMEUP)
> -
> - CROS_STD_MAIN_KEYMAP
> - >;
> -};
> -
> -&rt5682 {
> - compatible = "realtek,rt5682s";
> -};
> -
> -&sound {
> - compatible = "mediatek,mt8192_mt6359_rt1015p_rt5682s";
> -
> - speaker-codecs {
> - sound-dai = <&rt1015p>;
> - };
> -
> - headset-codec {
> - sound-dai = <&rt5682 0>;
> - };
> -};
> -
> -&touchscreen {
> - compatible = "hid-over-i2c";
> - post-power-on-delay-ms = <10>;
> - hid-descr-addr = <0x0001>;
> - vdd-supply = <&pp3300_u>;
> -};
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r4.dts b/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r4.dts
> deleted file mode 100644
> index 5e9e598bab90..000000000000
> --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r4.dts
> +++ /dev/null
> @@ -1,78 +0,0 @@
> -// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> -/*
> - * Copyright 2022 Google LLC
> - */
> -/dts-v1/;
> -#include "mt8192-asurada.dtsi"
> -#include <dt-bindings/leds/common.h>
> -
> -/ {
> - model = "Google Spherion (rev4)";
> - chassis-type = "laptop";
> - compatible = "google,spherion-rev4", "google,spherion",
> - "mediatek,mt8192";
> -
> - pwmleds {
> - compatible = "pwm-leds";
> -
> - led {
> - function = LED_FUNCTION_KBD_BACKLIGHT;
> - color = <LED_COLOR_ID_WHITE>;
> - pwms = <&cros_ec_pwm 0>;
> - max-brightness = <1023>;
> - };
> - };
> -};
> -
> -&cros_ec_pwm {
> - status = "okay";
> -};
> -
> -&keyboard_controller {
> - function-row-physmap = <
> - MATRIX_KEY(0x00, 0x02, 0) /* T1 */
> - MATRIX_KEY(0x03, 0x02, 0) /* T2 */
> - MATRIX_KEY(0x02, 0x02, 0) /* T3 */
> - MATRIX_KEY(0x01, 0x02, 0) /* T4 */
> - MATRIX_KEY(0x03, 0x04, 0) /* T5 */
> - MATRIX_KEY(0x02, 0x04, 0) /* T6 */
> - MATRIX_KEY(0x01, 0x04, 0) /* T7 */
> - MATRIX_KEY(0x02, 0x09, 0) /* T8 */
> - MATRIX_KEY(0x01, 0x09, 0) /* T9 */
> - MATRIX_KEY(0x00, 0x04, 0) /* T10 */
> - >;
> - linux,keymap = <
> - MATRIX_KEY(0x00, 0x02, KEY_BACK)
> - MATRIX_KEY(0x03, 0x02, KEY_REFRESH)
> - MATRIX_KEY(0x02, 0x02, KEY_FULL_SCREEN)
> - MATRIX_KEY(0x01, 0x02, KEY_SCALE)
> - MATRIX_KEY(0x03, 0x04, KEY_SYSRQ)
> - MATRIX_KEY(0x02, 0x04, KEY_BRIGHTNESSDOWN)
> - MATRIX_KEY(0x01, 0x04, KEY_BRIGHTNESSUP)
> - MATRIX_KEY(0x02, 0x09, KEY_MUTE)
> - MATRIX_KEY(0x01, 0x09, KEY_VOLUMEDOWN)
> - MATRIX_KEY(0x00, 0x04, KEY_VOLUMEUP)
> -
> - CROS_STD_MAIN_KEYMAP
> - >;
> -};
> -
> -&rt5682 {
> - compatible = "realtek,rt5682s";
> -};
> -
> -&sound {
> - compatible = "mediatek,mt8192_mt6359_rt1015p_rt5682s";
> -
> - speaker-codecs {
> - sound-dai = <&rt1015p>;
> - };
> -
> - headset-codec {
> - sound-dai = <&rt5682 0>;
> - };
> -};
> -
> -&touchscreen {
> - compatible = "elan,ekth3500";
> -};
> --
> 2.47.1.613.gc27f4b7a9f-goog
>