From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: wangweidong.a@awinic.com
Cc: lgirdwood@gmail.com, broonie@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, perex@perex.cz,
tiwai@suse.com, ivprusov@salutedevices.com,
neil.armstrong@linaro.org, jack.yu@realtek.com,
rf@opensource.cirrus.com, quic_pkumpatl@quicinc.com,
herve.codina@bootlin.com, masahiroy@kernel.org,
nuno.sa@analog.com, yesanishhere@gmail.com,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, yijiangtao@awinic.com,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH V3 2/2] ASoC: codecs: Add aw88083 amplifier driver
Date: Tue, 24 Dec 2024 10:56:55 +0100 [thread overview]
Message-ID: <20241224105655.271068f8@booty> (raw)
In-Reply-To: <20241224031823.363777-3-wangweidong.a@awinic.com>
Hello Weidong,
On Tue, 24 Dec 2024 11:18:23 +0800
wangweidong.a@awinic.com wrote:
> From: Weidong Wang <wangweidong.a@awinic.com>
>
> The driver is for amplifiers aw88083 of Awinic Technology
> Corporation. The AW88083 is an intelligent digital audio
> amplifier with low noise.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202412201745.fBpf3Ui5-lkp@intel.com/
You should not add these two lines. From the kernel test robot report:
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202412201745.fBpf3Ui5-lkp@intel.com/
If you think about someone looking at git log in the future, they will
see the final version of your patch, they will never see v2. So the
final version (v3, v4, whatever) is not fixing any error as the error in
v2 will never be applied.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-12-24 9:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-24 3:18 [PATCH V3 0/2] ASoC: codecs: Add aw88083 amplifier driver wangweidong.a
2024-12-24 3:18 ` [PATCH V3 1/2] ASoC: dt-bindings: Add schema for "awinic,aw88083" wangweidong.a
2024-12-24 3:18 ` [PATCH V3 2/2] ASoC: codecs: Add aw88083 amplifier driver wangweidong.a
2024-12-24 9:56 ` Luca Ceresoli [this message]
2024-12-24 11:09 ` wangweidong.a
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241224105655.271068f8@booty \
--to=luca.ceresoli@bootlin.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=herve.codina@bootlin.com \
--cc=ivprusov@salutedevices.com \
--cc=jack.yu@realtek.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=lkp@intel.com \
--cc=masahiroy@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nuno.sa@analog.com \
--cc=perex@perex.cz \
--cc=quic_pkumpatl@quicinc.com \
--cc=rf@opensource.cirrus.com \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
--cc=wangweidong.a@awinic.com \
--cc=yesanishhere@gmail.com \
--cc=yijiangtao@awinic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox