Re: [PATCH v3] dt-bindings: iio: light: opt3001: add compatible for opt3004

[Jonathan Cameron <jic23@kernel.org>]

On Sat, 28 Dec 2024 10:54:33 +0000
Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io> wrote:

> Hi Krzysztof,
>  
> > On Fri, Dec 27, 2024 at 06:41:32PM +0530, Hardevsinh Palaniya wrote:  
> > > Add Support for OPT3004 Digital ambient light sensor (ALS) with
> > > increased angular IR rejection.
> > >
> > > The OPT3004 sensor shares the same functionality and scale range as
> > > the OPT3001. The compatible string is added with fallback support to
> > > ensure compatibility.
> > >
> > > Datasheet: https://www.ti.com/lit/gpn/opt3004
> > > Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>
> > > ---
> > >
> > > v2 -> v3:
> > >
> > > - Reverse the order of compatible string
> > >
> > > v1 -> v2:
> > >
> > > - Use fallback mechanism for the OPT3004.
> > > - Drop 2/2 patch from the patch series[1] as per feedback.
> > >
> > > Link[1]: https://lore.kernel.org/linux-iio/20241224061321.6048-1-hardevsinh.palaniya@siliconsignals.io/T/#t  
> > 
> >
> > And where is any user of this, the DTS? We don't take bindings just
> > because there is such device out there.
> >
> > I looked and nothing:
> > https://lore.kernel.org/all/?q=ti%2Copt3004  
>  
> I added compatibility for the OPT3004 into the driver. However, 
> based on Andy's feedback, it seems there might not be a need 
> to include this directly in the driver. 
> (Refer to Link [1] from the changelog.)
>  
> we could follow a similar approach to how we handled the ADXL346,
> by just adding it to the bindings, since the ADXL346 is similar to the 
> ADXL345.
>  
> If I misunderstood then please let me know.

Perhaps give some more information on the device in which this is found?
If that's a board that you plan to support upstream in the longer term
then that would provide more justification for this patch.

The note on the opt3001 page does give a hint as to how the parts are different
but saying the opt3004 has better IR rejection.  They also have a somewhat different
sensitivity curves. However, those are details we don't expose in the ABI and the
devices unhelpfully report the same ID register value, so it is not obvious that
we need to treat them differently.

Jonathan

>  
> Best Regards,
> Hardev