From: Jonathan Cameron <jic23@kernel.org>
To: Lothar Rubusch <l.rubusch@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, eraretuya@gmail.com
Subject: Re: [PATCH v8 7/7] iio: accel: adxl345: complete the list of defines
Date: Sat, 28 Dec 2024 14:47:14 +0000 [thread overview]
Message-ID: <20241228144714.2c1db6a8@jic23-huawei> (raw)
In-Reply-To: <20241225181338.69672-8-l.rubusch@gmail.com>
On Wed, 25 Dec 2024 18:13:38 +0000
Lothar Rubusch <l.rubusch@gmail.com> wrote:
> Having interrupts events and FIFO available allows to evaluate the
> sensor events. Cover the list of interrupt based sensor events. Keep
> them in the header file for readability.
>
> Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
One comment inline
Thanks,
Jonathan
> #define ADXL345_REG_BW_RATE 0x2C
> #define ADXL345_REG_POWER_CTL 0x2D
> #define ADXL345_REG_INT_ENABLE 0x2E
> @@ -34,20 +59,40 @@
> #define ADXL345_FIFO_CTL_MODE(x) FIELD_PREP(GENMASK(7, 6), x)
>
> #define ADXL345_INT_DATA_READY BIT(7)
> +#define ADXL345_INT_SINGLE_TAP BIT(6)
> +#define ADXL345_INT_DOUBLE_TAP BIT(5)
> +#define ADXL345_INT_ACTIVITY BIT(4)
> +#define ADXL345_INT_INACTIVITY BIT(3)
> +#define ADXL345_INT_FREE_FALL BIT(2)
> #define ADXL345_INT_WATERMARK BIT(1)
> #define ADXL345_INT_OVERRUN BIT(0)
> +
> +#define ADXL345_S_TAP_MSK ADXL345_INT_SINGLE_TAP
> +#define ADXL345_D_TAP_MSK ADXL345_INT_DOUBLE_TAP
Why have these?
next prev parent reply other threads:[~2024-12-28 14:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-25 18:13 [PATCH v8 0/7] iio: accel: adxl345: add FIFO operating with IRQ triggered watermark events Lothar Rubusch
2024-12-25 18:13 ` [PATCH v8 1/7] iio: accel: adxl345: add function to switch measuring mode Lothar Rubusch
2024-12-28 14:29 ` Jonathan Cameron
2024-12-25 18:13 ` [PATCH v8 2/7] dt-bindings: iio: accel: adxl345: make interrupts not a required property Lothar Rubusch
2024-12-28 14:30 ` Jonathan Cameron
2024-12-25 18:13 ` [PATCH v8 3/7] dt-bindings: iio: accel: adxl345: add interrupt-names Lothar Rubusch
2024-12-27 7:58 ` Krzysztof Kozlowski
2024-12-28 14:30 ` Jonathan Cameron
2024-12-25 18:13 ` [PATCH v8 4/7] iio: accel: adxl345: introduce interrupt handling Lothar Rubusch
2024-12-25 18:13 ` [PATCH v8 5/7] iio: accel: adxl345: initialize FIFO delay value for SPI Lothar Rubusch
2024-12-25 18:13 ` [PATCH v8 6/7] iio: accel: adxl345: add FIFO with watermark events Lothar Rubusch
2024-12-28 14:45 ` Jonathan Cameron
2024-12-28 16:11 ` Lothar Rubusch
2025-01-04 12:49 ` Jonathan Cameron
2024-12-25 18:13 ` [PATCH v8 7/7] iio: accel: adxl345: complete the list of defines Lothar Rubusch
2024-12-28 14:47 ` Jonathan Cameron [this message]
2024-12-28 15:48 ` Lothar Rubusch
2025-01-04 12:51 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241228144714.2c1db6a8@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eraretuya@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=l.rubusch@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox