From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAC8F1AE877 for ; Mon, 30 Dec 2024 18:22:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735582932; cv=none; b=tSfRQW5upffVCWo4kJKqNu3iIIvT0plGzah452J4r600+TUqDpoGYqoKgGAOr6Raq4JixYAavaVaxFkExkprMyEVIp+K6KhqCU/riGmch3E+/lInRTZJ9vU83RBHu++Lt1bxchyx9IjtlcLTnShemy1bnXbpEg+KIT4maoD0rOI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735582932; c=relaxed/simple; bh=ohF53bAlZOK876b57Tr3oe/521IXGf1Fjs/51DFutQE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S2w3cxrSwWKmBZljOHNWPLeaNikWymLxznJRWR7ghvhpdnBhPKVuR10oF1T+ItxF8ArsJMBMWU6aUeoVqN6n8V0O0ZDVBHNSUTpO9iONN10/fLSYZBvdTPq9tXjyvW2sPWt0gZqln1SZEx4wZ69IcG1DerRqwoC18R9628a6dRw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=o3JIZJ5t; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="o3JIZJ5t" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2166360285dso123708635ad.1 for ; Mon, 30 Dec 2024 10:22:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1735582930; x=1736187730; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=5whvZzYfxvB02wpstYeTdMUU94BDcz8zNaK1N90VIoo=; b=o3JIZJ5tj4Q4rthqLRFbX03w3iVVH4nzv+rERY0ULIXZ4gG/jiXrIRTeL1FsLOEoGu 7VXZD4wPN2NNCFHmz0OkqifX7GjIMwtCgvn2cTdM7N1QmXHNd5/l+p0IqE5JT2CVMHFg ZviJEQIXeLeBj9eNzvf0O/K+K54rbjAM+Ob0TtBG75xEu8D8kwDIpC8i1etDULudTomU V93U01gOB43JylOdEXcr6T0O/7cu8ZvURVyooLJn4VheinRfiVMfN8BpNMqN7CcVI36v VGqbg3GkGt5xMkwKZ7ZeqpK0z8xTa8Lo2/RSnx7KICqi0qeTtqQ/jiDIk7A8ZQ/A3F5S OJsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735582930; x=1736187730; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5whvZzYfxvB02wpstYeTdMUU94BDcz8zNaK1N90VIoo=; b=Z4bhto/gIwTPdCbJFTju9WBNVk/E2i/n6BfuP0WqHHIpvD3IWdxsOIE7h1iiuKFt0p bOWGSI0OquF9juNINyaNuDNMx/E95/iLkq47Q6PKgRKp/y8/qkMSK+Kry2kFYssrkB72 AAYU2M69JMxAY06le3Lvmhf54faUlaxOjyViwQeXIRGnyor4O4db4RumJwRBAZGPvOls b2X/tyaIHUOLh09jgwdb38iSrsWGMM8XmR3ZtAA1bDbYHS3LeM5+b8Q+iDgHvKfAdIzP 5hyVVtyou0QW/QdVVrWE/7yYnlTUJ81rJgQ4n+1nvyhcwqbgh5LsEVWIyvlEcvwq2/ps pcXw== X-Forwarded-Encrypted: i=1; AJvYcCUFdER/oA/giF2uM9JLUhLgX1Y85ldxEiEjITS51VWAVgAmI1+XFjbv4GVw6YlUpCuf7KFhGF+hcq/i@vger.kernel.org X-Gm-Message-State: AOJu0Yxk+HkBJADaWCy0KZ1MmhbhavLdiPoAADwe1RfvfvGe7IKKFEO5 fUhBO1CINfe80+EaENnhmPEDRbjZlNWTYI/HqE6Bz5oVFuTy8Fe2rihfkLH/2g== X-Gm-Gg: ASbGnctBoBfjFzhrHYRe2phglGsitZOoL+O/di08xYSjlYjZjOGo6Zc5r2LDhKmTaI7 eaNRAZRyuAZoPrYU56Y7XBwX4qw9KlxGouu1A65Vjx42lOkA4WTVko64Mq6MyWxy2Rff8H+cKg5 qTmxlwOrOYgBFvQwA/UFZFNxQeZ068pX2FnzbXfNIQxlYornYsAlSoXxRGFlUitM6lZx3Q8hET5 k+d3Qg6/aFqmFk5JMdAitSVvjWAFfYG6+u7JzHYdItuDK6vL+WNQ7JPRgRmyFRgAQ== X-Google-Smtp-Source: AGHT+IGmAZQbul0x33kNY3z5xhEmDXlGSFKtrk3n8yKah2UX0yu94Zn1yQJJuIjjti5kcSEoiVFc5A== X-Received: by 2002:a17:902:d48b:b0:216:7d22:f69 with SMTP id d9443c01a7336-219e6f262c4mr415053615ad.50.1735582929838; Mon, 30 Dec 2024 10:22:09 -0800 (PST) Received: from thinkpad ([120.60.54.70]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842dc7edbadsm17723516a12.65.2024.12.30.10.22.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2024 10:22:09 -0800 (PST) Date: Mon, 30 Dec 2024 23:52:01 +0530 From: Manivannan Sadhasivam To: Dmitry Baryshkov Cc: Krishna Chaitanya Chundru , Rob Herring , andersson@kernel.org, Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, Jingoo Han , Bartosz Golaszewski , quic_vbadigan@quicinc.com, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/6] dt-bindings: PCI: Add binding for qps615 Message-ID: <20241230182201.4nem2dvg4lg5vdjv@thinkpad> References: <20241112-qps615_pwr-v3-0-29a1e98aa2b0@quicinc.com> <20241112-qps615_pwr-v3-1-29a1e98aa2b0@quicinc.com> <20241115161848.GA2961450-robh@kernel.org> <74eaef67-18f2-c2a1-1b9c-ac97cefecc54@quicinc.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Dec 23, 2024 at 08:57:37PM +0200, Dmitry Baryshkov wrote: [...] > > This switch allows us to configure both upstream, downstream ports and > > also embedded Ethernet port which is internal to the switch. These > > properties are applicable for all of those. > > > > + > > > > + allOf: > > > > + - $ref: /schemas/pci/pci-bus.yaml# > > > > > > pci-pci-bridge.yaml is more specific and closer to what this device is. > > > > > I tried this now, I was getting warning saying the compatible > > /local/mnt/workspace/skales/kobj/Documentation/devicetree/bindings/pci/qcom,qps615.example.dtb: > > pcie@0,0: compatible: ['pci1179,0623'] does not contain items matching the > > given schema > > from schema $id: http://devicetree.org/schemas/pci/qcom,qps615.yaml# > > /local/mnt/workspace/skales/kobj/Documentation/devicetree/bindings/pci/qcom,qps615.example.dtb: > > pcie@0,0: Unevaluated properties are not allowed ('#address-cells', > > '#size-cells', 'bus-range', 'device_type', 'ranges' were unexpected) > > > > I think pci-pci-bridge is expecting the compatible string in this format > > only "pciclass,0604". > > I think the pci-pci-bridge schema requires to have "pciclass,0604" among > other compatibles. So you should be able to do something like: > > compatible = "pci1179,0623", "pciclass,0604"; > Even though a PCIe switch is supposed to be a network of PCI bridges, using PCI bridge fallback for this switch is not technically correct IMO. Mostly because, this switch requires other configurations which are not applicable to PCI bridges. So the drivers matching against the bridge compatible won't be able to use this switch. - Mani -- மணிவண்ணன் சதாசிவம்