From: "Heiko Stübner" <heiko@sntech.de>
To: Frank Wang <frank.wang@rock-chips.com>
Cc: dianders@chromium.org, linux@roeck-us.net, groeck@chromium.org,
jwerner@chromium.org, kishon@ti.com, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org, linux-rockchip@lists.infradead.org,
xzy.xu@rock-chips.com, kever.yang@rock-chips.com,
huangtao@rock-chips.com, william.wu@rock-chips.com,
daniel.meng@rock-chips.com
Subject: Re: [PATCH v9 4/4] arm64: dts: rockchip: configure usb2-phy support for rk3399-evb
Date: Wed, 17 Aug 2016 12:02:19 +0200 [thread overview]
Message-ID: <2024472.51n7WpJreO@diego> (raw)
In-Reply-To: <1469170846-15617-5-git-send-email-frank.wang@rock-chips.com>
Am Freitag, 22. Juli 2016, 15:00:46 schrieb Frank Wang:
> Add vcc5v0_host regulator for usb2-phy and enable host-port support.
>
> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
applied to ny dts64 branch [0] with some changes:
- the pin is named vcc5v0_host_en not host_vbus_drv in the schematics
please always try to use the names from the schematics
- separated the enablement of the subnodes
Heiko
[0] https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=1d3bc1d6c9c4658d554bcf89a71b35a6783a5b4e
> ---
> arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 44
> +++++++++++++++++++++++++++ 1 file changed, 44 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
> b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts index 1a3eb14..56aeedb 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
> @@ -69,6 +69,25 @@
> regulator-max-microvolt = <3300000>;
> };
>
> + vcc5v0_sys: vcc5v0-sys {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc5v0_sys";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + };
> +
> + vcc5v0_host: vcc5v0-host-regulator {
> + compatible = "regulator-fixed";
> + enable-active-high;
> + gpio = <&gpio4 25 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&host_vbus_drv>;
> + regulator-name = "vcc5v0_host";
> + vin-supply = <&vcc5v0_sys>;
> + };
> +
> vcc_phy: vcc-phy-regulator {
> compatible = "regulator-fixed";
> regulator-name = "vcc_phy";
> @@ -89,6 +108,24 @@
> status = "okay";
> };
>
> +&u2phy0 {
> + status = "okay";
> +
> + u2phy0_host: host-port {
> + phy-supply = <&vcc5v0_host>;
> + status = "okay";
> + };
> +};
> +
> +&u2phy1 {
> + status = "okay";
> +
> + u2phy1_host: host-port {
> + phy-supply = <&vcc5v0_host>;
> + status = "okay";
> + };
> +};
> +
> &uart2 {
> status = "okay";
> };
> @@ -121,4 +158,11 @@
> <1 18 RK_FUNC_GPIO &pcfg_pull_down>;
> };
> };
> +
> + usb2 {
> + host_vbus_drv: host-vbus-drv {
> + rockchip,pins =
> + <4 25 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> + };
> };
next prev parent reply other threads:[~2016-08-17 10:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 7:00 [PATCH v9 0/4] Add a new Rockchip usb2 phy driver Frank Wang
[not found] ` <1469170846-15617-1-git-send-email-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-07-22 7:00 ` [PATCH v9 1/4] Documentation: bindings: add DT documentation for Rockchip USB2PHY Frank Wang
2016-07-22 7:00 ` [PATCH v9 2/4] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy Frank Wang
[not found] ` <1469170846-15617-3-git-send-email-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-08-12 10:09 ` Kishon Vijay Abraham I
2016-07-22 7:00 ` [PATCH v9 3/4] arm64: dts: rockchip: add usb2-phy support for rk3399 Frank Wang
[not found] ` <1469170846-15617-4-git-send-email-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-08-03 19:34 ` Heiko Stübner
2016-08-17 9:53 ` Heiko Stübner
2016-07-22 7:00 ` [PATCH v9 4/4] arm64: dts: rockchip: configure usb2-phy support for rk3399-evb Frank Wang
2016-08-17 10:02 ` Heiko Stübner [this message]
2016-08-18 2:53 ` Frank Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024472.51n7WpJreO@diego \
--to=heiko@sntech.de \
--cc=daniel.meng@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=frank.wang@rock-chips.com \
--cc=galak@codeaurora.org \
--cc=groeck@chromium.org \
--cc=huangtao@rock-chips.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jwerner@chromium.org \
--cc=kever.yang@rock-chips.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=william.wu@rock-chips.com \
--cc=xzy.xu@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).