devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: memory-controller: qca,ath79-ddr-controller: Drop consumer from example
@ 2025-01-03 21:24 Rob Herring (Arm)
  2025-01-05  9:11 ` Krzysztof Kozlowski
  2025-01-06 23:01 ` Rob Herring (Arm)
  0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2025-01-03 21:24 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Conor Dooley; +Cc: linux-kernel, devicetree

Normal practice is examples only show what the binding document defines
and doesn't include consumers in a provider example (or vice-versa). The
"qca,ddr-wb-channel-interrupts" and "qca,ddr-wb-channels" properties are
also not yet documented by a schema, so avoid (not yet enabled) warnings
on them by dropping the interrupt-controller node from the example.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../memory-controllers/qca,ath79-ddr-controller.yaml       | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/memory-controllers/qca,ath79-ddr-controller.yaml b/Documentation/devicetree/bindings/memory-controllers/qca,ath79-ddr-controller.yaml
index 0c511ab906bf..8b937f90a1fb 100644
--- a/Documentation/devicetree/bindings/memory-controllers/qca,ath79-ddr-controller.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/qca,ath79-ddr-controller.yaml
@@ -52,10 +52,3 @@ examples:
 
         #qca,ddr-wb-channel-cells = <1>;
     };
-
-    interrupt-controller {
-        // ...
-        qca,ddr-wb-channel-interrupts = <2>, <3>, <4>, <5>;
-        qca,ddr-wb-channels = <&ddr_ctrl 3>, <&ddr_ctrl 2>,
-                              <&ddr_ctrl 0>, <&ddr_ctrl 1>;
-    };
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: memory-controller: qca,ath79-ddr-controller: Drop consumer from example
  2025-01-03 21:24 [PATCH] dt-bindings: memory-controller: qca,ath79-ddr-controller: Drop consumer from example Rob Herring (Arm)
@ 2025-01-05  9:11 ` Krzysztof Kozlowski
  2025-01-06 23:01 ` Rob Herring (Arm)
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-01-05  9:11 UTC (permalink / raw)
  To: Rob Herring (Arm), Conor Dooley; +Cc: linux-kernel, devicetree

On 03/01/2025 22:24, Rob Herring (Arm) wrote:
> Normal practice is examples only show what the binding document defines
> and doesn't include consumers in a provider example (or vice-versa). The
> "qca,ddr-wb-channel-interrupts" and "qca,ddr-wb-channels" properties are
> also not yet documented by a schema, so avoid (not yet enabled) warnings
> on them by dropping the interrupt-controller node from the example.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  .../memory-controllers/qca,ath79-ddr-controller.yaml       | 7 -------
>  1 file changed, 7 deletions(-)

It is too late in the cycle for me to pick it up. I will take it after
the merge window... or alternatively you can take it via DT for upcoming
merge window:

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: memory-controller: qca,ath79-ddr-controller: Drop consumer from example
  2025-01-03 21:24 [PATCH] dt-bindings: memory-controller: qca,ath79-ddr-controller: Drop consumer from example Rob Herring (Arm)
  2025-01-05  9:11 ` Krzysztof Kozlowski
@ 2025-01-06 23:01 ` Rob Herring (Arm)
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2025-01-06 23:01 UTC (permalink / raw)
  To: Rob Herring (Arm)
  Cc: Conor Dooley, devicetree, Krzysztof Kozlowski, linux-kernel


On Fri, 03 Jan 2025 15:24:48 -0600, Rob Herring (Arm) wrote:
> Normal practice is examples only show what the binding document defines
> and doesn't include consumers in a provider example (or vice-versa). The
> "qca,ddr-wb-channel-interrupts" and "qca,ddr-wb-channels" properties are
> also not yet documented by a schema, so avoid (not yet enabled) warnings
> on them by dropping the interrupt-controller node from the example.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  .../memory-controllers/qca,ath79-ddr-controller.yaml       | 7 -------
>  1 file changed, 7 deletions(-)
> 

Applied, thanks!


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-01-06 23:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-03 21:24 [PATCH] dt-bindings: memory-controller: qca,ath79-ddr-controller: Drop consumer from example Rob Herring (Arm)
2025-01-05  9:11 ` Krzysztof Kozlowski
2025-01-06 23:01 ` Rob Herring (Arm)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).