From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09DC586332 for ; Mon, 6 Jan 2025 16:10:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736179810; cv=none; b=NLOadaD7Dm5hVNS2nHJcDv4JU0BQdeYNXdGB+++b+ks6+V6HgPmXNHSfX5XfQqkqaclsK+9dl6CgqC5xPDQpMexfciJMrTWhbTRFJvn0l5kNwYTX+gYXy0B15dpwPIdhTDhTvbFIcEXdzddq+XUYazZWIQpQxZGVcJ2lkpSUFeo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736179810; c=relaxed/simple; bh=w5Yel1wJYsFWeW0wLAjqewZMxGW2Jmj/sYREWUnMsjE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mADhb0JUL4PhTuKe+kuOczZYPHqVinH1J+qSCTfTix8WJkQ+wdUvCBcpdquZRpzHX5l2w/TZD5uqW6y+yGVMxrd/WJsAJYVgUDsPDb0NIWGdEJvNYpK/XAYdYQwPr7fWSgtSEazn2YooLmHd2XCNAjxPoTyK2mKDKGlJjnmgMgQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=T9hBXOsW; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="T9hBXOsW" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-21669fd5c7cso213277015ad.3 for ; Mon, 06 Jan 2025 08:10:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736179807; x=1736784607; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=cbh70FNu5lHAZ2y3qFziORwGTSyKcYnNaY2OZrOn1ZY=; b=T9hBXOsWJ9sXTpYFVmm9dBd7gXG10UVWDw+nj00g21F7ZVHPOOVgl+BmHhtlrJf8X9 AGIXiDTrST8vy1bPI88RD+SV7FLPfjCntYsZm0t+z+hFO/liePUB1NoGvKvwdi7SWemv exBv0D6TfPRF4dcxAhW3QhfqlAxv52Sf6KkWTGqXRulbEe8HL721E1H6o04mmxv/Chjo oMe8D9pnQkNDHqFe09kw3f6lfvX+sbotKLRjqsvlbZAstJ83Omv/YO6VHa8K5K9x7n5w 1u/yRQp0Bl/IRmBL1sJuEXXrqjsW4w4P9tnnRYbmxd0X7r75E2XbbdPeWriHKZJ/KDgb Reqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736179807; x=1736784607; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cbh70FNu5lHAZ2y3qFziORwGTSyKcYnNaY2OZrOn1ZY=; b=V6PNgznL3oV8RrOF1aEJm9kq1ePsNft0asBqzE+Bl8qnu/MdO4VQ4a92LuEz4a9wCK YVJWGO8yxxz968UNaOPJv/ZrXApBL1EUMBq8RWQCvI5z4bIg3vAMn9zICR57t1wT7qtF rvSTwW6icoYP4vH1ZS/CotK/Kagzs0gmYpuLTd9Ak6vUbBaUfVksSbLuwcf1tVeADp7C J4MxANnQBw8VKgKICYkASPlWzHcJEel1lMoRb0XITUtVn17b8V8Ldf/PLNDxHP2wEVml 245UKY9D4J4z/nk6f3Fty8kAfa0Cji49q/B7Nzf9vyJzJe74yhpcXF1tQ9b9cL5y03Cu HDMg== X-Forwarded-Encrypted: i=1; AJvYcCWg4Eddd3ANEFvXY7qJjDblswgvBu4Gvyt28yDKzHMGWD+2lwcoGbEYIkopFLj9gfpslH9izda9fC6e@vger.kernel.org X-Gm-Message-State: AOJu0YzB+iNEmQIhA3VQHNfXWAtbXp84NjbA80QoR6edLIMqM88gp5qw Bga2OlUTA74HX7RN9E7uIUC2bDKlSjWffKWEdDijtQv5fL2JGuYHKSZt23a/Bg== X-Gm-Gg: ASbGncu4ad6owpDvXCeThFFscV1alxg+kAvkxUG3jfkeXwUcohQixuSxdGgf6jTWFL7 ImTiOot/MhmLk0onVErqFzhroz1qT/sSBEgtprogz/n58hu3EcWJjBsHnWTVREjk5JcY2udEml8 /EEvF3GqPMtvyFrTdGTgqiZ18yZWsdsnxrlhqHQX2GW6m2NWb5ar0ClEcdCTrDIwgq1Tr4/3cZA hjfCsIy7ONaVb/UPITwcXH1qOm8pY3c9xSuKciLzpyRd5hj1D6vS3TkJtx6ZUsvZAY= X-Google-Smtp-Source: AGHT+IGWek+UwLvA7jIxaMXySnHt1P9khnFX7cna7RBNBSt0+o7sQhOK9pqBW8ZD3DQlUzuguSWTWA== X-Received: by 2002:a05:6a21:2d04:b0:1e1:b224:74c0 with SMTP id adf61e73a8af0-1e5e0815ee4mr94198810637.38.1736179807211; Mon, 06 Jan 2025 08:10:07 -0800 (PST) Received: from thinkpad ([120.60.61.126]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8dbafesm32377915b3a.128.2025.01.06.08.10.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2025 08:10:06 -0800 (PST) Date: Mon, 6 Jan 2025 21:39:50 +0530 From: Manivannan Sadhasivam To: Jianjun Wang Cc: Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Ryder Lee , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Xavier Chang Subject: Re: [PATCH 3/5] PCI: mediatek-gen3: Disable ASPM L0s Message-ID: <20250106160950.uutcgs2vqnuve22k@thinkpad> References: <20250103060035.30688-1-jianjun.wang@mediatek.com> <20250103060035.30688-4-jianjun.wang@mediatek.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250103060035.30688-4-jianjun.wang@mediatek.com> On Fri, Jan 03, 2025 at 02:00:13PM +0800, Jianjun Wang wrote: > Disable ASPM L0s support because it does not significantly save power > but impacts performance. > You should disable ASPM only if it is causing any functional issues to the SoC itself. For other reasons, users will use the existing sysfs/cmdline params to disable ASPM based on usecase if required. - Mani > Signed-off-by: Jianjun Wang > --- > drivers/pci/controller/pcie-mediatek-gen3.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c > index ed3c0614486c..4bd3b39eebe2 100644 > --- a/drivers/pci/controller/pcie-mediatek-gen3.c > +++ b/drivers/pci/controller/pcie-mediatek-gen3.c > @@ -84,6 +84,9 @@ > #define PCIE_MSI_SET_ENABLE_REG 0x190 > #define PCIE_MSI_SET_ENABLE GENMASK(PCIE_MSI_SET_NUM - 1, 0) > > +#define PCIE_LOW_POWER_CTRL_REG 0x194 > +#define PCIE_FORCE_DIS_L0S BIT(8) > + > #define PCIE_PIPE4_PIE8_REG 0x338 > #define PCIE_K_FINETUNE_MAX GENMASK(5, 0) > #define PCIE_K_FINETUNE_ERR GENMASK(7, 6) > @@ -458,6 +461,14 @@ static int mtk_pcie_startup_port(struct mtk_gen3_pcie *pcie) > val &= ~PCIE_INTX_ENABLE; > writel_relaxed(val, pcie->base + PCIE_INT_ENABLE_REG); > > + /* > + * Disable L0s support because it does not significantly save power > + * but impacts performance. > + */ > + val = readl_relaxed(pcie->base + PCIE_LOW_POWER_CTRL_REG); > + val |= PCIE_FORCE_DIS_L0S; > + writel_relaxed(val, pcie->base + PCIE_LOW_POWER_CTRL_REG); > + > /* Disable DVFSRC voltage request */ > val = readl_relaxed(pcie->base + PCIE_MISC_CTRL_REG); > val |= PCIE_DISABLE_DVFSRC_VLT_REQ; > -- > 2.46.0 > -- மணிவண்ணன் சதாசிவம்