devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Markus Schneider-Pargmann <msp@baylibre.com>
Cc: Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
	 Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
	"David S. Miller" <davem@davemloft.net>,
	 Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	 Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Nishanth Menon <nm@ti.com>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>,
	linux-can@vger.kernel.org,  netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
	 Vishal Mahaveer <vishalm@ti.com>,
	Kevin Hilman <khilman@baylibre.com>, Dhruva Gole <d-gole@ti.com>,
	 Simon Horman <horms@kernel.org>
Subject: Re: [PATCH v6 1/7] dt-bindings: can: m_can: Add wakeup properties
Date: Tue, 7 Jan 2025 13:05:24 +0100	[thread overview]
Message-ID: <20250107-liberal-unique-uakari-0ddc2c-mkl@pengutronix.de> (raw)
In-Reply-To: <d6hukfwjqgtwqjgvo65icmpzbm32ob6n7ehrzlywwomjbdn5lg@2wm53244pszz>

[-- Attachment #1: Type: text/plain, Size: 2688 bytes --]

On 07.01.2025 10:53:26, Markus Schneider-Pargmann wrote:
> On Wed, Dec 25, 2024 at 08:50:17PM +0100, Marc Kleine-Budde wrote:
> > On 19.12.2024 20:57:52, Markus Schneider-Pargmann wrote:
> > > m_can can be a wakeup source on some devices. Especially on some of the
> > > am62* SoCs pins, connected to m_can in the mcu, can be used to wakeup
> > > the SoC.
> > > 
> > > The wakeup-source property defines on which devices m_can can be used
> > > for wakeup and in which power states.
> > > 
> > > The pins associated with m_can have to have a special configuration to
> > > be able to wakeup the SoC. This configuration is described in the wakeup
> > > pinctrl state while the default state describes the default
> > > configuration.
> > > 
> > > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> > 
> > The DTBS check fails:
> > 
> > | $ make CHECK_DTBS=y ti/k3-am625-beagleplay.dtb
> > |   DTC [C] arch/arm64/boot/dts/ti/k3-am625-beagleplay.dtb
> > | arch/arm64/boot/dts/ti/k3-am625-beagleplay.dtb: can@4e08000: wakeup-source: 'oneOf' conditional failed, one must be fixed:
> > |         ['suspend', 'poweroff'] is not of type 'boolean'
> > |         ['suspend', 'poweroff'] is too long
> > |         from schema $id: http://devicetree.org/schemas/net/can/bosch,m_can.yaml#
> > | arch/arm64/boot/dts/ti/k3-am625-beagleplay.dtb: can@4e08000: wakeup-source: ['suspend', 'poweroff'] is not of type 'boolean'
> > |         from schema $id: http://devicetree.org/schemas/wakeup-source.yaml#
> > | arch/arm64/boot/dts/ti/k3-am625-beagleplay.dtb: can@4e18000: wakeup-source: 'oneOf' conditional failed, one must be fixed:
> > |         ['suspend', 'poweroff'] is not of type 'boolean'
> > |         ['suspend', 'poweroff'] is too long
> > |         from schema $id: http://devicetree.org/schemas/net/can/bosch,m_can.yaml#
> > | arch/arm64/boot/dts/ti/k3-am625-beagleplay.dtb: can@4e18000: wakeup-source: ['suspend', 'poweroff'] is not of type 'boolean'
> > |         from schema $id: http://devicetree.org/schemas/wakeup-source.yaml#
> 
> Thanks, the bot also notified me about this issue. I wasn't able to
> solve it without updating the dt-schema, so I submitted a pull request
> there:
> 
> https://github.com/devicetree-org/dt-schema/pull/150

I see, please add to the patch description that it depends on the that
PR and re-post once it is accepted.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2025-01-07 12:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-19 19:57 [PATCH v6 0/7] can: m_can: Add am62 wakeup support Markus Schneider-Pargmann
2024-12-19 19:57 ` [PATCH v6 1/7] dt-bindings: can: m_can: Add wakeup properties Markus Schneider-Pargmann
2024-12-25 19:50   ` Marc Kleine-Budde
2025-01-07  9:53     ` Markus Schneider-Pargmann
2025-01-07 12:05       ` Marc Kleine-Budde [this message]
2024-12-19 19:57 ` [PATCH v6 2/7] can: m_can: Map WoL to device_set_wakeup_enable Markus Schneider-Pargmann
2024-12-19 19:57 ` [PATCH v6 3/7] can: m_can: Return ERR_PTR on error in allocation Markus Schneider-Pargmann
2024-12-19 19:57 ` [PATCH v6 4/7] can: m_can: Support pinctrl wakeup state Markus Schneider-Pargmann
2024-12-19 19:57 ` [PATCH v6 5/7] arm64: dts: ti: k3-am62: Mark mcu_mcan0/1 as wakeup-source Markus Schneider-Pargmann
2024-12-19 19:57 ` [PATCH v6 6/7] arm64: dts: ti: k3-am62a-mcu: " Markus Schneider-Pargmann
2024-12-19 19:57 ` [PATCH v6 7/7] arm64: dts: ti: k3-am62p-mcu: " Markus Schneider-Pargmann
2024-12-22 16:53 ` [PATCH v6 0/7] can: m_can: Add am62 wakeup support Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250107-liberal-unique-uakari-0ddc2c-mkl@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=conor+dt@kernel.org \
    --cc=d-gole@ti.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=khilman@baylibre.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mailhol.vincent@wanadoo.fr \
    --cc=matthias.schiffer@ew.tq-group.com \
    --cc=msp@baylibre.com \
    --cc=netdev@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=pabeni@redhat.com \
    --cc=rcsekar@samsung.com \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    --cc=vishalm@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).