From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a6-smtp.messagingengine.com (fout-a6-smtp.messagingengine.com [103.168.172.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03A531E50B; Tue, 7 Jan 2025 13:51:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.149 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736257903; cv=none; b=BUtGY6+LwxTnbAF1/DAn5UsbJ/a5euSTsdlZArZFkT5/qcm94BQBqsE90G32aW6zxuPNRUkLrdqWg1jVtK2hn47WDJlcEinKGivIdpi8Y03BkoxNGozQDtQzcXTLGTHkdAHVKwmJgpfRZBFx7xnts+3w0uK0Ix3gvgkvMeiV2KM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736257903; c=relaxed/simple; bh=tKkfdneQLTx/3A5l7eOgYN0lWqtk8zVO31FA/YCAl+4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qRHDJWz2srdxlG1toWQOCWjw6sk7DZOOUj2Mwx10U6th8d2CQAIQK2Dd106UWt4IUgOI13vP3tqF0RvYWrcn3P9kPf8s4PrcOQiZJ/ZATSD9a3sK4ElL6MJFWjXGQ0lFvRratIsHDOLo24ZhMJqgqovg3egiAyb+o4vpKMKHTE4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se; spf=pass smtp.mailfrom=ragnatech.se; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b=eXwKXoxw; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=GsY70qUr; arc=none smtp.client-ip=103.168.172.149 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b="eXwKXoxw"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="GsY70qUr" Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfout.phl.internal (Postfix) with ESMTP id 0910113800C3; Tue, 7 Jan 2025 08:51:38 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Tue, 07 Jan 2025 08:51:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1736257898; x=1736344298; bh=mJ3gsu/+Nz0H/GR7MsuvkCswY4cSY5Uv50se5eJ30HE=; b= eXwKXoxw1efnvQuiHMe9BGJeNRaZzvMWmanR5rhdTomqoUpH+W7tXaqIE1/OQDNX TXzv2r763Y5MQ0oezeiZUSBFbixOHnJIEFTLxUYacn/YDj/LAjGUSxRN+AGoJj6+ p9X4ACV2LuDuHywV6qvqjICqukWvYPLGtlt/H7hMRQUOClQ3QUMjhvAinyWmtYL+ bobSHj6gFlqBI5GJFeJF9PL9HnE4k5YjROMZxnJJOfX4OULhE1T/+BL0GFDCVk/L ogBcPFkSGwo/2TQayrPJkQFrV84Zv1hhwli5rQaiNyCpnUdUSyksnwC7m9Nkr8ag it0bdiSQ0h5IWqhGhCn42g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1736257898; x= 1736344298; bh=mJ3gsu/+Nz0H/GR7MsuvkCswY4cSY5Uv50se5eJ30HE=; b=G sY70qUrEP1gl1JmqNzVK6Mx/8c28BJ78vUcJO7JNM8lh3w89azzet2NIx1atdgh6 6tBRFn/253U21TJl7yHSP5M/HrS/VlKJ1DH4lmkzXEP5PTlJ0+9KfA7hzFykjdSP uco1O/NCvQ3yvmhxgK7ELeZSFpxpdKWaK5bWgIMxw3ptwN+k8+1DWa1JLWgOtJUt 76OvMJlHqqr/wc3llkI7OC0+NI4u8XOWGtAVekAR43qKHsETu6mCHFg054HAOJRd zCX+XouxB3rMt6Mg/F15ChHNUSaTYnXYwyor6PaSRnSbjyTSekLfx8rAfkIuMse3 8+TTyTfkPrZ7xTWfzYdSg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudegvddgheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggugfgjsehtkeertddttdej necuhfhrohhmpefpihhklhgrshcuufpnuggvrhhluhhnugcuoehnihhklhgrshdrshhoug gvrhhluhhnugesrhgrghhnrghtvggthhdrshgvqeenucggtffrrghtthgvrhhnpeevteeg tddvvdfhtdekgefhfeefheetheekkeegfeejudeiudeuleegtdehkeekteenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehnihhklhgrshdrshho uggvrhhluhhnugesrhgrghhnrghtvggthhdrshgvpdhnsggprhgtphhtthhopedvfedpmh houggvpehsmhhtphhouhhtpdhrtghpthhtohepkhhriiihshiithhofhdrkhhoiihlohif shhkiheslhhinhgrrhhordhorhhgpdhrtghpthhtohepuggrnhhivghlrdhlvgiitggrnh hosehlihhnrghrohdrohhrghdprhgtphhtthhopehtghhlgieslhhinhhuthhrohhnihig rdguvgdprhgtphhtthhopehrohgshheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepkh hriihkodgutheskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheptghonhhorhdoughtsehk vghrnhgvlhdrohhrghdprhgtphhtthhopehmtghoqhhuvghlihhnrdhsthhmfedvsehgmh grihhlrdgtohhmpdhrtghpthhtoheprghlvgigrghnughrvgdrthhorhhguhgvsehfohhs shdrshhtrdgtohhmpdhrtghpthhtohepphgruhhlrdifrghlmhhslhgvhiesshhifhhivh gvrdgtohhm X-ME-Proxy: Feedback-ID: i80c9496c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Jan 2025 08:51:36 -0500 (EST) Date: Tue, 7 Jan 2025 14:51:33 +0100 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: Krzysztof Kozlowski Cc: Daniel Lezcano , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Paul Walmsley , Samuel Holland , Geert Uytterhoeven , Magnus Damm , Laurent Pinchart , Chris Brandt , Yoshinori Sato , Palmer Dabbelt , Anup Patel , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] dt-bindings: timer: Correct indentation and style in DTS example Message-ID: <20250107135133.GA3765919@ragnatech.se> References: <20250107131024.246561-1-krzysztof.kozlowski@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250107131024.246561-1-krzysztof.kozlowski@linaro.org> Hello Krzysztof, Thanks for your work. On 2025-01-07 14:10:22 +0100, Krzysztof Kozlowski wrote: > DTS example in the bindings should be indented with 2- or 4-spaces and > aligned with opening '- |', so correct any differences like 3-spaces or > mixtures 2- and 4-spaces in one binding. > > No functional changes here, but saves some comments during reviews of > new patches built on existing code. > > Signed-off-by: Krzysztof Kozlowski For renesas,* Reviewed-by: Niklas Söderlund > --- > .../bindings/timer/arm,twd-timer.yaml | 6 +-- > .../bindings/timer/renesas,cmt.yaml | 44 +++++++++---------- > .../bindings/timer/renesas,em-sti.yaml | 10 ++--- > .../bindings/timer/renesas,mtu2.yaml | 14 +++--- > .../bindings/timer/renesas,ostm.yaml | 10 ++--- > .../bindings/timer/renesas,tmu.yaml | 22 +++++----- > .../bindings/timer/renesas,tpu.yaml | 8 ++-- > .../bindings/timer/sifive,clint.yaml | 2 +- > 8 files changed, 58 insertions(+), 58 deletions(-) > > diff --git a/Documentation/devicetree/bindings/timer/arm,twd-timer.yaml b/Documentation/devicetree/bindings/timer/arm,twd-timer.yaml > index 5684df6448ef..eb1127352c7b 100644 > --- a/Documentation/devicetree/bindings/timer/arm,twd-timer.yaml > +++ b/Documentation/devicetree/bindings/timer/arm,twd-timer.yaml > @@ -50,7 +50,7 @@ examples: > #include > > timer@2c000600 { > - compatible = "arm,arm11mp-twd-timer"; > - reg = <0x2c000600 0x20>; > - interrupts = ; > + compatible = "arm,arm11mp-twd-timer"; > + reg = <0x2c000600 0x20>; > + interrupts = ; > }; > diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml > index 5e09c04da30e..260b05f213e6 100644 > --- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml > +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml > @@ -178,29 +178,29 @@ examples: > #include > #include > cmt0: timer@ffca0000 { > - compatible = "renesas,r8a7790-cmt0", "renesas,rcar-gen2-cmt0"; > - reg = <0xffca0000 0x1004>; > - interrupts = , > - ; > - clocks = <&cpg CPG_MOD 124>; > - clock-names = "fck"; > - power-domains = <&sysc R8A7790_PD_ALWAYS_ON>; > - resets = <&cpg 124>; > + compatible = "renesas,r8a7790-cmt0", "renesas,rcar-gen2-cmt0"; > + reg = <0xffca0000 0x1004>; > + interrupts = , > + ; > + clocks = <&cpg CPG_MOD 124>; > + clock-names = "fck"; > + power-domains = <&sysc R8A7790_PD_ALWAYS_ON>; > + resets = <&cpg 124>; > }; > > cmt1: timer@e6130000 { > - compatible = "renesas,r8a7790-cmt1", "renesas,rcar-gen2-cmt1"; > - reg = <0xe6130000 0x1004>; > - interrupts = , > - , > - , > - , > - , > - , > - , > - ; > - clocks = <&cpg CPG_MOD 329>; > - clock-names = "fck"; > - power-domains = <&sysc R8A7790_PD_ALWAYS_ON>; > - resets = <&cpg 329>; > + compatible = "renesas,r8a7790-cmt1", "renesas,rcar-gen2-cmt1"; > + reg = <0xe6130000 0x1004>; > + interrupts = , > + , > + , > + , > + , > + , > + , > + ; > + clocks = <&cpg CPG_MOD 329>; > + clock-names = "fck"; > + power-domains = <&sysc R8A7790_PD_ALWAYS_ON>; > + resets = <&cpg 329>; > }; > diff --git a/Documentation/devicetree/bindings/timer/renesas,em-sti.yaml b/Documentation/devicetree/bindings/timer/renesas,em-sti.yaml > index 233d74d5402c..a7385d865bca 100644 > --- a/Documentation/devicetree/bindings/timer/renesas,em-sti.yaml > +++ b/Documentation/devicetree/bindings/timer/renesas,em-sti.yaml > @@ -38,9 +38,9 @@ examples: > - | > #include > timer@e0180000 { > - compatible = "renesas,em-sti"; > - reg = <0xe0180000 0x54>; > - interrupts = ; > - clocks = <&sti_sclk>; > - clock-names = "sclk"; > + compatible = "renesas,em-sti"; > + reg = <0xe0180000 0x54>; > + interrupts = ; > + clocks = <&sti_sclk>; > + clock-names = "sclk"; > }; > diff --git a/Documentation/devicetree/bindings/timer/renesas,mtu2.yaml b/Documentation/devicetree/bindings/timer/renesas,mtu2.yaml > index 15d8dddf4ae9..e56c12f03f72 100644 > --- a/Documentation/devicetree/bindings/timer/renesas,mtu2.yaml > +++ b/Documentation/devicetree/bindings/timer/renesas,mtu2.yaml > @@ -66,11 +66,11 @@ examples: > #include > #include > mtu2: timer@fcff0000 { > - compatible = "renesas,mtu2-r7s72100", "renesas,mtu2"; > - reg = <0xfcff0000 0x400>; > - interrupts = ; > - interrupt-names = "tgi0a"; > - clocks = <&mstp3_clks R7S72100_CLK_MTU2>; > - clock-names = "fck"; > - power-domains = <&cpg_clocks>; > + compatible = "renesas,mtu2-r7s72100", "renesas,mtu2"; > + reg = <0xfcff0000 0x400>; > + interrupts = ; > + interrupt-names = "tgi0a"; > + clocks = <&mstp3_clks R7S72100_CLK_MTU2>; > + clock-names = "fck"; > + power-domains = <&cpg_clocks>; > }; > diff --git a/Documentation/devicetree/bindings/timer/renesas,ostm.yaml b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml > index e8c642166462..9ba858f094ab 100644 > --- a/Documentation/devicetree/bindings/timer/renesas,ostm.yaml > +++ b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml > @@ -71,9 +71,9 @@ examples: > #include > #include > ostm0: timer@fcfec000 { > - compatible = "renesas,r7s72100-ostm", "renesas,ostm"; > - reg = <0xfcfec000 0x30>; > - interrupts = ; > - clocks = <&mstp5_clks R7S72100_CLK_OSTM0>; > - power-domains = <&cpg_clocks>; > + compatible = "renesas,r7s72100-ostm", "renesas,ostm"; > + reg = <0xfcfec000 0x30>; > + interrupts = ; > + clocks = <&mstp5_clks R7S72100_CLK_OSTM0>; > + power-domains = <&cpg_clocks>; > }; > diff --git a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml > index 75b0e7c70b62..b1229595acfb 100644 > --- a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml > +++ b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml > @@ -122,15 +122,15 @@ examples: > #include > #include > tmu0: timer@ffd80000 { > - compatible = "renesas,tmu-r8a7779", "renesas,tmu"; > - reg = <0xffd80000 0x30>; > - interrupts = , > - , > - , > - ; > - interrupt-names = "tuni0", "tuni1", "tuni2", "ticpi2"; > - clocks = <&mstp0_clks R8A7779_CLK_TMU0>; > - clock-names = "fck"; > - power-domains = <&sysc R8A7779_PD_ALWAYS_ON>; > - #renesas,channels = <3>; > + compatible = "renesas,tmu-r8a7779", "renesas,tmu"; > + reg = <0xffd80000 0x30>; > + interrupts = , > + , > + , > + ; > + interrupt-names = "tuni0", "tuni1", "tuni2", "ticpi2"; > + clocks = <&mstp0_clks R8A7779_CLK_TMU0>; > + clock-names = "fck"; > + power-domains = <&sysc R8A7779_PD_ALWAYS_ON>; > + #renesas,channels = <3>; > }; > diff --git a/Documentation/devicetree/bindings/timer/renesas,tpu.yaml b/Documentation/devicetree/bindings/timer/renesas,tpu.yaml > index 01554dff23d8..7a473b302775 100644 > --- a/Documentation/devicetree/bindings/timer/renesas,tpu.yaml > +++ b/Documentation/devicetree/bindings/timer/renesas,tpu.yaml > @@ -49,8 +49,8 @@ additionalProperties: false > examples: > - | > tpu: tpu@ffffe0 { > - compatible = "renesas,tpu"; > - reg = <0xffffe0 16>, <0xfffff0 12>; > - clocks = <&pclk>; > - clock-names = "fck"; > + compatible = "renesas,tpu"; > + reg = <0xffffe0 16>, <0xfffff0 12>; > + clocks = <&pclk>; > + clock-names = "fck"; > }; > diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > index b42d43d2de48..d6a73be66765 100644 > --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml > +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > @@ -76,6 +76,6 @@ examples: > <&cpu2intc 3>, <&cpu2intc 7>, > <&cpu3intc 3>, <&cpu3intc 7>, > <&cpu4intc 3>, <&cpu4intc 7>; > - reg = <0x2000000 0x10000>; > + reg = <0x2000000 0x10000>; > }; > ... > -- > 2.43.0 > > -- Kind Regards, Niklas Söderlund