From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ADB0E1EBFE2; Tue, 7 Jan 2025 14:54:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736261694; cv=none; b=d1BprIk0QD46z3bLNRa60+zSqoJQ83MusjaUSgmFoL10bB0JzBg0rlKF4gYrSwGDACwvqkjKSG8sxC+XoD5aCAd3yCLsMdcEJ7+0zWhGNQl9FBtdFNXHYAi5Nf5KoylsIK2hQ26ssqITBSQzGvU5yNHSiAs+mf8iiSEBOq59Oww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736261694; c=relaxed/simple; bh=VBHQV+/gU2eK8sKIAscAjkMxOOakYjY7hMpg8oS4Gsg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=k3B93vix77QtocVcYnapXiasvgfVaJrCbNwFkAPlKyKaypX1jNhbLcKl7NNoXNCQUXV0FeqVcp0rBx7ChFerOgQR/rpSc1PwMMBcNLh/dqKC45r1JZBPRInjqh1JmQmLMLLUyVSZ0Yay4Vf755eKLEOTdfBmHJv1k9gJf2Nstj4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 536511424; Tue, 7 Jan 2025 06:55:19 -0800 (PST) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E5B7F3F673; Tue, 7 Jan 2025 06:54:48 -0800 (PST) Date: Tue, 7 Jan 2025 14:54:46 +0000 From: Andre Przywara To: Lukas Schmid Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/4] dt-bindings: vendor-prefixes: Add NetCube Systems Austria name Message-ID: <20250107145446.16a8a4ea@donnerap.manchester.arm.com> In-Reply-To: <20250106190703.4015-2-lukas.schmid@netcube.li> References: <20250106190703.4015-1-lukas.schmid@netcube.li> <20250106190703.4015-2-lukas.schmid@netcube.li> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 6 Jan 2025 19:06:59 +0000 Lukas Schmid wrote: > NetCube Systems Austria builds Embedded Systems for use in IoT, IIoT, > or Smart Home scenarios. > > Website is still WIP, but the Links on it are active: > https://netcubesystems.at/ > > Signed-off-by: Lukas Schmid Just to give some more guidance on when to drop tags and when to not: If you are making real changes to the code, then it might be indicated to drop the tag, since the patch might not be anymore what the reviewer acknowledged. But if you are just fixing (especially improving/adding to) the commit message, or fixing some typo, then you keep the tag, to reduce the churn and avoid extra work again from the reviewer. This is sometimes not easy to decide, say for instance: is renaming a variable something covered by the tag? The new name might be worse or misleading, even though the code didn't really change. But in this case it's pretty clear that Krzysztof is surely fine with you adding extra info to the commit message, and the actual patch didn't change at all, so keeping his tag would be a good thing. If you are in doubt, then it's often good to drop the tag *and* point this out, for instance in the cover letter, like: "Krzysztof, I changed this and that in patch 1/4, so I dropped your tag." Cheers, Andre > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > index da01616802c7..a30ed9547098 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > @@ -1027,6 +1027,8 @@ patternProperties: > description: Neofidelity Inc. > "^neonode,.*": > description: Neonode Inc. > + "^netcube,.*": > + description: NetCube Systems Austria > "^netgear,.*": > description: NETGEAR > "^netlogic,.*":