devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Antoni Pokusinski <apokusinski01@gmail.com>
To: jic23@kernel.org, lars@metafoo.de, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	andrej.skvortzov@gmail.com, neil.armstrong@linaro.org,
	icenowy@aosc.io, megi@xff.cz, danila@jiaxyga.com,
	javier.carrasco.cruz@gmail.com, and@kernel.org
Cc: apokusinski01@gmail.com, linux-kernel@vger.kernel.org,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: [PATCH v2 0/2] iio: magnetometer: add support for Si7210
Date: Thu,  9 Jan 2025 00:44:09 +0100	[thread overview]
Message-ID: <20250108234411.882768-1-apokusinski01@gmail.com> (raw)

This patch series adds support for the Si7210 Hall effect I2C sensor.
The driver currently supports the basic functionalities (i.e. making
temperature and magnetic field measurements and changing the
measurements scale) but I plan to add support for some other features in
the future as well (e.g. the digital output interrupt).

---
Hello,
Thanks for the review. In the v2, I implemented all the necessary
improvements, the most important ones being the `vdd-supply` in DT-binding
together with a regulator, changing the temperature measurement scale to
milli-celsius and removal of the `otp_lock`. The lock removal could be
done since we read the OTP memory in probe only.
Best regards,
Antoni

Changes since v1:
* dt-binding: add `vdd-supply`
* si7210: reorder includes in alphabetic order
* si7210: add comment for `fetch_lock`
* si7210: remove `otp_lock`
* si7210: fetch_measurement: change result type to __be16
* si7210: use guard(mutex) instead of scoped_guard
* si7210: read_raw: use FIELD_GET to get raw temperature value
* si7210: read_raw: return temperature in milli-celsius
* si7210: use regulator for getting the voltage
* si7210: si7210_device_wake: remove unnecessary cast
* si7210: si7210_device_init: use fsleep instead of usleep_range
* si7210: si7210_probe: remove i2c_set_clientdata()
* si7210: minor alignment and formatting fixes

Antoni Pokusinski (2):
  dt-bindings: iio: magnetometer: add binding for Si7210
  iio: magnetometer: si7210: add driver for Si7210

 .../iio/magnetometer/silabs,si7210.yaml       |  48 ++
 drivers/iio/magnetometer/Kconfig              |  11 +
 drivers/iio/magnetometer/Makefile             |   2 +
 drivers/iio/magnetometer/si7210.c             | 428 ++++++++++++++++++
 4 files changed, 489 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/magnetometer/silabs,si7210.yaml
 create mode 100644 drivers/iio/magnetometer/si7210.c

-- 
2.25.1


             reply	other threads:[~2025-01-08 23:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-08 23:44 Antoni Pokusinski [this message]
2025-01-08 23:44 ` [PATCH v2 1/2] dt-bindings: iio: magnetometer: add binding for Si7210 Antoni Pokusinski
2025-01-10  9:21   ` Krzysztof Kozlowski
2025-01-08 23:44 ` [PATCH v2 2/2] iio: magnetometer: si7210: add driver " Antoni Pokusinski
2025-01-10  9:14   ` kernel test robot
2025-01-10 16:12   ` Christophe JAILLET
2025-01-10 22:51   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250108234411.882768-1-apokusinski01@gmail.com \
    --to=apokusinski01@gmail.com \
    --cc=and@kernel.org \
    --cc=andrej.skvortzov@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=danila@jiaxyga.com \
    --cc=devicetree@vger.kernel.org \
    --cc=icenowy@aosc.io \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=megi@xff.cz \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).