Re: [PATCH v5 9/9] misc: add FPC202 dual port controller driver

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Wed, Jan 08, 2025 at 05:14:10PM +0100, Romain Gantois wrote:
> The TI FPC202 dual port controller serves as a low-speed signal aggregator
> for common port types such as SFP, QSFP, Mini-SAS HD, and others.
> 
> It aggregates GPIO and I2C signals across two downstream ports, acting as
> both a GPIO controller and an I2C address translator for up to two logical
> devices per port.
> 
> Signed-off-by: Romain Gantois <romain.gantois@bootlin.com>
> ---
>  MAINTAINERS              |   1 +
>  drivers/misc/Kconfig     |  11 ++
>  drivers/misc/Makefile    |   1 +
>  drivers/misc/ti_fpc202.c | 440 +++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 453 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2ef5c0d395b3668167dddbd27237a2177f85571e..865ef413b38c293e1c7b1405322fafe9df81ea96 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -23502,6 +23502,7 @@ M:	Romain Gantois <romain.gantois@bootlin.com>
>  L:	linux-kernel@vger.kernel.org
>  S:	Maintained
>  F:	Documentation/devicetree/bindings/misc/ti,fpc202.yaml
> +F:	drivers/misc/ti_fpc202.c
>  
>  TI FPD-LINK DRIVERS
>  M:	Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 09cbe3f0ab1e56f85852c0cb50cfc03cae659d2b..3c7e82e86e4ae83eff84999d123cd8c0f018323c 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -114,6 +114,17 @@ config RPMB
>  
>  	  If unsure, select N.
>  
> +config TI_FPC202
> +	tristate "TI FPC202 Dual Port Controller"
> +	select GPIOLIB
> +	depends on I2C_ATR
> +	help
> +	  If you say yes here you get support for the Texas Instruments FPC202
> +	  Dual Port Controller.
> +
> +	  This driver can also be built as a module. If so, the module will be
> +	  called fpc202.
> +
>  config TIFM_CORE
>  	tristate "TI Flash Media interface support"
>  	depends on PCI
> diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
> index 40bf953185c773afa91f7784a286ae0752bb0b53..ba47db46a5ff2559de597447ce7e2d88e26efa61 100644
> --- a/drivers/misc/Makefile
> +++ b/drivers/misc/Makefile
> @@ -12,6 +12,7 @@ obj-$(CONFIG_ATMEL_SSC)		+= atmel-ssc.o
>  obj-$(CONFIG_DUMMY_IRQ)		+= dummy-irq.o
>  obj-$(CONFIG_ICS932S401)	+= ics932s401.o
>  obj-$(CONFIG_LKDTM)		+= lkdtm/
> +obj-$(CONFIG_TI_FPC202)         += ti_fpc202.o

Nit, you didn't use a tab here :(

thanks,

greg k-h