From: Andrei Simion <andrei.simion@microchip.com>
To: <nicolas.ferre@microchip.com>, <claudiu.beznea@tuxon.dev>,
<alexandre.belloni@bootlin.com>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>
Cc: <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Andrei Simion <andrei.simion@microchip.com>
Subject: [PATCH] ARM: dts: microchip: at91-sam9x75_curiosity: Add PMIC suspend voltage configuration
Date: Mon, 13 Jan 2025 09:17:11 +0200 [thread overview]
Message-ID: <20250113071710.40821-1-andrei.simion@microchip.com> (raw)
Add missing essential configuration for the PMIC rails, which is necessary
for proper low-power mode operation. This patch adds the required settings
to ensure that the regulators behave correctly during Suspend-to-RAM and
Standby states. Otherwise, after resuming, it receives: "No configuration"
message.
Our driver implements the set_suspend_voltage and set_suspend_mode
callbacks, which require the `regulator-suspend-microvolt` property to be
specified in the device tree for each regulator node. This property defines
the voltage level that the regulator should maintain during suspend mode.
Additionally, according to the datasheet, some regulators need to be turned
on or off during suspend mode. This patch addresses these requirements by
adding the `regulator-on-in-suspend` and `regulator-off-in-suspend`
properties where appropriate.
Fixes: 371a47c9a58a ("ARM: dts: microchip: sam9x75_curiosity: add sam9x75 curiosity board")
Signed-off-by: Andrei Simion <andrei.simion@microchip.com>
---
.../dts/microchip/at91-sam9x75_curiosity.dts | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts b/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts
index 1a6a909a5043..5514ad10cda5 100644
--- a/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts
+++ b/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts
@@ -110,10 +110,12 @@ vdd_3v3: VDD_IO {
regulator-state-standby {
regulator-on-in-suspend;
+ regulator-suspend-microvolt = <3300000>;
regulator-mode = <4>;
};
regulator-state-mem {
+ regulator-off-in-suspend;
regulator-mode = <4>;
};
};
@@ -128,11 +130,13 @@ vddioddr: VDD_DDR {
regulator-state-standby {
regulator-on-in-suspend;
+ regulator-suspend-microvolt = <1350000>;
regulator-mode = <4>;
};
regulator-state-mem {
regulator-on-in-suspend;
+ regulator-suspend-microvolt = <1350000>;
regulator-mode = <4>;
};
};
@@ -147,10 +151,12 @@ vddcore: VDD_CORE {
regulator-state-standby {
regulator-on-in-suspend;
+ regulator-suspend-microvolt = <1150000>;
regulator-mode = <4>;
};
regulator-state-mem {
+ regulator-off-in-suspend;
regulator-mode = <4>;
};
};
@@ -166,10 +172,12 @@ dcdc4: VDD_OTHER {
regulator-state-standby {
regulator-on-in-suspend;
+ regulator-suspend-microvolt = <1150000>;
regulator-mode = <4>;
};
regulator-state-mem {
+ regulator-off-in-suspend;
regulator-mode = <4>;
};
};
@@ -182,6 +190,11 @@ vldo1: LDO1 {
regulator-state-standby {
regulator-on-in-suspend;
+ regulator-suspend-microvolt = <3300000>;
+ };
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
};
};
@@ -192,6 +205,11 @@ vldo2: LDO2 {
regulator-state-standby {
regulator-on-in-suspend;
+ regulator-suspend-microvolt = <1800000>;
+ };
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
};
};
};
base-commit: 37136bf5c3a6f6b686d74f41837a6406bec6b7bc
--
2.34.1
next reply other threads:[~2025-01-13 7:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 7:17 Andrei Simion [this message]
2025-01-13 7:40 ` [PATCH] ARM: dts: microchip: at91-sam9x75_curiosity: Add PMIC suspend voltage configuration Mihai.Sain
2025-01-18 14:38 ` Claudiu Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250113071710.40821-1-andrei.simion@microchip.com \
--to=andrei.simion@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox