From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6225C1F91FF; Fri, 17 Jan 2025 10:39:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737110395; cv=none; b=MvacyTsIV0BYd3riVdQft3YOkMZJKRqpnz4jZYRfuHnpJRTZ1cmI4H4gP+a3/IJGTxr7SJGPfu0/57XQhSQqcvrP5G40IYx7HfuUYVYQL56rNLmUM+D7hx8g/Dp5CAsZtwivWCV0pTboOcBJ8GO4TFfYbkP1Xsx47u/PqBHUPZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737110395; c=relaxed/simple; bh=YXW+x9GgzgdecKu3CzDdV0DGCreYczj3I9qa8OAff9Q=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TYhpkpqLJsIEr7ZGrOzHCr4Dcr2h6SacQJwRKgf3fyxKW6S6v94sLKGTf8dJeU+YmeADJ1yuS9bItA66hdLeBKgGmOUn203JHsd3RqnSImG20OhWcSWfHLr7UhET3imYKX8In90o+kcAGUE3/mpEGkMfj6JkuucL0KhkVeGDB0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3403D1476; Fri, 17 Jan 2025 02:40:21 -0800 (PST) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3D2753F7B4; Fri, 17 Jan 2025 02:39:49 -0800 (PST) Date: Fri, 17 Jan 2025 10:39:41 +0000 From: Andre Przywara To: Vinod Koul Cc: Andras Szemzo , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Linus Walleij , Philipp Zabel , Maxime Ripard , Kishon Vijay Abraham I , Ulf Hansson , Paul Walmsley , Palmer Dabbelt , Albert Ou , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Florian Fainelli , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH 10/12] dt-bindings: phy: allwinner: add v853 usb phy Message-ID: <20250117103941.7f9bda7b@donnerap.manchester.arm.com> In-Reply-To: References: <20250110123923.270626-1-szemzo.andras@gmail.com> <20250110123923.270626-11-szemzo.andras@gmail.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 15 Jan 2025 07:51:50 +0000 Vinod Koul wrote: > On 10-01-25, 13:39, Andras Szemzo wrote: > > Document Allwinner v853 USB phy. > > > > Signed-off-by: Andras Szemzo > > --- > > .../phy/allwinner,sun8i-v853-usb-phy.yaml | 89 +++++++++++++++++++ > > 1 file changed, 89 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun8i-v853-usb-phy.yaml > > > > diff --git a/Documentation/devicetree/bindings/phy/allwinner,sun8i-v853-usb-phy.yaml b/Documentation/devicetree/bindings/phy/allwinner,sun8i-v853-usb-phy.yaml > > new file mode 100644 > > index 000000000000..773c3f476db8 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/allwinner,sun8i-v853-usb-phy.yaml > > @@ -0,0 +1,89 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/phy/allwinner,sun8i-v853-usb-phy.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Allwinner V853 USB PHY > > + > > +maintainers: > > + - Chen-Yu Tsai > > + - Maxime Ripard > > + > > +properties: > > + "#phy-cells": > > + const: 1 > > + > > + compatible: > > + const: > > + - allwinner,sun8i-v853-usb-phy > > Does this really need a new binding document, if so why... Cant this be > added to one of the existing docs which driver uses? The USB-PHY bindings don't differ too much on a first glance, but still enough in nasty details (number of PHYs supported, number of clocks required, etc.) to make a joint binding basically unreadable (we tried that). That's why we opted to have separate bindings. Now I believe it's worth to look for the closest existing binding, and just put the compatible in there, in the hope we don't need much else, and that it still stays readable. Cheers, Andre