From: Nathan Chancellor <nathan@kernel.org>
To: jassisinghbrar@gmail.com
Cc: paul.walmsley@sifive.com, palmer@dabbelt.com,
conor.dooley@microchip.com, conor+dt@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Valentina Fernandez <valentina.fernandezalanis@microchip.com>
Subject: Re: [PATCH v6 0/4] Add Microchip IPC mailbox
Date: Mon, 20 Jan 2025 05:19:55 -0700 [thread overview]
Message-ID: <20250120121955.GA3525889@ax162> (raw)
In-Reply-To: <20241217113134.3508333-1-valentina.fernandezalanis@microchip.com>
Hi Jassi,
On Tue, Dec 17, 2024 at 11:31:30AM +0000, Valentina Fernandez wrote:
...
> This series adds support for the Microchip Inter-Processor Communication
> (IPC) mailbox driver.
...
> Valentina Fernandez (4):
> riscv: sbi: vendorid_list: Add Microchip Technology to the vendor list
> riscv: export __cpuid_to_hartid_map
> dt-bindings: mailbox: add binding for Microchip IPC mailbox controller
> mailbox: add Microchip IPC support
I see this series is now in next-20250120 but you only applied patches 3
and 4, so the build is broken:
In file included from drivers/mailbox/mailbox-mchp-ipc-sbi.c:22:
drivers/mailbox/mailbox-mchp-ipc-sbi.c: In function 'mchp_ipc_sbi_chan_send':
drivers/mailbox/mailbox-mchp-ipc-sbi.c:29:42: error: 'MICROCHIP_VENDOR_ID' undeclared (first use in this function)
29 | MICROCHIP_VENDOR_ID)
| ^~~~~~~~~~~~~~~~~~~
arch/riscv/include/asm/sbi.h:436:56: note: in definition of macro 'sbi_ecall'
436 | __sbi_ecall(a0, a1, a2, a3, a4, a5, f, e)
| ^
drivers/mailbox/mailbox-mchp-ipc-sbi.c:121:25: note: in expansion of macro 'SBI_EXT_MICROCHIP_TECHNOLOGY'
121 | ret = sbi_ecall(SBI_EXT_MICROCHIP_TECHNOLOGY, command, channel,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/mailbox/mailbox-mchp-ipc-sbi.c:29:42: note: each undeclared identifier is reported only once for each function it appears in
29 | MICROCHIP_VENDOR_ID)
| ^~~~~~~~~~~~~~~~~~~
arch/riscv/include/asm/sbi.h:436:56: note: in definition of macro 'sbi_ecall'
436 | __sbi_ecall(a0, a1, a2, a3, a4, a5, f, e)
| ^
drivers/mailbox/mailbox-mchp-ipc-sbi.c:121:25: note: in expansion of macro 'SBI_EXT_MICROCHIP_TECHNOLOGY'
121 | ret = sbi_ecall(SBI_EXT_MICROCHIP_TECHNOLOGY, command, channel,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/mailbox/mailbox-mchp-ipc-sbi.c: In function 'mchp_ipc_sbi_send':
drivers/mailbox/mailbox-mchp-ipc-sbi.c:29:42: error: 'MICROCHIP_VENDOR_ID' undeclared (first use in this function)
29 | MICROCHIP_VENDOR_ID)
| ^~~~~~~~~~~~~~~~~~~
arch/riscv/include/asm/sbi.h:436:56: note: in definition of macro 'sbi_ecall'
436 | __sbi_ecall(a0, a1, a2, a3, a4, a5, f, e)
| ^
drivers/mailbox/mailbox-mchp-ipc-sbi.c:134:25: note: in expansion of macro 'SBI_EXT_MICROCHIP_TECHNOLOGY'
134 | ret = sbi_ecall(SBI_EXT_MICROCHIP_TECHNOLOGY, command, address,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/mailbox/mailbox-mchp-ipc-sbi.c: In function 'mchp_ipc_probe':
drivers/mailbox/mailbox-mchp-ipc-sbi.c:29:42: error: 'MICROCHIP_VENDOR_ID' undeclared (first use in this function)
29 | MICROCHIP_VENDOR_ID)
| ^~~~~~~~~~~~~~~~~~~
drivers/mailbox/mailbox-mchp-ipc-sbi.c:420:35: note: in expansion of macro 'SBI_EXT_MICROCHIP_TECHNOLOGY'
420 | ret = sbi_probe_extension(SBI_EXT_MICROCHIP_TECHNOLOGY);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
Can you please fix this? It is a little frustrating this is happening
just as the merge window opens...
Cheers,
Nathan
next prev parent reply other threads:[~2025-01-20 12:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 11:31 [PATCH v6 0/4] Add Microchip IPC mailbox Valentina Fernandez
2024-12-17 11:31 ` [PATCH v6 1/4] riscv: sbi: vendorid_list: Add Microchip Technology to the vendor list Valentina Fernandez
2024-12-17 18:19 ` Conor Dooley
2024-12-17 11:31 ` [PATCH v6 2/4] riscv: export __cpuid_to_hartid_map Valentina Fernandez
2024-12-17 18:19 ` Conor Dooley
2024-12-17 11:31 ` [PATCH v6 3/4] dt-bindings: mailbox: add binding for Microchip IPC mailbox controller Valentina Fernandez
2024-12-19 12:54 ` Rob Herring (Arm)
2024-12-17 11:31 ` [PATCH v6 4/4] mailbox: add Microchip IPC support Valentina Fernandez
2025-01-20 12:19 ` Nathan Chancellor [this message]
2025-01-20 16:19 ` [PATCH v6 0/4] Add Microchip IPC mailbox Jassi Brar
2025-02-03 19:15 ` patchwork-bot+linux-riscv
2025-06-16 18:44 ` Klara Modin
2025-06-17 12:02 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250120121955.GA3525889@ax162 \
--to=nathan@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=valentina.fernandezalanis@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox