From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6B791B3927; Tue, 21 Jan 2025 09:52:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737453152; cv=none; b=i8fwz2awzAEbrgfl9Kuc5oxxoFKuAOq8M8/gDtqGPe1q+vwy7aOxbKIFz3H0/AReSoqyhN3C1AAppOVO/5fISHEHrbLF9iML5iCgnYvNWoYm2CzyuSeNX1obJSAlixIl7HA37dHmCXSh6hYSj3bpAEyaOc3aNSuEqc1J1Mkam/s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737453152; c=relaxed/simple; bh=PROraVkzIJD81IIiVaOKlfp/Ts8aLobHr6k/3m6C0CA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VjGVcjxXjr/SgBYD9V92E03gXVBQaS6M8cD6uj93p4vihpTk7lVx83rKJ6Tcxzg5iqzAXWiHoY4OokOUuxSDcTm5hGtKvUgC6R7adivQzcgZvHoQxh/fJQ2FanSrIDaxVs+4rbLE7FaOT9mtnWuV7mwoKjXHg47Hm9cXCRvnavU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=O4xqtr0H; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="O4xqtr0H" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76701C4CEDF; Tue, 21 Jan 2025 09:52:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737453151; bh=PROraVkzIJD81IIiVaOKlfp/Ts8aLobHr6k/3m6C0CA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O4xqtr0HGdFA4rJciWtAE6HDzwkBHKo0Bv6xSKW5rOVbR5hxPhxWkUhO7EWu5nrGD MHj0nIDMMkDmLOozgFXX40WAGZa+kMrKO//XpI51pnvmaRHDtAew1NNLp9dsyRi+Kc MTDxLy2C8+BzLBj/3Sjodh+zw1tGb+gcDIeUqvnn+QRc5E6JUhSfB+tk73OE+hXqzx w76vgR9a709da+V5BF7grTVSVTeL92cm1pM3hDmFLFYEpznWSRt6UXPa1A6gWo4T/T zO06ZgOQdf140T4eQEfCyvREMG9Ila6BLH1cNbQ78P5ZMQ+orE6azV7S4dDDaFdZ1l uoily9ER40F1A== Date: Tue, 21 Jan 2025 10:52:27 +0100 From: Krzysztof Kozlowski To: Michal Wilczynski Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, drew@pdp7.com, guoren@kernel.org, wefu@redhat.com, jassisinghbrar@gmail.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, frank.binns@imgtec.com, matt.coster@imgtec.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, ulf.hansson@linaro.org, jszhang@kernel.org, p.zabel@pengutronix.de, m.szyprowski@samsung.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-pm@vger.kernel.org Subject: Re: [RFC v3 03/18] dt-bindings: firmware: thead,th1520: Add support for firmware node Message-ID: <20250121-lively-cocky-lorikeet-e0a3db@krzk-bin> References: <20250120172111.3492708-1-m.wilczynski@samsung.com> <20250120172111.3492708-4-m.wilczynski@samsung.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250120172111.3492708-4-m.wilczynski@samsung.com> On Mon, Jan 20, 2025 at 06:20:56PM +0100, Michal Wilczynski wrote: > diff --git a/MAINTAINERS b/MAINTAINERS > index 0fa7c5728f1e..c56a1fb6e02a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -20184,6 +20184,7 @@ M: Fu Wei > L: linux-riscv@lists.infradead.org > S: Maintained > T: git https://github.com/pdp7/linux.git > +F: Documentation/devicetree/bindings/firmware/thead,th1520-aon.yaml > F: Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml Misordered. > F: Documentation/devicetree/bindings/mailbox/thead,th1520-mbox.yaml > F: Documentation/devicetree/bindings/net/thead,th1520-gmac.yaml > @@ -20194,6 +20195,7 @@ F: drivers/mailbox/mailbox-th1520.c > F: drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c > F: drivers/pinctrl/pinctrl-th1520.c > F: include/dt-bindings/clock/thead,th1520-clk-ap.h > +F: include/dt-bindings/firmware/thead,th1520-aon.h > > RNBD BLOCK DRIVERS > M: Md. Haris Iqbal > diff --git a/include/dt-bindings/firmware/thead,th1520-aon.h b/include/dt-bindings/firmware/thead,th1520-aon.h > new file mode 100644 > index 000000000000..7607522289f7 > --- /dev/null > +++ b/include/dt-bindings/firmware/thead,th1520-aon.h > @@ -0,0 +1,18 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +/* > + * Copyright (C) 2022 Alibaba Group Holding Limited. > + * Copyright (c) 2024 Samsung Electronics Co., Ltd. > + * Author: Michal Wilczynski > + */ > + > +#ifndef __DT_BINDINGS_AON_TH1520_H > +#define __DT_BINDINGS_AON_TH1520_H > + > +#define TH1520_AON_VDEC_PD 1 > +#define TH1520_AON_NPU_PD 2 > +#define TH1520_AON_VENC_PD 3 > +#define TH1520_AON_GPU_PD 4 > +#define TH1520_AON_DSP0_PD 5 > +#define TH1520_AON_DSP1_PD 6 I don't see these being used in the driver. Can you point me? Best regards, Krzysztof