From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Yijie Yang <quic_yijiyang@quicinc.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
<netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/4] dt-bindings: net: ethernet-controller: Correct the definition of phy-mode
Date: Tue, 21 Jan 2025 14:08:40 +0100 [thread overview]
Message-ID: <20250121140840.18f85323@device-291.home> (raw)
In-Reply-To: <20250121-dts_qcs615-v3-1-fa4496950d8a@quicinc.com>
On Tue, 21 Jan 2025 15:54:53 +0800
Yijie Yang <quic_yijiyang@quicinc.com> wrote:
> Correct the definition of 'phy-mode' to reflect that RX and TX delays are
> added by the board, not the MAC, to prevent confusion and ensure accurate
> documentation.
That's not entirely correct though. The purpose of the RGMII variants
(TXID, RXID, ID) are mostly to know whether or not the PHY must add
internal delays. That would be when the MAC can't AND there's no PCB
delay traces. Some MAC can insert delays.
There's documentation here as well on that point :
https://elixir.bootlin.com/linux/v6.13-rc3/source/Documentation/networking/phy.rst#L82
So, MACs may insert delays. A modification for the doc, if needed,
would rather be :
- # RX and TX delays are added by the MAC when required
+ # RX and TX delays are added by the MAC or PCB traces when required
Thanks,
Maxime
next prev parent reply other threads:[~2025-01-21 13:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 7:54 [PATCH v3 0/4] Enable ethernet on qcs615 Yijie Yang
2025-01-21 7:54 ` [PATCH v3 1/4] dt-bindings: net: ethernet-controller: Correct the definition of phy-mode Yijie Yang
2025-01-21 13:08 ` Maxime Chevallier [this message]
2025-01-21 17:00 ` Andrew Lunn
2025-01-21 7:54 ` [PATCH v3 2/4] net: stmmac: dwmac-qcom-ethqos: Mask PHY mode if configured with rgmii-id Yijie Yang
2025-01-21 12:47 ` Krzysztof Kozlowski
2025-01-21 12:57 ` Russell King (Oracle)
2025-01-22 9:06 ` Yijie Yang
2025-01-22 8:56 ` Yijie Yang
2025-01-22 9:48 ` Krzysztof Kozlowski
2025-01-27 10:49 ` Konrad Dybcio
2025-02-10 3:09 ` Yijie Yang
2025-02-10 18:01 ` Konrad Dybcio
2025-02-10 21:28 ` Andrew Lunn
2025-02-11 2:14 ` Yijie Yang
2025-02-11 1:20 ` Yijie Yang
2025-01-21 13:17 ` Maxime Chevallier
2025-01-22 9:46 ` Yijie Yang
2025-01-21 17:10 ` Andrew Lunn
2025-01-22 10:04 ` Yijie Yang
2025-01-21 17:20 ` Andrew Lunn
2025-01-21 7:54 ` [PATCH v3 3/4] arm64: dts: qcom: qcs615: add ethernet node Yijie Yang
2025-02-01 15:48 ` Konrad Dybcio
2025-02-03 13:53 ` Konrad Dybcio
2025-01-21 7:54 ` [PATCH v3 4/4] arm64: dts: qcom: qcs615-ride: Enable " Yijie Yang
2025-02-03 13:52 ` Konrad Dybcio
2025-07-14 2:28 ` [PATCH v3 0/4] Enable ethernet on qcs615 Yijie Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250121140840.18f85323@device-291.home \
--to=maxime.chevallier@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_yijiyang@quicinc.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).