From: Manivannan Sadhasivam <mani@kernel.org>
To: Krishna Chaitanya Chundru <quic_krichai@quicinc.com>
Cc: "Krishna Chaitanya Chundru" <krishna.chundru@oss.qualcomm.com>,
cros-qcom-dts-watchers@chromium.org,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
quic_vbadigan@quicinc.com, quic_vpernami@quicinc.com,
quic_mrana@quicinc.com, mmareddy@quicinc.com
Subject: Re: [PATCH v3 3/4] PCI: dwc: Reduce DT reads by allocating host bridge via DWC glue driver
Date: Fri, 24 Jan 2025 15:06:35 +0530 [thread overview]
Message-ID: <20250124093635.hemydca7d7zeajaa@thinkpad> (raw)
In-Reply-To: <6e35eea5-2c7b-5d71-f39d-f9196a3c1b76@quicinc.com>
On Fri, Jan 24, 2025 at 01:56:25PM +0530, Krishna Chaitanya Chundru wrote:
>
>
> On 1/24/2025 11:48 AM, Manivannan Sadhasivam wrote:
> > On Tue, Jan 21, 2025 at 02:32:21PM +0530, Krishna Chaitanya Chundru wrote:
> > > Allow DWC glue drivers to allocate the host bridge, avoiding redundant
> > > device tree reads primarily in dw_pcie_ecam_supported().
> > >
> >
> > I don't understand what you mean by 'redundant device tree reads'. Please
> > explain.
> >
> In dw_pcie_ecam_supported () we are trying to read bus-range to find
> maximum bus range value. devm_pci_alloc_host_bridge() is already reading
> bus range it. If we move devm_pci_alloc_host_bridge() to start of the
> controller probe we can avoid reading the dt and use values stored in the
> host bridge.
This is the exact information you should put into the description. Do not assume
that the readers will have the background.
> This was recommended by bjorn in the v2.
>
Then you should add 'Suggested-by' tag.
- Mani
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2025-01-24 9:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 9:02 [PATCH v3 0/4] PCI: dwc: Add ECAM support with iATU configuration Krishna Chaitanya Chundru
2025-01-21 9:02 ` [PATCH v3 1/4] arm64: dts: qcom: sc7280: Increase config size to 256MB for ECAM feature Krishna Chaitanya Chundru
2025-01-24 5:40 ` Manivannan Sadhasivam
2025-01-21 9:02 ` [PATCH v3 2/4] PCI: dwc: Add ECAM support with iATU configuration Krishna Chaitanya Chundru
2025-01-24 6:12 ` Manivannan Sadhasivam
2025-01-28 12:53 ` Konrad Dybcio
2025-01-21 9:02 ` [PATCH v3 3/4] PCI: dwc: Reduce DT reads by allocating host bridge via DWC glue driver Krishna Chaitanya Chundru
2025-01-24 6:18 ` Manivannan Sadhasivam
2025-01-24 8:26 ` Krishna Chaitanya Chundru
2025-01-24 9:36 ` Manivannan Sadhasivam [this message]
2025-01-21 9:02 ` [PATCH v3 4/4] PCI: qcom: Enable ECAM feature Krishna Chaitanya Chundru
2025-01-24 6:58 ` Manivannan Sadhasivam
2025-01-24 8:21 ` Krishna Chaitanya Chundru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250124093635.hemydca7d7zeajaa@thinkpad \
--to=mani@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=jingoohan1@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mmareddy@quicinc.com \
--cc=quic_krichai@quicinc.com \
--cc=quic_mrana@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=quic_vpernami@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox