devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/2] dt-bindings: omap: Add TI Pandaboard A4 variant
@ 2025-01-23 17:49 Tom Rini
  2025-01-23 17:49 ` [PATCH v2 2/2] ARM: dts: omap4-panda-a4: Add missing model and compatible properties Tom Rini
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Tom Rini @ 2025-01-23 17:49 UTC (permalink / raw)
  To: linux-kernel
  Cc: Aaro Koskinen, Andreas Kemnade, Conor Dooley, Kevin Hilman,
	Krzysztof Kozlowski, Rob Herring, Robert Nelson, Roger Quadros,
	Tony Lindgren, devicetree, linux-omap

Document the ti,omap4-panda-a4 compatible string in the appropriate
place within the omap family binding file.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
Changes in v2:
- Include as part of the series with binding addition, make this be
  first.
- Rework as suggested by Andreas Kemnade (slight rewording after Robert
  reminded me A4 a production rev and not "alpha" rev.

Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Andreas Kemnade <andreas@kemnade.info>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Kevin Hilman <khilman@baylibre.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Robert Nelson <robertcnelson@gmail.com>
Cc: Roger Quadros <rogerq@kernel.org>
Cc: Tony Lindgren <tony@atomide.com>
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-omap@vger.kernel.org
---
 Documentation/devicetree/bindings/arm/ti/omap.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
index 93e04a109a12..3603edd7361d 100644
--- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
+++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
@@ -141,6 +141,13 @@ properties:
           - const: ti,omap4430
           - const: ti,omap4
 
+      - description: OMAP4 PandaBoard Revision A4 and later
+        items:
+          - const: ti,omap4-panda-a4
+          - const: ti,omap4-panda
+          - const: ti,omap4430
+          - const: ti,omap4
+
       - description: OMAP4 DuoVero with Parlor expansion board/daughter board
         items:
           - const: gumstix,omap4-duovero-parlor
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 2/2] ARM: dts: omap4-panda-a4: Add missing model and compatible properties
  2025-01-23 17:49 [PATCH v2 1/2] dt-bindings: omap: Add TI Pandaboard A4 variant Tom Rini
@ 2025-01-23 17:49 ` Tom Rini
  2025-01-23 18:42 ` [PATCH v2 1/2] dt-bindings: omap: Add TI Pandaboard A4 variant Conor Dooley
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Tom Rini @ 2025-01-23 17:49 UTC (permalink / raw)
  To: linux-kernel
  Cc: Conor Dooley, Krzysztof Kozlowski, Rob Herring, Robert Nelson,
	Tony Lindgren, devicetree, linux-omap

When moving the model and compatible properties out of the common
Pandaboard files and in to the specific boards, the omap4-panda-a4
file wasn't updated as well and so has lacked a model and compatible
entry ever since.

Fixes: a1a57abaaf82 ("ARM: dts: omap4-panda: Fix model and SoC family details")
Signed-off-by: Tom Rini <trini@konsulko.com>
---
Changes in v2:
- Include as part of the series with binding addition, make this the
  second patch.

Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Robert Nelson <robertcnelson@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-omap@vger.kernel.org
---
 arch/arm/boot/dts/ti/omap/omap4-panda-a4.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-a4.dts b/arch/arm/boot/dts/ti/omap/omap4-panda-a4.dts
index 8fd076e5d1b0..4b8bfd0188ad 100644
--- a/arch/arm/boot/dts/ti/omap/omap4-panda-a4.dts
+++ b/arch/arm/boot/dts/ti/omap/omap4-panda-a4.dts
@@ -7,6 +7,11 @@
 #include "omap443x.dtsi"
 #include "omap4-panda-common.dtsi"
 
+/ {
+	model = "TI OMAP4 PandaBoard (A4)";
+	compatible = "ti,omap4-panda-a4", "ti,omap4-panda", "ti,omap4430", "ti,omap4";
+};
+
 /* Pandaboard Rev A4+ have external pullups on SCL & SDA */
 &dss_hdmi_pins {
 	pinctrl-single,pins = <
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: omap: Add TI Pandaboard A4 variant
  2025-01-23 17:49 [PATCH v2 1/2] dt-bindings: omap: Add TI Pandaboard A4 variant Tom Rini
  2025-01-23 17:49 ` [PATCH v2 2/2] ARM: dts: omap4-panda-a4: Add missing model and compatible properties Tom Rini
@ 2025-01-23 18:42 ` Conor Dooley
  2025-01-24 20:54 ` Andreas Kemnade
  2025-02-06  0:37 ` Kevin Hilman
  3 siblings, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2025-01-23 18:42 UTC (permalink / raw)
  To: Tom Rini
  Cc: linux-kernel, Aaro Koskinen, Andreas Kemnade, Conor Dooley,
	Kevin Hilman, Krzysztof Kozlowski, Rob Herring, Robert Nelson,
	Roger Quadros, Tony Lindgren, devicetree, linux-omap

[-- Attachment #1: Type: text/plain, Size: 1935 bytes --]

On Thu, Jan 23, 2025 at 11:49:00AM -0600, Tom Rini wrote:
> Document the ti,omap4-panda-a4 compatible string in the appropriate
> place within the omap family binding file.
> 
> Signed-off-by: Tom Rini <trini@konsulko.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

> ---
> Changes in v2:
> - Include as part of the series with binding addition, make this be
>   first.
> - Rework as suggested by Andreas Kemnade (slight rewording after Robert
>   reminded me A4 a production rev and not "alpha" rev.
> 
> Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
> Cc: Andreas Kemnade <andreas@kemnade.info>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Robert Nelson <robertcnelson@gmail.com>
> Cc: Roger Quadros <rogerq@kernel.org>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
> ---
>  Documentation/devicetree/bindings/arm/ti/omap.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> index 93e04a109a12..3603edd7361d 100644
> --- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> +++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> @@ -141,6 +141,13 @@ properties:
>            - const: ti,omap4430
>            - const: ti,omap4
>  
> +      - description: OMAP4 PandaBoard Revision A4 and later
> +        items:
> +          - const: ti,omap4-panda-a4
> +          - const: ti,omap4-panda
> +          - const: ti,omap4430
> +          - const: ti,omap4
> +
>        - description: OMAP4 DuoVero with Parlor expansion board/daughter board
>          items:
>            - const: gumstix,omap4-duovero-parlor
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: omap: Add TI Pandaboard A4 variant
  2025-01-23 17:49 [PATCH v2 1/2] dt-bindings: omap: Add TI Pandaboard A4 variant Tom Rini
  2025-01-23 17:49 ` [PATCH v2 2/2] ARM: dts: omap4-panda-a4: Add missing model and compatible properties Tom Rini
  2025-01-23 18:42 ` [PATCH v2 1/2] dt-bindings: omap: Add TI Pandaboard A4 variant Conor Dooley
@ 2025-01-24 20:54 ` Andreas Kemnade
  2025-02-06  0:37 ` Kevin Hilman
  3 siblings, 0 replies; 5+ messages in thread
From: Andreas Kemnade @ 2025-01-24 20:54 UTC (permalink / raw)
  To: Tom Rini
  Cc: linux-kernel, Aaro Koskinen, Conor Dooley, Kevin Hilman,
	Krzysztof Kozlowski, Rob Herring, Robert Nelson, Roger Quadros,
	Tony Lindgren, devicetree, linux-omap

Am Thu, 23 Jan 2025 11:49:00 -0600
schrieb Tom Rini <trini@konsulko.com>:

> Document the ti,omap4-panda-a4 compatible string in the appropriate
> place within the omap family binding file.
> 
> Signed-off-by: Tom Rini <trini@konsulko.com>

Reviewed-by: Andreas Kemnade <andreas@kemnade.info>

Regards,
Andreas

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: omap: Add TI Pandaboard A4 variant
  2025-01-23 17:49 [PATCH v2 1/2] dt-bindings: omap: Add TI Pandaboard A4 variant Tom Rini
                   ` (2 preceding siblings ...)
  2025-01-24 20:54 ` Andreas Kemnade
@ 2025-02-06  0:37 ` Kevin Hilman
  3 siblings, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2025-02-06  0:37 UTC (permalink / raw)
  To: linux-kernel, Tom Rini
  Cc: Aaro Koskinen, Andreas Kemnade, Conor Dooley, Krzysztof Kozlowski,
	Rob Herring, Robert Nelson, Roger Quadros, Tony Lindgren,
	devicetree, linux-omap


On Thu, 23 Jan 2025 11:49:00 -0600, Tom Rini wrote:
> Document the ti,omap4-panda-a4 compatible string in the appropriate
> place within the omap family binding file.
> 
> 

Applied, thanks!

[1/2] dt-bindings: omap: Add TI Pandaboard A4 variant
      commit: a4ec13e6101ea750b17dc23f49f21d3f57623099
[2/2] ARM: dts: omap4-panda-a4: Add missing model and compatible properties
      commit: ea07a4775df03852c353514b5b7646a17bd425be

Best regards,
-- 
Kevin Hilman <khilman@baylibre.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-02-06  0:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-23 17:49 [PATCH v2 1/2] dt-bindings: omap: Add TI Pandaboard A4 variant Tom Rini
2025-01-23 17:49 ` [PATCH v2 2/2] ARM: dts: omap4-panda-a4: Add missing model and compatible properties Tom Rini
2025-01-23 18:42 ` [PATCH v2 1/2] dt-bindings: omap: Add TI Pandaboard A4 variant Conor Dooley
2025-01-24 20:54 ` Andreas Kemnade
2025-02-06  0:37 ` Kevin Hilman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).