From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32DD54207A for ; Sun, 26 Jan 2025 16:32:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737909153; cv=none; b=ZXNibgiYn5H351FvjpR6pFuBIEPUyYYIwbkZ6/crPcLtlsx/rI9FTifJcckCwE81Hcfn/KRlyaQgqx7enjvUMBaqxJkY0A5bGQsji6VpZynq3Hp9ALpP+3BHlRU3tiioLzfimdz+al8VxwlTLtVvRzLYbyMrxPn1GKFjJb83OIg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737909153; c=relaxed/simple; bh=jtSpTmRd14dGeM1nscXI3NZz05G5U5hkjF5piFg2+Qo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bEFByiNkLIIGxS716HMN7SluutDniMpIbyhUTTLLngFI8hvNNjmWV0c3bMZvBXrlP5l30EW+q6MnPXjHLyW0Lfcm5erzuwqPbsgt1faWSPE0GRG1vhTe1ikl/0RiaZa8deGJKtITFntyK9X1+ERDgXjJ476SP+vWf/qFGQfwb/4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=pp4B73xx; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pp4B73xx" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2166f1e589cso94069255ad.3 for ; Sun, 26 Jan 2025 08:32:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737909151; x=1738513951; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=a2/x7HsME78QH5GItm6A7JG5Awy99g+RmpskMFT3HS4=; b=pp4B73xxs4MF19GRKgxUkBCwB68RbWPzIzRlKNNsiwg5ixeM68BgLgxzRgLT4qnHiu LqdobHl2ocz5hylmHNnYhtOHGxTxSyrZ1ALltEoyXJA/5GV5cIloVbWFKGl4y0GfqlTl Q9rq8ZBjjxRPUltVSwex8JCOFj0N8UaVAjUi/67q2lvKBSsjCjO7Pny5Fr+1LvRz23JS OGv/RXmLqBKJCoaTY4J6gCgfPdI3FFcaK700zSsI+ErSUVAEZEy5BrGz3jP9c9ndDWs0 BI3YG9xTF9Aj50o02tWia71oj82TmFPg9KIwRww1sKqfeXjwKYzZCyGGaBQ9Viv6PaXD dddg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737909151; x=1738513951; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a2/x7HsME78QH5GItm6A7JG5Awy99g+RmpskMFT3HS4=; b=mPO7dDFO1g7/dEad1Iz0iZIFcqihgq5wMP22M0scKWObkOq2qChJkL4gf9KNTr7vpE 7LKBZ1WRmmUJdpTkcwCefi/vt8P9qh4F7ix5agpuKmEp0DAft6fvufzShSps1knk7S7v OckMeakFtUZL+P0nPkhuIss0sSbz8nnruVeYcb0v+MxfoKAd87d+bthxNoZuBvuesKEj cxaFt5U8weefxwVQ1JmVfV3zs3AXcpnUfDZSAcZwQoywZBlneRAaaQV3eBUW+OEp+ObT 5ISL/h+yPyJhpPQJOUocxcIQzq8mVISokfMEAi4NOopvusG6q2afzgcfEud5VeQ8/eZ6 OvCQ== X-Forwarded-Encrypted: i=1; AJvYcCXtfTL3Nc6HbDMCuUY2+5cdKjh8v9GAKRn4KyOapBdFNTgPtZ8IbABy5ilyFqLFrt5iqa6NdyO/SAJ5@vger.kernel.org X-Gm-Message-State: AOJu0YztJzQsq0DaT/K3c6zh568noK08JB6pXmxk7kEEPOo9K+TEz/h8 kvs/Ck0mr/y7EWAm9jCrLKI8c6xJh4ALfQH1vLJpXFCPd4xjgDuGCCOjZsaaiw== X-Gm-Gg: ASbGncuU4Y4PxHyDFJ9RghJTHLW/2gyXF99cIabXGw0SKNWG+wit14ebQpnss8h27hT Z17N9T7anfH+Glca9sORHpTSSCEJFB6fGn/yx08RXx38WCM+2BH+DfxBBCOWiaABt/8B7DxuGda cgUKKi0jTCRlUj6tPa8KEKNnuiA40TPW34iczRD7zmY+yvsx4wNn1n29Ior7Z4gHO5EQcPVIxBq BgrUFd2EL9nv6rU+dG/EDB5/aixdalkyycH/m/wqXh8ISUaJ4RM7JBKDQ9CQw9Bv2pm2j6YF861 KV79r1314K1Ang== X-Google-Smtp-Source: AGHT+IHWZ+glvl+mJSsUGZ6jx+icgq8knmen0W99ZVY+enJ/56I1feVryXG/4cV/Fv3EXPoE5i5z5w== X-Received: by 2002:a17:902:e747:b0:216:4b1f:499 with SMTP id d9443c01a7336-21c35623dc0mr481233015ad.31.1737909151476; Sun, 26 Jan 2025 08:32:31 -0800 (PST) Received: from thinkpad ([120.60.50.31]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da414cc20sm47994605ad.165.2025.01.26.08.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jan 2025 08:32:31 -0800 (PST) Date: Sun, 26 Jan 2025 22:02:22 +0530 From: Manivannan Sadhasivam To: Dmitry Baryshkov Cc: Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio Subject: Re: [PATCH 3/6] phy: qcom: qmp-pcie: Add X1P42100 Gen4x4 PHY Message-ID: <20250126163222.nhcxvr4m2vncwi23@thinkpad> References: <20250125-topic-x1p4_dts-v1-0-02659a08b044@oss.qualcomm.com> <20250125-topic-x1p4_dts-v1-3-02659a08b044@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sun, Jan 26, 2025 at 01:39:05PM +0200, Dmitry Baryshkov wrote: > On Sun, Jan 26, 2025 at 12:59:52PM +0530, Manivannan Sadhasivam wrote: > > > > > > On January 25, 2025 11:00:23 PM GMT+05:30, Dmitry Baryshkov wrote: > > >On Sat, Jan 25, 2025 at 04:31:19AM +0100, Konrad Dybcio wrote: > > >> From: Konrad Dybcio > > >> > > >> Add a new, common configuration for Gen4x4 V6 PHYs without an init > > >> sequence. > > >> > > >> The bootloader configures the hardware once and the OS retains that > > >> configuration by using the NOCSR reset line (which doesn't drop > > >> register state on assert) in place of the "full reset" one. > > > > > >I know your opinion, but my 2c would still be for not depending on the > > >bootloader. I think that was the rule for ages for many possible > > >reasons. > > > > > > > But if Linux or other OS can trust the bootloader, then it makes perfect sense to rely on them. Obviously, the question here is that on which platforms this level of trust should be established. And the answer I got was starting from the compute platforms (atleast X1E). > > Is there any way how those values can be lost that we still might want > to support ? The GDSC going to the OFF state? Some deep sleep state or a > power collapse? Actual suspend to RAM (instead of current S2Idle)? > As per Konrad's reply to my identical question, PHY register state is supposed to be maintained by MX domain even during CX PC. This seem to be case on X1E based platforms (compute). > > > > So let's take it on an experimental basis and see how it goes? If at all any problem arises, we can always resort to in kernel sequences. > > Sounds like a good proposal. Can possibly have a corresponding 'do not > merge' patch with actual init tables? > I don't find it really required. If the init sequences are really needed, we know where to find them. - Mani -- மணிவண்ணன் சதாசிவம்