Re: [PATCH 2/3] dt-bindings: firmware: stratix10: Convert to json-schema

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]

On Tue, Jan 28, 2025 at 01:07:05AM +0800, Mahesh Rao wrote:
> Hi Conor Dooley,
> 
> On Wed, 22 Jan 2025 18:40:41 +0000, Conor Dooley wrote:
> > > Convert intel,stratix10-svc service layer devicetree binding file from
> > > freeform format to json-schema.
> > 
> 
> > > +
> > > +  method:
> > > +    enum: [smc, hvc]
> > > +    description: supervisory call method to be used for the service layer.
> > 
> > This looks to be missing a type (string) and an explanation of what "smc" and
> > "hvc" are.
> > 
> 
> Thanks for pointing out , will do the change in next revision.
> 
> > > +
> > > +  fpga-mgr:
> > > +    $ref: /schemas/fpga/intel,stratix10-soc-fpga-mgr.yaml
> > > +    description: Optional child node for fpga manager to perform fabric
> > configuration.
> > 
> > This is new and not justified in your commit message. Please explain where
> > this has come from in v2.
> > 
> > Cheers,
> > Conor.
> > 
> 
> Sure, this is an optional child node/driver present in the device tree for
> the Agilex SoC devices, but it was not mentioned in the text documentation.
> Therefore, I had included it here. I will provide more details about this
> change in the next version.

Aye, the change itself is fine. Just mention what the rationale for
adding it is and you're good.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]