* [PATCH] dt-bindings: ARM: at91: add Calao USB boards
@ 2025-01-31 16:27 Wolfram Sang
2025-02-02 13:58 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2025-01-31 16:27 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Wolfram Sang, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Nicolas Ferre, Alexandre Belloni, Claudiu Beznea, devicetree
They have not been added so far. dtbs_check complains loudly.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Documentation/devicetree/bindings/arm/atmel-at91.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
index 0ec29366e6c2..42469a054a60 100644
--- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
+++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
@@ -23,6 +23,9 @@ properties:
- const: atmel,at91rm9200
- items:
- enum:
+ - calao,usb-a9260
+ - calao,usb-a9263
+ - calao,usb-a9g20
- olimex,sam9-l9260
- enum:
- atmel,at91sam9260
@@ -35,6 +38,11 @@ properties:
- atmel,at91sam9xe
- atmel,at91sam9x60
- const: atmel,at91sam9
+ - items:
+ - const: calao,usb-a9g20-lpw
+ - const: calao,usb-a9g20
+ - const: atmel,at91sam9g20
+ - const: atmel,at91sam9
- items:
- enum:
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: ARM: at91: add Calao USB boards
2025-01-31 16:27 [PATCH] dt-bindings: ARM: at91: add Calao USB boards Wolfram Sang
@ 2025-02-02 13:58 ` Krzysztof Kozlowski
2025-02-04 10:46 ` Wolfram Sang
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-02-02 13:58 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-arm-kernel, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Nicolas Ferre, Alexandre Belloni, Claudiu Beznea, devicetree
On Fri, Jan 31, 2025 at 05:27:13PM +0100, Wolfram Sang wrote:
> They have not been added so far. dtbs_check complains loudly.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> Documentation/devicetree/bindings/arm/atmel-at91.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> index 0ec29366e6c2..42469a054a60 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> @@ -23,6 +23,9 @@ properties:
> - const: atmel,at91rm9200
> - items:
> - enum:
> + - calao,usb-a9260
> + - calao,usb-a9263
> + - calao,usb-a9g20
I don't undertstand why calao,usb-a9g20 or existing olimex,sam9-l9260
can be fitted with any SoC. If that's expected, mention in commit msg.
If not, then this needs to be fixed, not grew.
> - olimex,sam9-l9260
> - enum:
> - atmel,at91sam9260
> @@ -35,6 +38,11 @@ properties:
> - atmel,at91sam9xe
> - atmel,at91sam9x60
> - const: atmel,at91sam9
Line break.
> + - items:
> + - const: calao,usb-a9g20-lpw
> + - const: calao,usb-a9g20
> + - const: atmel,at91sam9g20
> + - const: atmel,at91sam9
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: ARM: at91: add Calao USB boards
2025-02-02 13:58 ` Krzysztof Kozlowski
@ 2025-02-04 10:46 ` Wolfram Sang
0 siblings, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2025-02-04 10:46 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-arm-kernel, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Nicolas Ferre, Alexandre Belloni, Claudiu Beznea, devicetree
[-- Attachment #1: Type: text/plain, Size: 368 bytes --]
> > + - calao,usb-a9260
> > + - calao,usb-a9263
> > + - calao,usb-a9g20
>
> I don't undertstand why calao,usb-a9g20 or existing olimex,sam9-l9260
> can be fitted with any SoC. If that's expected, mention in commit msg.
> If not, then this needs to be fixed, not grew.
Can do the fixing.
Thanks for the review!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-04 10:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-31 16:27 [PATCH] dt-bindings: ARM: at91: add Calao USB boards Wolfram Sang
2025-02-02 13:58 ` Krzysztof Kozlowski
2025-02-04 10:46 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).