From: Herve Codina <herve.codina@bootlin.com>
To: "Alexander Stein" <alexander.stein@ew.tq-group.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"Maíra Canal" <mcanal@igalia.com>,
"Raspberry Pi Kernel Maintenance" <kernel-list@raspberrypi.com>,
"Marek Vasut" <marex@denx.de>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Louis Chauvet <louis.chauvet@bootlin.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Herve Codina <herve.codina@bootlin.com>
Subject: [PATCH v4 0/4] Add support for errors recovery in the TI SN65DSI83 bridge driver
Date: Mon, 3 Feb 2025 15:58:19 +0100 [thread overview]
Message-ID: <20250203145824.155869-1-herve.codina@bootlin.com> (raw)
Hi,
Usually the TI SN65DSI83 recovers from error by itself but during ESD
tests, we have some cases where the TI SN65DSI83 didn't recover.
In order to handle those cases, this series adds support for a recovery
mechanism.
Compare to the previous iteration, this v4 series:
- rebase on top of v6.14-rc1
- disable/re-enable irq in the failure detection and reset process
- Split the patch moving reset_pipe() from VC4 to a new helper
- Rename the new helper to drm_atomic_helper_reset_crtc()
- Remove state duplication and use bridge.encoder->crtc
Best regards,
Hervé Codina
Changes v3 -> v4
v3: https://lore.kernel.org/lkml/20250108101907.410456-1-herve.codina@bootlin.com/
- Patch 1:
No changes
- Patch 2 and 3 (patch 2 in v3):
Rename the helper to drm_atomic_helper_reset_crtc()
Split the patch available in v3 in two patches.
- Patch 4 (patch 3 in v3):
Take into account commit d2b8c6d549570 ("drm/bridge: ti-sn65dsi83:
Add ti,lvds-vod-swing optional properties"), available in v6.14-rc1.
Disable irq when a fault is detected and re-enable it after the pipe
reset.
Remove state duplication and use bridge.encoder->crtc directly
Changes v2 -> v3
v2: https://lore.kernel.org/lkml/20241217143216.658461-1-herve.codina@bootlin.com/
- Patch 1:
No changes
- Patch 2 (new in v3)
Move reset_pipe() from VC4 HDMI driver to a new atomic helper
- Patch 3
Use the new drm_atomic_helper_reset_pipe()
Patch removed in v3
- Patch 2 in v2
No more needed
Changes v1 -> v2
v1: https://lore.kernel.org/lkml/20241024095539.1637280-1-herve.codina@bootlin.com/
- Patch 1:
Add 'Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>'
Add 'Acked-by: Conor Dooley <conor.dooley@microchip.com>'
- Patch 2 (new patch in v2)
Introduce drm_atomic_helper_disable_connector()
- Patch 3 (patch 2 in v1)
Reset the output path instead of the full pipeline.
Update and add more information related to the bridge in commit log.
Herve Codina (4):
dt-bindings: display: bridge: sn65dsi83: Add interrupt
drm/atomic-helper: Introduce drm_atomic_helper_reset_crtc()
drm/vc4: hdmi: Use drm_atomic_helper_reset_crtc()
drm: bridge: ti-sn65dsi83: Add error recovery mechanism
.../bindings/display/bridge/ti,sn65dsi83.yaml | 3 +
drivers/gpu/drm/bridge/ti-sn65dsi83.c | 131 ++++++++++++++++++
drivers/gpu/drm/drm_atomic_helper.c | 41 ++++++
drivers/gpu/drm/vc4/vc4_hdmi.c | 30 +---
include/drm/drm_atomic_helper.h | 2 +
5 files changed, 178 insertions(+), 29 deletions(-)
--
2.47.1
next reply other threads:[~2025-02-03 14:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 14:58 Herve Codina [this message]
2025-02-03 14:58 ` [PATCH v4 1/4] dt-bindings: display: bridge: sn65dsi83: Add interrupt Herve Codina
2025-02-03 14:58 ` [PATCH v4 2/4] drm/atomic-helper: Introduce drm_atomic_helper_reset_crtc() Herve Codina
2025-02-03 15:56 ` Dmitry Baryshkov
2025-02-03 16:19 ` Herve Codina
2025-02-19 13:41 ` Simona Vetter
2025-02-20 10:44 ` Maxime Ripard
2025-02-20 14:07 ` Herve Codina
2025-02-03 14:58 ` [PATCH v4 3/4] drm/vc4: hdmi: Use drm_atomic_helper_reset_crtc() Herve Codina
2025-02-03 15:56 ` Dmitry Baryshkov
2025-02-03 16:20 ` Herve Codina
2025-02-03 14:58 ` [PATCH v4 4/4] drm: bridge: ti-sn65dsi83: Add error recovery mechanism Herve Codina
2025-02-03 15:56 ` [PATCH v4 0/4] Add support for errors recovery in the TI SN65DSI83 bridge driver Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250203145824.155869-1-herve.codina@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=andrzej.hajda@intel.com \
--cc=conor+dt@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel-list@raspberrypi.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.chauvet@bootlin.com \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marex@denx.de \
--cc=mcanal@igalia.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=thomas.petazzoni@bootlin.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).