From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83F7620ADC4 for ; Mon, 3 Feb 2025 16:26:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738599987; cv=none; b=J1muS0tJF6aIbpaATKEfCU/NP524Rx85upZIVaNPEGu0VHrAADnPqJAnykFu+4ZinJpMh2XL2ynH5mZcAwAMRdkOU+NkFjzQ+l9TYb+GNlzfrXqorJoWygslvCc0dwzXDIq4xGNAckBjUqnXlldxLtjwGxGZRIqjez2E1ZwIRJM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738599987; c=relaxed/simple; bh=OVibP8ReQyd3HQmntDn0iiGBJZzdEqwa87ZWcwRodw0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SXOlaGlLxRLSCrqS+ZYh8INdeMJEPNDEi+H7MtwLMI520Pscygh9Y2q6LCNRMNKyuCnlNbNW3EYOzJ/RxmxGNGTGVAq4ty2+aAQzY05pCYi5vPqgs2bBWhvd2GbqSdNzWNc3hkg1agnAmLPSMCvrPQsoI9Xvx5D3du7qJccASRE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WSit5eS9; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WSit5eS9" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-21680814d42so77930365ad.2 for ; Mon, 03 Feb 2025 08:26:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738599984; x=1739204784; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=fpVOevLK/nWn6zp5PxG8PfTYQAwpuKIZhTQ2q8JK1sU=; b=WSit5eS9RXGVOCTJ3Sf5kWBU2jEnJtiLb2D33Jc9Fzs4GRqZg+EycRTOA9O1CIJ0bN sOAiQfW4sp2VOnxF8AAUuD4ao5paRh5xkz73HC868qZvza6H5dFzFL5zvg0xuDEcFgnn l0iuXzPwRvAqeusDkzxbelsPpSnPde+Nae6xU3Kq96zoXEH0Tv3mgUKxDXMpIACO9AYh tXi+qaajoQYgkQhjS+yVk91rq6q6/K9NOo2N+g1W6nMyrb+WimMzKd9zmApa8cKMPYYa 0zf4aSdOfvmfh/h3QX0ldaflPIKJGJzUfYEvgqkkJRFywKOWi3894COOjLhkpL6sNM67 6zSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738599984; x=1739204784; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fpVOevLK/nWn6zp5PxG8PfTYQAwpuKIZhTQ2q8JK1sU=; b=SwEmfWIoVwUkDL6LxAuuyf5xTkAs/tUAh7olhUrRs1YEwQh3eIBCAOpmsn+9IeU/OT dHoEiofQ2x+I8/wnkwJ4shd2ITN2HQkEdjXBWY/5B2s/h7xsQ+xgL9+l7iToai0QIWDy p6IARUjPXJAfVkCYOCvGgZITOiqYa+dXwtaNRFqXMFmN+hdeCjKI/4I59AY+TRgM1RC+ FhtbmbpJZHufuUp33HGAotZTd4WygpQp2D1PqlIIEg/W1jrQMuwPZpklr9S5KIwEnqAK n0A7XZaEGMnc5c3xkTpARBPaO/hxCKOAG9KVjJFF5Av2trJDaznP4aWw4dHmEac5B+RZ MWYQ== X-Forwarded-Encrypted: i=1; AJvYcCVNg7AfsV76HEXJemJIHZNlFhHr7OajeaPzotXZWKO6wQjdtsQ7hMV0SZ8VlT9afxdeaHYX6CirBmdz@vger.kernel.org X-Gm-Message-State: AOJu0Yx9L5dePf9lAZvRYTxKkMCnXWkLqrpvEsdaPJkAftu/lYKCo4kS a+LhQfPda0yD1e0kDnZoHd5M2JfMYo641gJJQ/HgzIEkD7fE0hq9DLE1jEIeDQ== X-Gm-Gg: ASbGnctAGgBv0/bR8uo0uK4g9DTdLiB01KqgLI8BPzW8WSMTYLzuiZJriOWUebETPxV yKlJhlqbaGkKkHQLz6hBe2Ruq2U8DxFLBDgIjhcJmnH8LSbXxoPsAsDSwj4P4AvGtAgYVaWyPnJ Pq4rjhsL77zOuTnxmUYha6iLB2Dxl6TOfqMphPFfZxHsCmBuw4G2L32MiAjzMYuEZ99spVoKa24 E8ZbMAesXeTflQmgc+N1cTVJyhZBSr4DNyZ7w5+JgZs06bnFZfRuALQmJv2RmPfsReQMKovceV6 mibQG0PyQCHqqYJIVrOiEmr6Ig== X-Google-Smtp-Source: AGHT+IFOuXKAdtxhNw7CHCzZkSB+L34XynX4lNUCqGi6tRRgVguTo3ptD/9ETnLqXyet7OFZO69Avw== X-Received: by 2002:a17:902:f68a:b0:21a:8769:302e with SMTP id d9443c01a7336-21dd7c65746mr352286105ad.14.1738599983682; Mon, 03 Feb 2025 08:26:23 -0800 (PST) Received: from thinkpad ([120.60.129.34]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21de31ee1fasm78854315ad.44.2025.02.03.08.26.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 08:26:23 -0800 (PST) Date: Mon, 3 Feb 2025 21:56:17 +0530 From: Manivannan Sadhasivam To: Varadarajan Narayanan Cc: bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, kishon@kernel.org, andersson@kernel.org, konradybcio@kernel.org, p.zabel@pengutronix.de, dmitry.baryshkov@linaro.org, quic_nsekar@quicinc.com, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, Praveenkumar I , Konrad Dybcio Subject: Re: [PATCH v7 6/7] arm64: dts: qcom: ipq5332: Add PCIe related nodes Message-ID: <20250203162617.sstmdvv7d3k53izf@thinkpad> References: <20250122063411.3503097-1-quic_varada@quicinc.com> <20250122063411.3503097-7-quic_varada@quicinc.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250122063411.3503097-7-quic_varada@quicinc.com> On Wed, Jan 22, 2025 at 12:04:10PM +0530, Varadarajan Narayanan wrote: > From: Praveenkumar I > > Add phy and controller nodes for pcie0_x1 and pcie1_x2. > > Reviewed-by: Konrad Dybcio > Signed-off-by: Praveenkumar I > Signed-off-by: Varadarajan Narayanan Reviewed-by: Manivannan Sadhasivam One minor comment below. [...] > + assigned-clocks = <&gcc GCC_PCIE3X2_AUX_CLK>, > + <&gcc GCC_PCIE3X2_AXI_M_CLK>, > + <&gcc GCC_PCIE3X2_AXI_S_BRIDGE_CLK>, > + <&gcc GCC_PCIE3X2_AXI_S_CLK>, > + <&gcc GCC_PCIE3X2_RCHG_CLK>; > + > + assigned-clock-rates = <2000000>, > + <266666666>, > + <240000000>, > + <240000000>, > + <100000000>; > + Does the drivers really need to set clock rate for these many clocks? No, as per the reply to my similar question to IPQ5424: https://lore.kernel.org/linux-arm-msm/9206e44c-da4f-4bdb-850f-fac511f4ddc7@quicinc.com/ - Mani -- மணிவண்ணன் சதாசிவம்