Re: [PATCH 1/2] dt-bindings: hwmon: ir38060: Move & update dt binding

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 5502 bytes --]

On Wed, Feb 05, 2025 at 03:51:25PM +0530, Naresh Solanki wrote:
> On Wed, 5 Feb 2025 at 00:52, Conor Dooley <conor@kernel.org> wrote:
> > On Tue, Feb 04, 2025 at 11:33:03PM +0530, Naresh Solanki wrote:
> > > Move dt binding under hwmon/pmbus & align accordingly.
> > >
> > > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> > > ---
> > >  .../hwmon/pmbus/infineon,ir38060.yaml         | 61 +++++++++++++++++++
> > >  .../bindings/regulator/infineon,ir38060.yaml  | 45 --------------
> > >  2 files changed, 61 insertions(+), 45 deletions(-)
> > >  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml
> > >  delete mode 100644 Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml
> > > new file mode 100644
> > > index 000000000000..e1f683846a54
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml
> > > @@ -0,0 +1,61 @@
> > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/hwmon/pmbus/infineon,ir38060.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Infineon Buck Regulators with PMBUS interfaces
> > > +
> > > +maintainers:
> > > +  - Not Me.
> >
> > How the hell did this get merged!
> >
> > > +
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - infineon,ir38060
> > > +      - infineon,ir38064
> > > +      - infineon,ir38164
> > > +      - infineon,ir38263
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +  regulators:
> > > +    type: object
> > > +    description:
> > > +      list of regulators provided by this controller.
> >
> > Can you explain why this change is justified? Your commit message is
> > explaining what you're doing but not why it's okay to do.

> This is based on other similar dt-bindings under hwmon/pmbus.

Okay, but what I am looking for is an explanation of why it is okay to
change the node from

| regulator@34 {
|   compatible = "infineon,ir38060";
|   reg = <0x34>;
| 
|   regulator-min-microvolt = <437500>;
|   regulator-max-microvolt = <1387500>;
| };

to

| regulator@34 {
|     compatible = "infineon,ir38060";
|     reg = <0x34>;
| 
|     regulators {
|         vout {
|             regulator-name = "p5v_aux";
|             regulator-min-microvolt = <437500>;
|             regulator-max-microvolt = <1387500>;
|         };
|     };

?

Will the driver handle both of these identically? Is backwards
compatibility with the old format maintained? Was the original format
wrong and does not work? Why is a list of regulators needed when the
device only provides one?

Cheers,
Conor.

> > > +    properties:
> > > +      vout:
> > > +        $ref: /schemas/regulator/regulator.yaml#
> > > +        type: object
> > > +
> > > +        unevaluatedProperties: false
> > > +
> > > +    additionalProperties: false
> > > +
> > > +required:
> > > +  - compatible
> > > +  - reg
> > > +
> > > +unevaluatedProperties: false
> > > +
> > > +examples:
> > > +  - |
> > > +    i2c {
> > > +        #address-cells = <1>;
> > > +        #size-cells = <0>;
> > > +
> > > +        regulator@34 {
> > > +            compatible = "infineon,ir38060";
> > > +            reg = <0x34>;
> > > +
> > > +            regulators {
> > > +                vout {
> > > +                    regulator-name = "p5v_aux";
> > > +                    regulator-min-microvolt = <437500>;
> > > +                    regulator-max-microvolt = <1387500>;
> > > +                };
> > > +            };
> > > +        };
> > > +    };
> > > diff --git a/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml b/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml
> > > deleted file mode 100644
> > > index e6ffbc2a2298..000000000000
> > > --- a/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml
> > > +++ /dev/null
> > > @@ -1,45 +0,0 @@
> > > -# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > > -%YAML 1.2
> > > ----
> > > -$id: http://devicetree.org/schemas/regulator/infineon,ir38060.yaml#
> > > -$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > -
> > > -title: Infineon Buck Regulators with PMBUS interfaces
> > > -
> > > -maintainers:
> > > -  - Not Me.
> > > -
> > > -allOf:
> > > -  - $ref: regulator.yaml#
> > > -
> > > -properties:
> > > -  compatible:
> > > -    enum:
> > > -      - infineon,ir38060
> > > -      - infineon,ir38064
> > > -      - infineon,ir38164
> > > -      - infineon,ir38263
> > > -
> > > -  reg:
> > > -    maxItems: 1
> > > -
> > > -required:
> > > -  - compatible
> > > -  - reg
> > > -
> > > -unevaluatedProperties: false
> > > -
> > > -examples:
> > > -  - |
> > > -    i2c {
> > > -      #address-cells = <1>;
> > > -      #size-cells = <0>;
> > > -
> > > -      regulator@34 {
> > > -        compatible = "infineon,ir38060";
> > > -        reg = <0x34>;
> > > -
> > > -        regulator-min-microvolt = <437500>;
> > > -        regulator-max-microvolt = <1387500>;
> > > -      };
> > > -    };
> > >
> > > base-commit: bfbb730c4255e1965d202f48e7aa71baa9a7c65b
> > > --
> > > 2.42.0
> > >

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]