public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] arm64: dts: ti: k3-am62p: Enable AUDIO_REFCLKx
Date: Thu, 6 Feb 2025 19:42:39 -0600	[thread overview]
Message-ID: <20250207014239.xzm6rfnusckql2uo@litigator> (raw)
In-Reply-To: <20250206153911.414702-1-francesco@dolcini.it>

On 16:39-20250206, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> On AM62P-based SoCs the AUDIO_REFCLKx clocks can be used as an input to
> external peripherals when configured through CTRL_MMR, so add the
> clock nodes.
> 
> Link: http://downloads.ti.com/tisci/esd/latest/5_soc_doc/am62px/clocks.html
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am62p-main.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
> index 420c77c8e9e5..4b47b0774330 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
> @@ -42,6 +42,26 @@ &inta_main_dmss {
>  	ti,interrupt-ranges = <5 69 35>;
>  };
>  
> +&main_conf {

	Why not add it to main_conf section it self in the file?

> +	audio_refclk0: clock-controller@82e0 {
> +		compatible = "ti,am62-audio-refclk";
> +		reg = <0x82e0 0x4>;
> +		clocks = <&k3_clks 157 0>;
> +		assigned-clocks = <&k3_clks 157 0>;
> +		assigned-clock-parents = <&k3_clks 157 16>;
> +		#clock-cells = <0>;
> +	};
> +
> +	audio_refclk1: clock-controller@82e4 {
> +		compatible = "ti,am62-audio-refclk";
> +		reg = <0x82e4 0x4>;
> +		clocks = <&k3_clks 157 18>;
> +		assigned-clocks = <&k3_clks 157 18>;
> +		assigned-clock-parents = <&k3_clks 157 34>;
> +		#clock-cells = <0>;
> +	};
> +};
> +
>  &main_pmx0 {
>  	pinctrl-single,gpio-range =
>  		<&main_pmx0_range 0 32 PIN_GPIO_RANGE_IOPAD>,
> -- 
> 2.39.5
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

  reply	other threads:[~2025-02-07  1:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-06 15:39 [PATCH v1] arm64: dts: ti: k3-am62p: Enable AUDIO_REFCLKx Francesco Dolcini
2025-02-07  1:42 ` Nishanth Menon [this message]
2025-02-07  8:33   ` Francesco Dolcini
2025-02-28 12:43     ` Francesco Dolcini
2025-02-28 13:53       ` Nishanth Menon
2025-03-02 13:19 ` Vignesh Raghavendra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250207014239.xzm6rfnusckql2uo@litigator \
    --to=nm@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=francesco.dolcini@toradex.com \
    --cc=francesco@dolcini.it \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox