From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECC0016ABC6 for ; Sun, 9 Feb 2025 15:21:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739114511; cv=none; b=vAxftLwCFY5+c3VgkW38U4jZlYIn3MW6OMRdSbONFa3vVbkabukDWMm1saLF5WNOp2VMai7j7oX2pIqpJIxqAWHSy4iiSJ4C8ikQVPUZFNev4m6MBa/hmD27dsX5TJWVMGvews5tcCctv0m6EqjpA6jiNbKaqVhV5x6yooKo790= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739114511; c=relaxed/simple; bh=B+Taz8FFto55mnsYPpqIlTqX7N41JrWkgq8m3UsOdqI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mcgrlNb2HmcH7cpfST09XIMCbMf5zvE6Y/SoTN2VCIiLEtQdvGwtdhAY2+g7Dz3iTQAuQYokk3eGQLjlnYG7UXFkH83zc6SZ4TW4ZcVH8pxt8XGgLFaSvaj8r+a3sRy2XKfCo4ogcBAY2u9JE2r/jGcc8elJD6yBdWgEnTB2hpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=XWs1lQi3; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XWs1lQi3" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-2f83a8afcbbso5554809a91.1 for ; Sun, 09 Feb 2025 07:21:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739114509; x=1739719309; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=JljyH7L9Kp4vXvGrsHV+BTlHpLmdgYdjpTOUSBHWabo=; b=XWs1lQi3+dRO7oPD7nuQWcWbqBJgVQokH5fkTFGwAtVzfZS68j9/ACF/J572Om5+xs JWOyQwMzaVAacYRNeY2ibxmGndnkexd2dKed846fPwhIarTBvgU+gLrIFHhy3/3gRPmI +FmZihmgfR2jxcKthK0pTjNhXaFiFM+808fOqc9cr/yb0M2akwHe258m0i8QQSLeqfRC Bu/W2qv4+WPWI53jIDCLdZ7XEkW8G5T/53Y92LG+J0K6Y0OKlaTvjIz4/fW/hcAsb9oz jSUl43ogBpCdTeXLZ94BV0LOgVEX4PKztGMAU27zGzRKbGSE2gDI9dBNs5iolIUQApMk 4Y6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739114509; x=1739719309; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JljyH7L9Kp4vXvGrsHV+BTlHpLmdgYdjpTOUSBHWabo=; b=R4GimDcDffz4iw8b/ie+FV+CS9aWEB2aUcn6AQa3M76VhCeWpDq37jQO5jteB/gpNc edB3kEo/LCcuaHWMdGSI2vCVcrB62u4gu8cOApN5Z5tDRIfnThhu6O79zfhQW/Z2kKez XVwFOIaUjz3taoKmUQjkRupVTAPlJJbFIVNchYTxT0Jx6F5auxJ/72optpmLY4O1tT+W rtPp8Bw/bopBz13eVHqqG522BFxrceNcyYgVaa80hTq4DejJ9gSOZ+gVXGPEUJyVCpoM wc1I5h6fglcljhcsxpFd3WSXd/0NK3tePj4dooUvwNTO7vKjemBLya2qgu6d3FsIVJjC OHog== X-Forwarded-Encrypted: i=1; AJvYcCXZfElxDFW2yC+VxU5fZxnvDgT5WjG7heTww/1auB07SVfuGnwMdmAKfh5wT3B+cgTZtUPY7ZZ6Ogrr@vger.kernel.org X-Gm-Message-State: AOJu0YyXfG7MaVUkmOGEdnSGPozwMaLKaGZwfMFl4qPgAKz5Ti+WVRPk IyABsH5CE01viqyv1nTlOpwPHH3dqfypDvkNpfveoMPINV/R0YEGcRHQU+dYHMz2cvpLCromBBU = X-Gm-Gg: ASbGncvQU6VgTQJBjuomTmFtrlGB6hGYeCE6YSaByWyTDpn6CvQWYqvc+VreOTw4Rg2 UM+6ayEp0ORVX/995DpXUc9+VbE1p4Fr9jTypYddXvOy7vI3Z4EvZyGx1mZWwzGMuhvtFNRmO3Q xzU3I0xmNONyX2NYxhPcRyGB9HYv5qm9E96gLLzU3+0hweEwHU0D1gmg4uc0iDrCMWYKfoI6JO6 LE6jRea9vkxX2VTZM3bal0Jvx+jH1zPKXrwfueLPSPtlCYQ/3RmIaaaeBBx7YNLx+DGSkfY89aU mYFD01E1+G1BhD+lqmKtshUSYQjZ X-Google-Smtp-Source: AGHT+IGWNpvwwkvO1VPlAyxGXl/1r1Q1NAlHKL3FT+xI1xaRL3g54LRlf6f/W3+YFvSs2/+0N4SfAQ== X-Received: by 2002:a17:90b:3847:b0:2fa:603e:905c with SMTP id 98e67ed59e1d1-2fa603e909emr5034546a91.2.1739114509226; Sun, 09 Feb 2025 07:21:49 -0800 (PST) Received: from thinkpad ([220.158.156.173]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fa0b9c5872sm3020467a91.0.2025.02.09.07.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Feb 2025 07:21:48 -0800 (PST) Date: Sun, 9 Feb 2025 20:51:40 +0530 From: Manivannan Sadhasivam To: Konrad Dybcio Cc: Melody Olvera , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Avri Altman , Bart Van Assche , Bjorn Andersson , Andy Gross , Konrad Dybcio , Satya Durga Srinivasu Prabhala , Trilok Soni , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Nitin Rawat , Manish Pandey Subject: Re: [PATCH 0/5] Add UFS support for SM8750 Message-ID: <20250209152140.cyry6g7ltccxcmyj@thinkpad> References: <20250113-sm8750_ufs_master-v1-0-b3774120eb8c@quicinc.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Feb 07, 2025 at 11:47:12PM +0100, Konrad Dybcio wrote: > On 13.01.2025 10:46 PM, Melody Olvera wrote: > > Add UFS support for SM8750 SoCs. > > > > Signed-off-by: Melody Olvera > > --- > > Nitin Rawat (5): > > dt-bindings: phy: qcom,sc8280xp-qmp-ufs-phy: Document the SM8750 QMP UFS PHY > > phy: qcom-qmp-ufs: Add PHY Configuration support for SM8750 > > dt-bindings: ufs: qcom: Document the SM8750 UFS Controller > > arm64: dts: qcom: sm8750: Add UFS nodes for SM8750 SoC > > arm64: dts: qcom: sm8750: Add UFS nodes for SM8750 QRD and MTP boards > > You still need the same workaround 8550/8650 have in the UFS driver > (UFSHCD_QUIRK_BROKEN_LSDBS_CAP) for it to work reliably, or at least > that was the case for me on a 8750 QRD. > > Please check whether we can make that quirk apply based on ctrl > version or so, so that we don't have to keep growing the compatible > list in the driver. > That would be a bizarre. When I added the quirk, I was told that it would affect only SM8550 and SM8650 (this one I learned later). I'm not against applying the quirk based on UFSHC version if the bug is carried forward, but that would be an indication of bad design. - Mani -- மணிவண்ணன் சதாசிவம்