From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECB9F2F22 for ; Mon, 10 Feb 2025 07:52:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739173923; cv=none; b=iIDLtmpqzaUVp5G+5ZAsyJOWbkVgFc8IKkHe2qcWrlh4RPjKgAHdoYq7Hlic6uBYRE2r4odQTG6fxHiMAxatzTbhCBcaiAM75kvEDkir/xPGqfVhyVvaYNt31ZOaQsOVhCNkUpY8lG+XOPpqZC12S7bDJM2LbUq7ltlW52oZ7T4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739173923; c=relaxed/simple; bh=SbiBsePgUUDw8ub83Bn9h4Z6Q+/Z2UG671GLzYjIXHI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OWUdjJfiPsd18+GQ7ESxWme3UDLMEt52jbT7cT25IqtfMw+Ac0b93HpMgtB8kt9yxY1B7R3i+l621oUWwUY65N5G3hvdb4/wh5l9n2WksB5Sq0LR1w2CGY/+pccf3Tm/vqXdpZl9NnG2/Qhpr8X+nz14htmWloMveSrxtDwStCE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=iSQjYFTE; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iSQjYFTE" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-21f4500a5c3so75722345ad.3 for ; Sun, 09 Feb 2025 23:52:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739173921; x=1739778721; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=jRRm29wGMApxPz8FgRvy/J5UYrL30LQ9avtohjE2Q3o=; b=iSQjYFTEgU3v8EvCcFO3B+QjnAAKJ1ZbmdtTVyoKGUzI7wXHD2OkIa36cAIaBumphT jt4ogZKCR05t3a3mKZr0FWRfw9QC/IYdutS1NuSMKGgI6tJaOrFPDbE3IpNvsZdk+9cB vREc+c1aCclli/Oxd1zZJN45E4f6G4HbKm6tMnqbVFVmvlOHkKFQvBthhhErTcX0iJFh KOfRscX8Vxze3TcHl+C7CZYB4iKb/nOmTjvUnGJxxHy3iO+7iRCCKsn4HhBU0lRROw7R bz3cXP1hcoS/aAYrhnHDhyK+vNR81R2dLeJ3r6++94FD5fxm8d1iMIW9ch1tFvcVasKi dBCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739173921; x=1739778721; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jRRm29wGMApxPz8FgRvy/J5UYrL30LQ9avtohjE2Q3o=; b=UFsTKlVAhmDsqiMKotwWRi+N0RFXr3xI9mfEFQRz/92KjZ5UDmAbHiRyuHAOQ/1cbg BsSi+8j7YTMjVMcO6i3SGd0DWBLdcaWl692vBNcgGzqM/ZAU/65JdhpD68taH5jWKQpc 3DJlAfzKbKyUSsn0kPpa87h3sUYWsWxT/C7BLt7hJPEn4KWDuEzoiL6BPwaG0Ic9z8yw YZQfCWhh3zTbUS6ilJL4Km8u/TDKW6szqfjr1gpIM8TBAmdS9RbeGqdTX9hyiu33bAzV +b7unVyaTFufJf9+muMEhsGIvISQkY109fWRF5Na0nr+WcPHSu8VuQsNZb1UzzLsnmuj 71pQ== X-Forwarded-Encrypted: i=1; AJvYcCVguhe0TE2VgI6LcbBnAjpWj8dT/9QtYLOgQTf6YkhWnk2qBLwDUR97kS/oOnpeo59IB0PfNbpYk7Kr@vger.kernel.org X-Gm-Message-State: AOJu0Ywnj5BQxo8sxBL1S9NLzMK+oH61TV0Y4Ux3TzFBRiUUYcgGfvOp SdzGx3qL12oKZseNwdDqsOLefQCxb7lRqh+xBcXbm5eElqLpnjTfj02j9lJ1og== X-Gm-Gg: ASbGncusYWF3IWRQbGv/oZW9y/yIOV+s7J729tj5bmhzfYTfuBYKXtSrkLAlYf+6EF+ STozILARrgHs0dbcaFq1r2+2gKLxWfdLX58GYyC7y93mQ6VBkxLxiLaSdSB7QexcqEhZtuxmUo4 uHZwl0nztF/gv4WlHSwxn9sXC9CEun+lSghnaLbf6QXQADIYQC5x+2lhLABHysXTSYWD8A7ppZV O2vWn8/MgRVh0KnEJVvAyLfOgIzMi10R499eFOpsNVif8AqNmSUfa4M4hl6m6n3gf6DnRRcYmzC Wc7EjgK9dGr4Fd5cC9kx/hTtN7Y4 X-Google-Smtp-Source: AGHT+IFiBhqV22C5q8pOwc0SqHNUPt/CKAPUfMB5p7rCsPdXXm7wz9qVBmWTaac8lz1b+Tnnpgp3rQ== X-Received: by 2002:a17:902:f806:b0:21f:dc3:8901 with SMTP id d9443c01a7336-21f4e7985c6mr166681905ad.34.1739173921291; Sun, 09 Feb 2025 23:52:01 -0800 (PST) Received: from thinkpad ([220.158.156.173]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f3650e6cbsm72256895ad.40.2025.02.09.23.51.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Feb 2025 23:52:00 -0800 (PST) Date: Mon, 10 Feb 2025 13:21:55 +0530 From: Manivannan Sadhasivam To: Krishna Chaitanya Chundru Cc: Rob Herring , andersson@kernel.org, Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, Jingoo Han , Bartosz Golaszewski , quic_vbadigan@quicinc.com, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/6] dt-bindings: PCI: Add binding for qps615 Message-ID: <20250210075155.ka3fy3xiptyy3w6i@thinkpad> References: <20241112-qps615_pwr-v3-0-29a1e98aa2b0@quicinc.com> <20241112-qps615_pwr-v3-1-29a1e98aa2b0@quicinc.com> <20241115161848.GA2961450-robh@kernel.org> <74eaef67-18f2-c2a1-1b9c-ac97cefecc54@quicinc.com> <83337e51-6554-6543-059d-c71a50601b09@quicinc.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <83337e51-6554-6543-059d-c71a50601b09@quicinc.com> On Wed, Dec 04, 2024 at 02:19:56PM +0530, Krishna Chaitanya Chundru wrote: [...] > > > > +                pcie@3,0 { > > > > +                    reg = <0x21800 0x0 0x0 0x0 0x0>; > > > > +                    #address-cells = <3>; > > > > +                    #size-cells = <2>; > > > > +                    device_type = "pci"; > > > > +                    ranges; > > > > +                    bus-range = <0x05 0xff>; > > > > + > > > > +                    qcom,tx-amplitude-millivolt = <10>; > > > > +                    pcie@0,0 { > > > > +                        reg = <0x50000 0x0 0x0 0x0 0x0>; > > > > +                        #address-cells = <3>; > > > > +                        #size-cells = <2>; > > > > +                        device_type = "pci"; > > > > > > There's a 2nd PCI-PCI bridge? > > This the embedded ethernet port which is as part of DSP3. > > > Hi Rob, > > Can you please check my response on your queries, if you need > any extra information, we can provide to sort this out. > I believe Rob was pointing the 'device_type' property which is not needed for PCI device nodes but only for nodes implementing PCI bus (like host bridge, PCI bridge). - Mani -- மணிவண்ணன் சதாசிவம்