From: Greg KH <gregkh@linuxfoundation.org>
To: Benjamin Larsson <benjamin.larsson@genexis.eu>
Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
ansuelsmth@gmail.com, lorenzo@kernel.org
Subject: Re: [PATCH v4 0/2] Airoha UART support
Date: Mon, 10 Feb 2025 07:14:15 +0100 [thread overview]
Message-ID: <2025021019-overtake-elk-e644@gregkh> (raw)
In-Reply-To: <20250209210241.2622309-1-benjamin.larsson@genexis.eu>
On Sun, Feb 09, 2025 at 10:02:39PM +0100, Benjamin Larsson wrote:
> The Airoha familty of SoCs have a UART hardware that is 16550-compatible
> with the exception of the baud rate settings.
>
> This patch implements code for calculating the baud rate for the Airoha
> UART and HSUART.
>
> Signed-off-by: Benjamin Larsson <benjamin.larsson@genexis.eu>
> ---
> Changes in v4:
> - Removed COMPILE_TEST from Kconfig
No, please don't do that.
> - Removed Kconfig option to build as module
No do that, you want your code as a module so that it can work in a
system that is built as a "generic system image" that does not force
your driver to be built into the main kernel image, wasting memory if
the hardware is not present.
thanks,
greg k-h
next prev parent reply other threads:[~2025-02-10 6:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-09 21:02 [PATCH v4 0/2] Airoha UART support Benjamin Larsson
2025-02-09 21:02 ` [PATCH 1/2] dt-bindings: serial: 8250: Add Airoha compatibles Benjamin Larsson
2025-02-09 21:02 ` [PATCH 2/2] serial: Airoha SoC UART and HSUART support Benjamin Larsson
2025-03-22 21:42 ` Andy Shevchenko
2025-03-25 14:19 ` Benjamin Larsson
2025-03-25 14:23 ` Andy Shevchenko
2025-02-10 6:14 ` Greg KH [this message]
2025-03-21 20:37 ` [PATCH v4 0/2] Airoha UART support Benjamin Larsson
2025-03-22 21:45 ` Andy Shevchenko
2025-03-25 14:45 ` Benjamin Larsson
2025-03-25 14:54 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025021019-overtake-elk-e644@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ansuelsmth@gmail.com \
--cc=benjamin.larsson@genexis.eu \
--cc=devicetree@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lorenzo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox