From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CED9426561B; Tue, 11 Feb 2025 19:55:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739303734; cv=none; b=SuumyQaE9Gf/HuSvKe9xtxZ330l60xjTIkiMc4xEkw9HO9z2cPlG+XnUNfLgyrCi81PUbIg8Z7Bsw3pkSJ7axD0lIMx1rLiuAYZwPl7Tz2OQbd/7tID7GrFFAuxu3j+dZjxXIHm5egZHdT+RcIgT2+m+CVJzFGKHc/Q/gBOXrHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739303734; c=relaxed/simple; bh=YGBeiYvY6N2eP4tvuDNUETpII967sPU2WGuLJGNSh2Y=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OhocRANJWfJ0sbNArXVohrHqPAi4Je2cEvXGvYIuTjPttz8Z/wx3TpV8WJwBBN+oHdtL2FPnNo7UC/m5/46n5mFREdeid4RWBeI7F3bpDn/pJJhvAc/3vSOHbqgd7uJPv5guQ4DEbawhfgfEAGBGjvUtRnvVPQKKJ8+NDDkXpp4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jnUrUTwd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jnUrUTwd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29610C4CEDD; Tue, 11 Feb 2025 19:55:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739303734; bh=YGBeiYvY6N2eP4tvuDNUETpII967sPU2WGuLJGNSh2Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jnUrUTwdUq0tunyCQMWU7mEttGn6BiLTOrCWBHEMkRmGTnauyS1HYPMYwcWYzhTcp LnnFJdQpgcLjt1xYZZDHELBDAr61kHyLwNvteUH42uMAlx1dNmZdvqGNvOTRNbRURp 2exb/6WJGwEeAslt5nuRoAhxlzF5veEd7K5MIH+w04cAQqgceoISNwyPL+RkB6fSfW jLPx2ba08oI8pNJHM/K441C6ZdLA7/d2Q6PQhRtr1zRhjvBmjvg7AW93sUOBMptYl6 8DXVVyipI8IJ0LCpGYROGVxnZS4495oDXOFUKFdzugWiYzBsACi6mBINVgE2WCi2+0 dpswlQxmHAXyA== Date: Tue, 11 Feb 2025 19:55:26 +0000 From: Jonathan Cameron To: Antoniu Miclaus Cc: , , , , , , Nuno Sa Subject: Re: [PATCH v12 6/9] iio: adc: adi-axi-adc: set data format Message-ID: <20250211195526.4e04c875@jic23-huawei> In-Reply-To: <20250208162209.2d43bae3@jic23-huawei> References: <20250207140918.7814-1-antoniu.miclaus@analog.com> <20250207140918.7814-7-antoniu.miclaus@analog.com> <20250208162209.2d43bae3@jic23-huawei> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.48; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 8 Feb 2025 16:22:09 +0000 Jonathan Cameron wrote: > On Fri, 7 Feb 2025 16:09:15 +0200 > Antoniu Miclaus wrote: > > > Add support for selecting the data format within the AXI ADC ip. > > > > Add separate complatible string for the custom AD485X IP and implement > > the necessary changes. > > > > Reviewed-by: Nuno Sa > > Signed-off-by: Antoniu Miclaus > > --- > > changes in v12: > > - add separate compatible for ad485x AXI IP core. > > drivers/iio/adc/adi-axi-adc.c | 99 +++++++++++++++++++++++++++++++---- > > 1 file changed, 90 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/iio/adc/adi-axi-adc.c b/drivers/iio/adc/adi-axi-adc.c > > index d2e1dc63775c..272d82c6e887 100644 > > --- a/drivers/iio/adc/adi-axi-adc.c > > +++ b/drivers/iio/adc/adi-axi-adc.c > > @@ -45,6 +45,12 @@ > > #define ADI_AXI_ADC_REG_CTRL 0x0044 > > #define ADI_AXI_ADC_CTRL_DDR_EDGESEL_MASK BIT(1) > > > > +#define ADI_AXI_ADC_REG_CNTRL_3 0x004c > > +#define AD485X_CNTRL_3_PACKET_FORMAT_MSK GENMASK(1, 0) > Sorry I missed this until now, but normal IIO thing is no wild cards > in naming (been bitten too often!) > > So I'd like to see these named after a specific part. Having realized this is named after the IP naming (which indeed uses the wild card), maybe we could prefix with AXI_ perhaps to make that association more obvious? > > > >