From: Stephan Gerhold <stephan.gerhold@linaro.org>
To: Vinod Koul <vkoul@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Yuvaraj Ranganathan <quic_yrangana@quicinc.com>,
Anusha Rao <quic_anusha@quicinc.com>,
Md Sadre Alam <quic_mdalam@quicinc.com>,
linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Luca Weiss <luca.weiss@fairphone.com>
Subject: [PATCH 2/8] arm64: dts: qcom: sm8450: Add missing properties for cryptobam
Date: Wed, 12 Feb 2025 18:03:48 +0100 [thread overview]
Message-ID: <20250212-bam-dma-fixes-v1-2-f560889e65d8@linaro.org> (raw)
In-Reply-To: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org>
num-channels and qcom,num-ees are required for BAM nodes without clock,
because the driver cannot ensure the hardware is powered on when trying to
obtain the information from the hardware registers. Specifying the node
without these properties is unsafe and has caused early boot crashes for
other SoCs before [1, 2].
Add the missing information from the hardware registers to ensure the
driver can probe successfully without causing crashes.
[1]: https://lore.kernel.org/r/CY01EKQVWE36.B9X5TDXAREPF@fairphone.com/
[2]: https://lore.kernel.org/r/20230626145959.646747-1-krzysztof.kozlowski@linaro.org/
Cc: stable@vger.kernel.org
Fixes: b92b0d2f7582 ("arm64: dts: qcom: sm8450: add crypto nodes")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 9c809fc5fa45a98ff5441a0b6809931588897243..419df72cd04b0c328756fdc484f4e46b6c325412 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -5283,6 +5283,8 @@ cryptobam: dma-controller@1dc4000 {
interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>;
#dma-cells = <1>;
qcom,ee = <0>;
+ qcom,num-ees = <4>;
+ num-channels = <16>;
qcom,controlled-remotely;
iommus = <&apps_smmu 0x584 0x11>,
<&apps_smmu 0x588 0x0>,
--
2.47.2
next prev parent reply other threads:[~2025-02-12 17:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 17:03 [PATCH 0/8] dmaengine: qcom: bam_dma: Fix DT error handling for num-channels/ees Stephan Gerhold
2025-02-12 17:03 ` [PATCH 1/8] arm64: dts: qcom: sm8350: Reenable crypto & cryptobam Stephan Gerhold
2025-02-12 17:03 ` Stephan Gerhold [this message]
2025-02-12 17:03 ` [PATCH 3/8] arm64: dts: qcom: sm8550: Add missing properties for cryptobam Stephan Gerhold
2025-08-11 7:50 ` Neil Armstrong
2025-02-12 17:03 ` [PATCH 4/8] arm64: dts: qcom: sm8650: " Stephan Gerhold
2025-08-11 7:51 ` Neil Armstrong
2025-02-12 17:03 ` [PATCH 5/8] arm64: dts: qcom: sa8775p: " Stephan Gerhold
2025-02-12 17:03 ` [PATCH 6/8] arm64: dts: qcom: ipq9574: " Stephan Gerhold
2025-02-12 17:03 ` [PATCH 7/8] dt-bindings: dma: qcom: bam-dma: Add missing required properties Stephan Gerhold
2025-02-12 21:01 ` Konrad Dybcio
2025-02-13 9:13 ` Stephan Gerhold
2025-02-13 14:00 ` Konrad Dybcio
2025-02-13 15:22 ` Stephan Gerhold
2025-02-13 16:06 ` Konrad Dybcio
2025-02-19 22:27 ` Rob Herring
2025-02-20 10:09 ` Stephan Gerhold
2025-02-12 17:03 ` [PATCH 8/8] dmaengine: qcom: bam_dma: Fix DT error handling for num-channels/ees Stephan Gerhold
2025-02-12 22:19 ` Konrad Dybcio
2025-03-14 20:01 ` (subset) [PATCH 0/8] " Bjorn Andersson
2025-07-28 9:36 ` Vinod Koul
2025-08-05 4:58 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212-bam-dma-fixes-v1-2-f560889e65d8@linaro.org \
--to=stephan.gerhold@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_anusha@quicinc.com \
--cc=quic_mdalam@quicinc.com \
--cc=quic_yrangana@quicinc.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).