From: Conor Dooley <conor@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Naresh Solanki <naresh.solanki@9elements.com>,
Guenter Roeck <linux@roeck-us.net>,
broonie@kernel.org, Jean Delvare <jdelvare@suse.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: ir38060: Move & update dt binding
Date: Wed, 12 Feb 2025 18:33:27 +0000 [thread overview]
Message-ID: <20250212-concierge-apricot-e5d3627afe93@spud> (raw)
In-Reply-To: <20250212175713.GA4032715-robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1868 bytes --]
On Wed, Feb 12, 2025 at 11:57:13AM -0600, Rob Herring wrote:
> On Fri, Feb 07, 2025 at 06:58:03PM +0530, Naresh Solanki wrote:
> > Move dt binding under hwmon/pmbus & align accordingly.
> >
> > Previously the DT binding was invalid & wouldn't work with pmbus driver.
> > Pmbus driver expects a regulator node & hence added the same.
>
> 2 out of 3 (schema, dts, driver) agree. Fix the driver.
>
> >
> > Fixes: 1d333cd641fb ("ARM: dts: aspeed: sbp1: IBM sbp1 BMC board")
> > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> > ---
> > Changes in V2:
> > 1. Update commit message
> > 2. Add Fixes tags
> > ---
> > .../hwmon/pmbus/infineon,ir38060.yaml | 61 +++++++++++++++++++
> > .../bindings/regulator/infineon,ir38060.yaml | 45 --------------
> > 2 files changed, 61 insertions(+), 45 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml
> > delete mode 100644 Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml
> > new file mode 100644
> > index 000000000000..e1f683846a54
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml
> > @@ -0,0 +1,61 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/hwmon/pmbus/infineon,ir38060.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Infineon Buck Regulators with PMBUS interfaces
> > +
> > +maintainers:
> > + - Not Me.
>
> Nothing new here, but WTF. Expect a meta-schema change to warn on this.
And it was fucking me that did it, that's the best/worst part about it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-02-12 18:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 13:28 [PATCH 1/2] dt-bindings: hwmon: ir38060: Move & update dt binding Naresh Solanki
2025-02-07 13:28 ` [PATCH 2/2] ARM: dts: aspeed: sbp1: Align regulator node with Infineon ir38060 Naresh Solanki
2025-02-07 15:21 ` [PATCH 1/2] dt-bindings: hwmon: ir38060: Move & update dt binding Rob Herring (Arm)
2025-02-12 17:57 ` Rob Herring
2025-02-12 18:33 ` Conor Dooley [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-02-04 18:03 Naresh Solanki
2025-02-04 19:22 ` Conor Dooley
2025-02-05 10:21 ` Naresh Solanki
2025-02-05 20:13 ` Conor Dooley
2025-02-06 15:53 ` Naresh Solanki
2025-02-06 18:09 ` Conor Dooley
2025-02-06 19:10 ` Naresh Solanki
2025-02-07 0:05 ` Conor Dooley
2025-02-12 10:43 ` Andrew Jeffery
2025-02-12 14:46 ` Guenter Roeck
2025-02-13 0:25 ` Andrew Jeffery
2025-02-12 18:56 ` Conor Dooley
2025-02-13 0:33 ` Andrew Jeffery
2025-02-04 23:34 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212-concierge-apricot-e5d3627afe93@spud \
--to=conor@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=naresh.solanki@9elements.com \
--cc=patrick.rudolph@9elements.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox