Re: [PATCH 1/2] dt-bindings: hwmon: ir38060: Move & update dt binding

Rob Herring
2025-02-12T17:57:14Z

On Fri, Feb 07, 2025 at 06:58:03PM +0530, Naresh Solanki wrote:
> Move dt binding under hwmon/pmbus & align accordingly.
>
> Previously the DT binding was invalid & wouldn't work with pmbus driver.
> Pmbus driver expects a regulator node & hence added the same.

2 out of 3 (schema, dts, driver) agree. Fix the driver.

>
> Fixes: 1d333cd641fb ("ARM: dts: aspeed: sbp1: IBM sbp1 BMC board")
> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> ---
> Changes in V2:
> 1. Update commit message
> 2. Add Fixes tags
> ---
> .../hwmon/pmbus/infineon,ir38060.yaml | 61 +++++++++++++++++++
> .../bindings/regulator/infineon,ir38060.yaml | 45 --------------
> 2 files changed, 61 insertions(+), 45 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml
> delete mode 100644 Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml
> new file mode 100644
> index 000000000000..e1f683846a54
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/pmbus/infineon,ir38060.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Infineon Buck Regulators with PMBUS interfaces
> +
> +maintainers:
> + - Not Me.

Nothing new here, but WTF. Expect a meta-schema change to warn on this.

Rob