[PATCH v2 0/3] Add PM8937 PWM and display backlight for Redmi 5A

[PATCH v2 0/3] Add PM8937 PWM and display backlight for Redmi 5A

[Barnabás Czémán]

This patch series add pwm node for pm8937 and enables
pwm backlight for Redmi 5A.

Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
---
Changes in v2:
- Add qcom,pm8937-pwm fallback compatible for qcom,pm8916-pwm.
- Link to v1: https://lore.kernel.org/r/20250212-pm8937-pwm-v1-0-a900a779b4ad@mainlining.org

---
Barnabás Czémán (2):
      dt-bindings: leds: qcom-lpg: Document PM8937 PWM compatible
      arm64: dts: qcom: msm8917-xiaomi-riva: Add display backlight

Daniil Titov (1):
      arm64: dts: qcom: pm8937: Add LPG PWM driver

 .../devicetree/bindings/leds/leds-qcom-lpg.yaml    |  4 ++++
 arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts   | 25 ++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/pm8937.dtsi               |  8 +++++++
 3 files changed, 37 insertions(+)
---
base-commit: c674aa7c289e51659e40dda0f954886ef7f80042
change-id: 20250212-pm8937-pwm-0f3bae4cd207

Best regards,
-- 
Barnabás Czémán <barnabas.czeman@mainlining.org>

[PATCH v2 1/3] dt-bindings: leds: qcom-lpg: Document PM8937 PWM compatible

[Barnabás Czémán]

The PM8937 PWM modules are compatible with the PM8916 PWM modules,
document the PM8937 PWM compatible as fallback for the PM8916 PWM.

Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
---
 Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
index 8b82c45d1a48be6ff63193aae9d67625a943a72b..841a0229c472a4764426d25d9dbb900adc20fc11 100644
--- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
@@ -39,6 +39,10 @@ properties:
           - enum:
               - qcom,pm8550-pwm
           - const: qcom,pm8350c-pwm
+      - items:
+          - enum:
+              - qcom,pm8937-pwm
+          - const: qcom,pm8916-pwm
 
   "#pwm-cells":
     const: 2

-- 
2.48.1

Re: [PATCH v2 1/3] dt-bindings: leds: qcom-lpg: Document PM8937 PWM compatible

[Krzysztof Kozlowski]

On Thu, Feb 13, 2025 at 08:54:47PM +0100, Barnabás Czémán wrote:
> The PM8937 PWM modules are compatible with the PM8916 PWM modules,
> document the PM8937 PWM compatible as fallback for the PM8916 PWM.
> 
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> ---
>  Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: (subset) [PATCH v2 1/3] dt-bindings: leds: qcom-lpg: Document PM8937 PWM compatible

[Lee Jones]

On Thu, 13 Feb 2025 20:54:47 +0100, Barnabás Czémán wrote:
> The PM8937 PWM modules are compatible with the PM8916 PWM modules,
> document the PM8937 PWM compatible as fallback for the PM8916 PWM.
> 
> 

Applied, thanks!

[1/3] dt-bindings: leds: qcom-lpg: Document PM8937 PWM compatible
      commit: 9ec336ba05f6786814696deef637ab2b9f6d0f10

--
Lee Jones [李琼斯]

[PATCH v2 2/3] arm64: dts: qcom: pm8937: Add LPG PWM driver

[Barnabás Czémán]

From: Daniil Titov <daniilt971@gmail.com>

Add PWM/LPG node to the PM8937 dtsi so devices
which use this block can enable them.

Signed-off-by: Daniil Titov <daniilt971@gmail.com>
Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
---
 arch/arm64/boot/dts/qcom/pm8937.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pm8937.dtsi b/arch/arm64/boot/dts/qcom/pm8937.dtsi
index 42b3575b36ff4d37df11ccb5ed68e965e3716300..77809c3534a744f1aa4d8941736e590b9cdb28c5 100644
--- a/arch/arm64/boot/dts/qcom/pm8937.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8937.dtsi
@@ -143,6 +143,14 @@ pmic@1 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
+		pm8937_pwm: pwm {
+			compatible = "qcom,pm8937-pwm", "qcom,pm8916-pwm";
+
+			#pwm-cells = <2>;
+
+			status = "disabled";
+		};
+
 		pm8937_spmi_regulators: regulators {
 			compatible = "qcom,pm8937-regulators";
 		};

-- 
2.48.1

Re: [PATCH v2 2/3] arm64: dts: qcom: pm8937: Add LPG PWM driver

[Konrad Dybcio]

On 13.02.2025 8:54 PM, Barnabás Czémán wrote:
> From: Daniil Titov <daniilt971@gmail.com>
> 
> Add PWM/LPG node to the PM8937 dtsi so devices
> which use this block can enable them.
> 
> Signed-off-by: Daniil Titov <daniilt971@gmail.com>
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

[PATCH v2 3/3] arm64: dts: qcom: msm8917-xiaomi-riva: Add display backlight

[Barnabás Czémán]

Redmi 5A display uses pwm backlight, add support for it.

Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
---
 arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts | 25 ++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
index f1d22535fedd94467ba3f0a88b2110ce5360e7e1..8808306c989f54116052667887f9bf36b63c4c64 100644
--- a/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
+++ b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
@@ -20,6 +20,14 @@ / {
 	qcom,msm-id = <QCOM_ID_MSM8917 0>;
 	qcom,board-id = <0x1000b 2>, <0x2000b 2>;
 
+	pwm_backlight: backlight {
+		compatible = "pwm-backlight";
+		pwms = <&pm8937_pwm 0 100000>;
+		brightness-levels = <0 255>;
+		num-interpolated-steps = <255>;
+		default-brightness-level = <128>;
+	};
+
 	battery: battery {
 		compatible = "simple-battery";
 		charge-full-design-microamp-hours = <3000000>;
@@ -131,6 +139,23 @@ bq25601@6b{
 	};
 };
 
+&pm8937_gpios {
+	pwm_enable_default: pwm-enable-default-state {
+		pins = "gpio8";
+		function = "dtest2";
+		output-low;
+		bias-disable;
+		qcom,drive-strength = <2>;
+	};
+};
+
+&pm8937_pwm {
+	pinctrl-0 = <&pwm_enable_default>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
+
 &pm8937_resin {
 	linux,code = <KEY_VOLUMEDOWN>;
 

-- 
2.48.1

Re: [PATCH v2 3/3] arm64: dts: qcom: msm8917-xiaomi-riva: Add display backlight

[Konrad Dybcio]

On 13.02.2025 8:54 PM, Barnabás Czémán wrote:
> Redmi 5A display uses pwm backlight, add support for it.
> 
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: (subset) [PATCH v2 0/3] Add PM8937 PWM and display backlight for Redmi 5A

[Bjorn Andersson]

On Thu, 13 Feb 2025 20:54:46 +0100, Barnabás Czémán wrote:
> This patch series add pwm node for pm8937 and enables
> pwm backlight for Redmi 5A.
> 
> 

Applied, thanks!

[2/3] arm64: dts: qcom: pm8937: Add LPG PWM driver
      commit: b18c1aa6404303888ab924f149135835d223f4e8
[3/3] arm64: dts: qcom: msm8917-xiaomi-riva: Add display backlight
      commit: 5b74065e6c2482507435cdf7c4d0aab1830b9676

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>