Re: [PATCH v7 4/6] dt-bindings: iio: Add adis16550 bindings

Krzysztof Kozlowski
2025-02-12T07:00:07Z

On Tue, Feb 11, 2025 at 07:57:01PM +0200, Robert Budai wrote:
> + spi-max-frequency:
> + maximum: 15000000
> +
> + vdd-supply: true
> +
> + interrupts:
> + maxItems: 1
> +
> + reset-gpios:
> + description:
> + Must be the device tree identifier of the RESET pin. If specified,

Few nits here because you did not implement previous feedback:

s/Must be the device tree identifier of//
It cannot be anything else, right? So:

Active low RESET pin.

Second sentence is implementation detail, what if my krzkOS does not do
it in probe? Is binding incorrect in such case? No, so drop.

> + it will be asserted during driver probe. As the line is active low,
> + it should be marked GPIO_ACTIVE_LOW.

Line should be marked depending on the board layout. If there is
inverter, it won't be GPIO_ACTIVE_LOW. Just say this is active low.

> + maxItems: 1
> +
> + clocks:
> + description: If not provided, then the internal clock is used.
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - spi-cpha
> + - spi-cpol
> + - spi-max-frequency
> + - vdd-supply
> +
> +allOf:
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#

And now we get back to previous feedback which was not implemented.
Please share the filename which follows such style/syntax without blank
lines, so I can fix it and people will not take it as an example.

> +additionalProperties: false

Here as well.

> +examples:

Best regards,
Krzysztof