Re: [PATCH v7 3/6] iio: imu: adis: Add DIAG_STAT register

kernel test robot
2025-02-13T04:27:33Z

Hi Robert,

kernel test robot noticed the following build errors:

[auto build test ERROR on jic23-iio/togreg]
[also build test ERROR on linus/master v6.14-rc2 next-20250212]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Robert-Budai/iio-imu-adis-Add-custom-ops-struct/20250212-040235
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link: https://lore.kernel.org/r/20250211175706.276987-4-robert.budai%40analog.com
patch subject: [PATCH v7 3/6] iio: imu: adis: Add DIAG_STAT register
config: sh-randconfig-001-20250213 (https://download.01.org/0day-ci/archive/20250213/202502131226.6CIBwO2c-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250213/202502131226.6CIBwO2c-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502131226.6CIBwO2c-lkp@intel.com/

All errors (new ones prefixed by >>):

drivers/iio/imu/adis.c: In function '__adis_check_status':
>> drivers/iio/imu/adis.c:319:42: error: passing argument 3 of '__adis_read_reg_16' makes pointer from integer without a cast [-Wint-conversion]
319 | status_16);
| ^~~~~~~~~
| |
| u16 {aka short unsigned int}
In file included from drivers/iio/imu/adis.c:19:
include/linux/iio/imu/adis.h:225:43: note: expected 'u16 *' {aka 'short unsigned int *'} but argument is of type 'u16' {aka 'short unsigned int'}
225 | u16 *val)
| ~~~~~^~~

vim +/__adis_read_reg_16 +319 drivers/iio/imu/adis.c

298
299 /**
300 * __adis_check_status() - Check the device for error conditions (unlocked)
301 * @adis: The adis device
302 *
303 * Returns 0 on success, a negative error code otherwise
304 */
305 int __adis_check_status(struct adis *adis)
306 {
307 unsigned int status;
308 int diag_stat_bits;
309 u16 status_16;
310 int ret;
311 int i;
312
313 if (adis->data->diag_stat_size)
314 ret = adis->ops->read(adis, adis->data->diag_stat_reg, &status,
315 adis->data->diag_stat_size);
316 else
317 {
318 ret = __adis_read_reg_16(adis, adis->data->diag_stat_reg,
> 319 status_16);
320 status = status_16;
321 }
322 if (ret)
323 return ret;
324
325 status &= adis->data->status_error_mask;
326
327 if (status == 0)
328 return 0;
329
330 diag_stat_bits = BITS_PER_BYTE * (adis->data->diag_stat_size ?
331 adis->data->diag_stat_size : 2);
332
333 for (i = 0; i < diag_stat_bits; ++i) {
334 if (status & BIT(i)) {
335 dev_err(&adis->spi->dev, "%s.\n",
336 adis->data->status_error_msgs[i]);
337 }
338 }
339
340 return -EIO;
341 }
342 EXPORT_SYMBOL_NS_GPL(__adis_check_status, "IIO_ADISLIB");
343

--
0-DAY CI Kernel Test Service