From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krishna Manikandan <quic_mkrishn@quicinc.com>,
Jonathan Marek <jonathan@marek.ca>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Neil Armstrong <neil.armstrong@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Srini Kandagatla <srinivas.kandagatla@linaro.org>
Subject: [PATCH v2 14/16] drm/msm/dpu: Add missing "fetch" name to set_active_pipes()
Date: Mon, 17 Feb 2025 17:41:35 +0100 [thread overview]
Message-ID: <20250217-b4-sm8750-display-v2-14-d201dcdda6a4@linaro.org> (raw)
In-Reply-To: <20250217-b4-sm8750-display-v2-0-d201dcdda6a4@linaro.org>
The set_active_pipes() callback configures CTL_FETCH_PIPE_ACTIVE and
newer DPU v12.0 comes with CTL_PIPE_ACTIVE, thus rename it to
set_active_fetch_pipes() to better match the purpose.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes in v2:
1. New patch
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 12 ++++++------
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 6 +++---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 2 +-
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
index 7191b1a6d41b3a96f956d199398f12b2923e8c82..7de79696a21e58a4c640f00265610ccce8b5d253 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
@@ -445,9 +445,9 @@ static void _dpu_crtc_blend_setup_mixer(struct drm_crtc *crtc,
uint32_t lm_idx;
bool bg_alpha_enable = false;
- DECLARE_BITMAP(fetch_active, SSPP_MAX);
+ DECLARE_BITMAP(active_fetch, SSPP_MAX);
- memset(fetch_active, 0, sizeof(fetch_active));
+ memset(active_fetch, 0, sizeof(active_fetch));
drm_atomic_crtc_for_each_plane(plane, crtc) {
state = plane->state;
if (!state)
@@ -464,7 +464,7 @@ static void _dpu_crtc_blend_setup_mixer(struct drm_crtc *crtc,
if (pstate->stage == DPU_STAGE_BASE && format->alpha_enable)
bg_alpha_enable = true;
- set_bit(pstate->pipe.sspp->idx, fetch_active);
+ set_bit(pstate->pipe.sspp->idx, active_fetch);
_dpu_crtc_blend_setup_pipe(crtc, plane,
mixer, cstate->num_mixers,
pstate->stage,
@@ -472,7 +472,7 @@ static void _dpu_crtc_blend_setup_mixer(struct drm_crtc *crtc,
&pstate->pipe, 0, stage_cfg);
if (pstate->r_pipe.sspp) {
- set_bit(pstate->r_pipe.sspp->idx, fetch_active);
+ set_bit(pstate->r_pipe.sspp->idx, active_fetch);
_dpu_crtc_blend_setup_pipe(crtc, plane,
mixer, cstate->num_mixers,
pstate->stage,
@@ -492,8 +492,8 @@ static void _dpu_crtc_blend_setup_mixer(struct drm_crtc *crtc,
}
}
- if (ctl->ops.set_active_pipes)
- ctl->ops.set_active_pipes(ctl, fetch_active);
+ if (ctl->ops.set_active_fetch_pipes)
+ ctl->ops.set_active_fetch_pipes(ctl, active_fetch);
_dpu_crtc_program_lm_output_roi(crtc);
}
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c
index 9d4866509e97c262006e15cf3e02a2f1ca851784..2e1e22589f730d1a60c3cbf6ad6b6aeaea38c6fb 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c
@@ -675,8 +675,8 @@ static void dpu_hw_ctl_reset_intf_cfg_v1(struct dpu_hw_ctl *ctx,
}
}
-static void dpu_hw_ctl_set_fetch_pipe_active(struct dpu_hw_ctl *ctx,
- unsigned long *fetch_active)
+static void dpu_hw_ctl_set_active_fetch_pipes(struct dpu_hw_ctl *ctx,
+ unsigned long *fetch_active)
{
int i;
u32 val = 0;
@@ -764,7 +764,7 @@ struct dpu_hw_ctl *dpu_hw_ctl_init(struct drm_device *dev,
c->ops.update_pending_flush_dspp = dpu_hw_ctl_update_pending_flush_dspp;
if (mdss_ver->core_major_ver >= 7)
- c->ops.set_active_pipes = dpu_hw_ctl_set_fetch_pipe_active;
+ c->ops.set_active_fetch_pipes = dpu_hw_ctl_set_active_fetch_pipes;
c->idx = cfg->id;
c->mixer_count = mixer_count;
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h
index f04ae0b1d986fa8f73e5bf96babfca3b4f3a0bf5..b8bd5b22c5f8dadd01c16c352efef4063f2614a6 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h
@@ -243,7 +243,7 @@ struct dpu_hw_ctl_ops {
void (*setup_blendstage)(struct dpu_hw_ctl *ctx,
enum dpu_lm lm, struct dpu_hw_stage_cfg *cfg);
- void (*set_active_pipes)(struct dpu_hw_ctl *ctx,
+ void (*set_active_fetch_pipes)(struct dpu_hw_ctl *ctx,
unsigned long *fetch_active);
};
--
2.43.0
next prev parent reply other threads:[~2025-02-17 16:42 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 16:41 [PATCH v2 00/16] drm/msm: Add support for SM8750 Krzysztof Kozlowski
2025-02-17 16:41 ` [PATCH v2 01/16] dt-bindings: display/msm: dsi-controller-main: Combine if:then: entries Krzysztof Kozlowski
2025-02-19 23:19 ` Rob Herring (Arm)
2025-02-17 16:41 ` [PATCH v2 02/16] dt-bindings: display/msm: dsi-controller-main: Add missing minItems Krzysztof Kozlowski
2025-02-19 23:20 ` Rob Herring (Arm)
2025-02-17 16:41 ` [PATCH v2 03/16] dt-bindings: display/msm: dsi-phy-7nm: Add SM8750 Krzysztof Kozlowski
2025-02-19 23:20 ` Rob Herring (Arm)
2025-02-17 16:41 ` [PATCH v2 04/16] dt-bindings: display/msm: dsi-controller-main: " Krzysztof Kozlowski
2025-02-19 23:21 ` Rob Herring (Arm)
2025-02-17 16:41 ` [PATCH v2 05/16] dt-bindings: display/msm: dp-controller: " Krzysztof Kozlowski
2025-02-17 18:58 ` Dmitry Baryshkov
2025-02-19 17:02 ` Krzysztof Kozlowski
2025-02-19 17:08 ` Dmitry Baryshkov
2025-02-24 18:59 ` Abhinav Kumar
2025-02-25 3:14 ` Dmitry Baryshkov
2025-03-03 21:23 ` Abhinav Kumar
2025-03-04 0:06 ` Dmitry Baryshkov
2025-02-17 16:41 ` [PATCH v2 06/16] dt-bindings: display/msm: qcom,sm8650-dpu: " Krzysztof Kozlowski
2025-02-19 23:23 ` Rob Herring (Arm)
2025-02-17 16:41 ` [PATCH v2 07/16] dt-bindings: display/msm: qcom,sm8750-mdss: " Krzysztof Kozlowski
2025-02-19 23:27 ` Rob Herring
2025-02-17 16:41 ` [PATCH v2 08/16] drm/msm/dpu: Drop useless comments Krzysztof Kozlowski
2025-02-17 19:22 ` Dmitry Baryshkov
2025-02-19 21:19 ` Jessica Zhang
2025-02-17 16:41 ` [PATCH v2 09/16] drm/msm/dpu: Add LM_7, DSC_[67], PP_[67] and MERGE_3D_5 Krzysztof Kozlowski
2025-02-17 19:00 ` Dmitry Baryshkov
2025-02-19 21:22 ` Jessica Zhang
2025-02-19 21:24 ` Jessica Zhang
2025-02-17 16:41 ` [PATCH v2 10/16] drm/msm/dpu: Add handling of LM_6 and LM_7 bits in pending flush mask Krzysztof Kozlowski
2025-02-17 19:01 ` Dmitry Baryshkov
2025-02-19 21:28 ` Jessica Zhang
2025-02-17 16:41 ` [PATCH v2 11/16] drm/msm/dsi/phy: Add support for SM8750 Krzysztof Kozlowski
2025-02-17 19:03 ` Dmitry Baryshkov
2025-02-20 0:50 ` Jessica Zhang
2025-02-21 10:41 ` Krzysztof Kozlowski
2025-02-21 10:43 ` Krzysztof Kozlowski
2025-02-17 16:41 ` [PATCH v2 12/16] drm/msm/dsi: " Krzysztof Kozlowski
2025-02-17 19:05 ` Dmitry Baryshkov
2025-02-21 11:14 ` Krzysztof Kozlowski
2025-02-21 11:14 ` Krzysztof Kozlowski
2025-02-17 16:41 ` [PATCH v2 13/16] drm/msm/dpu: " Krzysztof Kozlowski
2025-02-17 19:07 ` Dmitry Baryshkov
2025-02-17 16:41 ` Krzysztof Kozlowski [this message]
2025-02-17 19:08 ` [PATCH v2 14/16] drm/msm/dpu: Add missing "fetch" name to set_active_pipes() Dmitry Baryshkov
2025-02-20 22:52 ` Jessica Zhang
2025-02-17 16:41 ` [PATCH v2 15/16] drm/msm/dpu: Implement new v12.0 DPU differences Krzysztof Kozlowski
2025-02-17 19:18 ` Dmitry Baryshkov
2025-02-19 17:04 ` Krzysztof Kozlowski
2025-02-19 17:24 ` Dmitry Baryshkov
2025-02-21 12:36 ` Krzysztof Kozlowski
2025-02-21 13:33 ` Dmitry Baryshkov
2025-02-17 16:41 ` [PATCH v2 16/16] drm/msm/mdss: Add support for SM8750 Krzysztof Kozlowski
2025-02-19 21:17 ` [PATCH v2 00/16] drm/msm: " Jessica Zhang
2025-02-19 22:02 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250217-b4-sm8750-display-v2-14-d201dcdda6a4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_mkrishn@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=srinivas.kandagatla@linaro.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).