Re: [PATCH 1/6] dt-bindings: usb: chipidea: add compatible for i.MX95 platform

[Xu Yang <xu.yang_2@nxp.com>]

On Wed, Feb 19, 2025 at 12:58:10PM -0500, Frank Li wrote:
> On Wed, Feb 19, 2025 at 05:30:59PM +0800, Xu Yang wrote:
> > The i.MX95 USB2.0 controller is basically compatible with i.MX7d, except
> > it needs a second interrupt for wakeup handling. This will add compatible
> > for i.MX95 platform and restriciton on interrupt property. Besides, this
>                           ^ typo,
> 
> run check-patch --code-spell
> 
> > will also add iommus property.
> 
> dt-bindings: usb: Add i.MX95 compatible string 'fsl,imx95-usb'
> 
> The i.MX95 USB2.0 controller is mostly compatible with i.MX7D, except it
> requires a second interrupt for wakeup handling. Add the compatible string
> for the i.MX95 platform, add the iommus property, and enforce the
> interrupt property restriction. Keep the same restriction for existing
> compatible strings.

Okay.

> 
> Fix below nit.
> 
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> 
> Frank
> 
> 
> >

[...]

> > +    description:
> > +      One interrupt for USB controller and wakeup interrupt combined
> > +      case or two interrupts for individual USB controller and wakeup
> 
> Needn't descrition here. Items: descrption already provide enough
> informaiton.  Or you can change first
> 
> description: USB controller interrupt Or combine USB controller and wakeup
> interrupts.

Okay. will do.

Thanks,
Xu Yang