Re: [PATCH 2/2] PCI: sophgo-dwc: Add Sophgo SG2044 PCIe driver

Bjorn Helgaas
2025-02-24T19:47:26Z

On Sat, Feb 22, 2025 at 08:43:46AM +0800, Inochi Amaoto wrote:
> On Fri, Feb 21, 2025 at 05:49:58PM -0600, Bjorn Helgaas wrote:
> > On Fri, Feb 21, 2025 at 09:37:56AM +0800, Inochi Amaoto wrote:
> > > Add support for DesignWare-based PCIe controller in SG2044 SoC.
> >
> > > @@ -341,6 +341,16 @@ config PCIE_ROCKCHIP_DW_EP
> > > Enables support for the DesignWare PCIe controller in the
> > > Rockchip SoC (except RK3399) to work in endpoint mode.
> > >
> > > +config PCIE_SOPHGO_DW
> > > + bool "SOPHGO DesignWare PCIe controller"
> >
> > What's the canonical styling of "SOPHGO"? I see "Sophgo" in the
> > subject line and in Chen Wang's SG2042 series. Pick the official
> > styling and use it consistently.
>
> This is my mistake. It should be "Sophgo", I will change it.
>
> > Reorder this so the menuconfig menu items remain alphabetically
> > sorted.
>
> I think this order is applied to the entry title in menuconfig,
> and is not the config key? If so, I will change it.

It's the title shown by menuconfig, i.e., "SOPHGO DesignWare PCIe
controller" here.