[PATCH 1/2] dt-bindings: vendor-prefixes: Add prefix for Liebherr-Werk Ehingen GmbH

[PATCH 1/2] dt-bindings: vendor-prefixes: Add prefix for Liebherr-Werk Ehingen GmbH

[Lukasz Majewski]

This entry adds vendor prefix for Liebherr-Werk Ehingen GmbH.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 5079ca6ce1d1..20ea550ac328 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -882,6 +882,8 @@ patternProperties:
     description: Shenzhen Lunzn Technology Co., Ltd.
   "^luxul,.*":
     description: Lagrand | AV
+  "^lwe,.*":
+    description: Liebherr-Werk Ehingen GmbH
   "^lwn,.*":
     description: Liebherr-Werk Nenzing GmbH
   "^lxa,.*":
-- 
2.39.5

[PATCH 2/2] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

[Lukasz Majewski]

The measurement device on Liebherr's (LWE) boards is used to monitor
the overall state of the device. It does have SPI interface to
communicate with Linux host via spidev driver. Document the SPI DT
binding as trivial SPI device.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index fadbd3c041c8..5d736a9792c2 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -161,6 +161,8 @@ properties:
           - jedec,spd5118
             # Linear Technology LTC2488
           - lineartechnology,ltc2488
+            # Liebherr on-board measurement SPI device
+          - lwe,btt
             # 5 Bit Programmable, Pulse-Width Modulator
           - maxim,ds1050
             # 10 kOhm digital potentiometer with I2C interface
-- 
2.39.5

Re: [PATCH 1/2] dt-bindings: vendor-prefixes: Add prefix for Liebherr-Werk Ehingen GmbH

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 963 bytes --]

On Fri, Feb 21, 2025 at 04:54:17PM +0100, Lukasz Majewski wrote:
> This entry adds vendor prefix for Liebherr-Werk Ehingen GmbH.
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 5079ca6ce1d1..20ea550ac328 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -882,6 +882,8 @@ patternProperties:
>      description: Shenzhen Lunzn Technology Co., Ltd.
>    "^luxul,.*":
>      description: Lagrand | AV
> +  "^lwe,.*":
> +    description: Liebherr-Werk Ehingen GmbH
>    "^lwn,.*":
>      description: Liebherr-Werk Nenzing GmbH

What's the difference between these two?

>    "^lxa,.*":
> -- 
> 2.39.5
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 2/2] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]

On Fri, Feb 21, 2025 at 04:54:18PM +0100, Lukasz Majewski wrote:
> The measurement device on Liebherr's (LWE) boards is used to monitor
> the overall state of the device. It does have SPI interface to
> communicate with Linux host via spidev driver. Document the SPI DT
> binding as trivial SPI device.
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index fadbd3c041c8..5d736a9792c2 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -161,6 +161,8 @@ properties:
>            - jedec,spd5118
>              # Linear Technology LTC2488
>            - lineartechnology,ltc2488
> +            # Liebherr on-board measurement SPI device
> +          - lwe,btt

How does "btt" translate to what the device actually is? Seems kinda
random!
Also, where is patch 3, adding the lwe,btt to the spidev driver so that
it will probe?

Cheers,
Conor.

>              # 5 Bit Programmable, Pulse-Width Modulator
>            - maxim,ds1050
>              # 10 kOhm digital potentiometer with I2C interface
> -- 
> 2.39.5
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 1/2] dt-bindings: vendor-prefixes: Add prefix for Liebherr-Werk Ehingen GmbH

[Lukasz Majewski]

[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]

Hi Conor,

> On Fri, Feb 21, 2025 at 04:54:17PM +0100, Lukasz Majewski wrote:
> > This entry adds vendor prefix for Liebherr-Werk Ehingen GmbH.
> > 
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > ---
> >  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > b/Documentation/devicetree/bindings/vendor-prefixes.yaml index
> > 5079ca6ce1d1..20ea550ac328 100644 ---
> > a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++
> > b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -882,6
> > +882,8 @@ patternProperties: description: Shenzhen Lunzn Technology
> > Co., Ltd. "^luxul,.*":
> >      description: Lagrand | AV
> > +  "^lwe,.*":
> > +    description: Liebherr-Werk Ehingen GmbH
> >    "^lwn,.*":
> >      description: Liebherr-Werk Nenzing GmbH  
> 
> What's the difference between these two?

They are in fact targetting different types of industrial markets.
Hence, their devices and way of using SPI devs are totally different.

> 
> >    "^lxa,.*":
> > -- 
> > 2.39.5
> >   




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 2/2] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

[Lukasz Majewski]

[-- Attachment #1: Type: text/plain, Size: 1958 bytes --]

Hi Conor,

> On Fri, Feb 21, 2025 at 04:54:18PM +0100, Lukasz Majewski wrote:
> > The measurement device on Liebherr's (LWE) boards is used to monitor
> > the overall state of the device. It does have SPI interface to
> > communicate with Linux host via spidev driver. Document the SPI DT
> > binding as trivial SPI device.
> > 
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > ---
> >  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml
> > b/Documentation/devicetree/bindings/trivial-devices.yaml index
> > fadbd3c041c8..5d736a9792c2 100644 ---
> > a/Documentation/devicetree/bindings/trivial-devices.yaml +++
> > b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -161,6
> > +161,8 @@ properties:
> >            - jedec,spd5118
> >              # Linear Technology LTC2488
> >            - lineartechnology,ltc2488
> > +            # Liebherr on-board measurement SPI device
> > +          - lwe,btt  
> 
> How does "btt" translate to what the device actually is? Seems kinda
> random!

Btt is a family of devices (bttc, btt3, xea) - to control heavy duty
machines.

That was the original codename - conceived probably 30+ years ago.

> Also, where is patch 3, adding the lwe,btt to the spidev driver so
> that it will probe?

I've posted it to Mark Brown (and also linux-spi ML) for review.

> 
> Cheers,
> Conor.
> 
> >              # 5 Bit Programmable, Pulse-Width Modulator
> >            - maxim,ds1050
> >              # 10 kOhm digital potentiometer with I2C interface
> > -- 
> > 2.39.5
> >   




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/2] dt-bindings: vendor-prefixes: Add prefix for Liebherr-Werk Ehingen GmbH

[Krzysztof Kozlowski]

On 21/02/2025 21:54, Lukasz Majewski wrote:
> Hi Conor,
> 
>> On Fri, Feb 21, 2025 at 04:54:17PM +0100, Lukasz Majewski wrote:
>>> This entry adds vendor prefix for Liebherr-Werk Ehingen GmbH.
>>>
>>> Signed-off-by: Lukasz Majewski <lukma@denx.de>
>>> ---
>>>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml
>>> b/Documentation/devicetree/bindings/vendor-prefixes.yaml index
>>> 5079ca6ce1d1..20ea550ac328 100644 ---
>>> a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++
>>> b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -882,6
>>> +882,8 @@ patternProperties: description: Shenzhen Lunzn Technology
>>> Co., Ltd. "^luxul,.*":
>>>      description: Lagrand | AV
>>> +  "^lwe,.*":
>>> +    description: Liebherr-Werk Ehingen GmbH
>>>    "^lwn,.*":
>>>      description: Liebherr-Werk Nenzing GmbH  
>>
>> What's the difference between these two?
> 
> They are in fact targetting different types of industrial markets.
> Hence, their devices and way of using SPI devs are totally different.

We don't take multiple samsung or lg vendor prefixes, even though they
have multiple separate companies, so we shouldn't take these either.
Both use the same domain (at least first search result pointed me there)
- liebherr - so that's the same entry.

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: vendor-prefixes: Add prefix for Liebherr-Werk Ehingen GmbH

[Lukasz Majewski]

[-- Attachment #1: Type: text/plain, Size: 1938 bytes --]

Hi Krzysztof,

> On 21/02/2025 21:54, Lukasz Majewski wrote:
> > Hi Conor,
> >   
> >> On Fri, Feb 21, 2025 at 04:54:17PM +0100, Lukasz Majewski wrote:  
> >>> This entry adds vendor prefix for Liebherr-Werk Ehingen GmbH.
> >>>
> >>> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> >>> ---
> >>>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> >>>  1 file changed, 2 insertions(+)
> >>>
> >>> diff --git
> >>> a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> >>> b/Documentation/devicetree/bindings/vendor-prefixes.yaml index
> >>> 5079ca6ce1d1..20ea550ac328 100644 ---
> >>> a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++
> >>> b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@
> >>> -882,6 +882,8 @@ patternProperties: description: Shenzhen Lunzn
> >>> Technology Co., Ltd. "^luxul,.*": description: Lagrand | AV
> >>> +  "^lwe,.*":
> >>> +    description: Liebherr-Werk Ehingen GmbH
> >>>    "^lwn,.*":
> >>>      description: Liebherr-Werk Nenzing GmbH    
> >>
> >> What's the difference between these two?  
> > 
> > They are in fact targetting different types of industrial markets.
> > Hence, their devices and way of using SPI devs are totally
> > different.  
> 
> We don't take multiple samsung or lg vendor prefixes, even though they
> have multiple separate companies, so we shouldn't take these either.
> Both use the same domain (at least first search result pointed me
> there)
> - liebherr - so that's the same entry.
> 

Ok, so then I will just add "lwn.btt" in the other patches and drop
this particular one.

Thanks for input.

> Best regards,
> Krzysztof




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 2/2] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2325 bytes --]

On Fri, Feb 21, 2025 at 09:56:59PM +0100, Lukasz Majewski wrote:
> Hi Conor,
> 
> > On Fri, Feb 21, 2025 at 04:54:18PM +0100, Lukasz Majewski wrote:
> > > The measurement device on Liebherr's (LWE) boards is used to monitor
> > > the overall state of the device. It does have SPI interface to
> > > communicate with Linux host via spidev driver. Document the SPI DT
> > > binding as trivial SPI device.
> > > 
> > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > ---
> > >  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml
> > > b/Documentation/devicetree/bindings/trivial-devices.yaml index
> > > fadbd3c041c8..5d736a9792c2 100644 ---
> > > a/Documentation/devicetree/bindings/trivial-devices.yaml +++
> > > b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -161,6
> > > +161,8 @@ properties:
> > >            - jedec,spd5118
> > >              # Linear Technology LTC2488
> > >            - lineartechnology,ltc2488
> > > +            # Liebherr on-board measurement SPI device
> > > +          - lwe,btt  
                          ^^
Are these two trailing spaces an artefact of the mail?

> > 
> > How does "btt" translate to what the device actually is? Seems kinda
> > random!
> 
> Btt is a family of devices (bttc, btt3, xea) - to control heavy duty
> machines.
> 
> That was the original codename - conceived probably 30+ years ago.

If there's 3 different devices, how come there aren't 3 compatibles, 1
for each?

> 
> > Also, where is patch 3, adding the lwe,btt to the spidev driver so
> > that it will probe?
> 
> I've posted it to Mark Brown (and also linux-spi ML) for review.
> 
> > 
> > Cheers,
> > Conor.
> > 
> > >              # 5 Bit Programmable, Pulse-Width Modulator
> > >            - maxim,ds1050
> > >              # 10 kOhm digital potentiometer with I2C interface
> > > -- 
> > > 2.39.5
> > >   
> 
> 
> 
> 
> Best regards,
> 
> Lukasz Majewski
> 
> --
> 
> DENX Software Engineering GmbH,      Managing Director: Erika Unter
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 2/2] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

[Lukasz Majewski]

[-- Attachment #1: Type: text/plain, Size: 2948 bytes --]

Hi Conor,

> On Fri, Feb 21, 2025 at 09:56:59PM +0100, Lukasz Majewski wrote:
> > Hi Conor,
> >   
> > > On Fri, Feb 21, 2025 at 04:54:18PM +0100, Lukasz Majewski wrote:  
> > > > The measurement device on Liebherr's (LWE) boards is used to
> > > > monitor the overall state of the device. It does have SPI
> > > > interface to communicate with Linux host via spidev driver.
> > > > Document the SPI DT binding as trivial SPI device.
> > > > 
> > > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > > ---
> > > >  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/trivial-devices.yaml
> > > > b/Documentation/devicetree/bindings/trivial-devices.yaml index
> > > > fadbd3c041c8..5d736a9792c2 100644 ---
> > > > a/Documentation/devicetree/bindings/trivial-devices.yaml +++
> > > > b/Documentation/devicetree/bindings/trivial-devices.yaml @@
> > > > -161,6 +161,8 @@ properties:
> > > >            - jedec,spd5118
> > > >              # Linear Technology LTC2488
> > > >            - lineartechnology,ltc2488
> > > > +            # Liebherr on-board measurement SPI device
> > > > +          - lwe,btt    
>                           ^^
> Are these two trailing spaces an artefact of the mail?
> 

No, there shall not be any.

> > > 
> > > How does "btt" translate to what the device actually is? Seems
> > > kinda random!  
> > 
> > Btt is a family of devices (bttc, btt3, xea) - to control heavy duty
> > machines.
> > 
> > That was the original codename - conceived probably 30+ years ago.  
> 
> If there's 3 different devices, how come there aren't 3 compatibles, 1
> for each?

There are devices from a single "family" of them, but different.

They are using similar approach for spidev devices connected.

> 
> >   
> > > Also, where is patch 3, adding the lwe,btt to the spidev driver so
> > > that it will probe?  
> > 
> > I've posted it to Mark Brown (and also linux-spi ML) for review.
> >   
> > > 
> > > Cheers,
> > > Conor.
> > >   
> > > >              # 5 Bit Programmable, Pulse-Width Modulator
> > > >            - maxim,ds1050
> > > >              # 10 kOhm digital potentiometer with I2C interface
> > > > -- 
> > > > 2.39.5
> > > >     
> > 
> > 
> > 
> > 
> > Best regards,
> > 
> > Lukasz Majewski
> > 
> > --
> > 
> > DENX Software Engineering GmbH,      Managing Director: Erika Unter
> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> > Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> > lukma@denx.de  
> 
> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 2/2] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2199 bytes --]

On Mon, Feb 24, 2025 at 08:21:31PM +0100, Lukasz Majewski wrote:
> Hi Conor,
> 
> > On Fri, Feb 21, 2025 at 09:56:59PM +0100, Lukasz Majewski wrote:
> > > Hi Conor,
> > >   
> > > > On Fri, Feb 21, 2025 at 04:54:18PM +0100, Lukasz Majewski wrote:  
> > > > > The measurement device on Liebherr's (LWE) boards is used to
> > > > > monitor the overall state of the device. It does have SPI
> > > > > interface to communicate with Linux host via spidev driver.
> > > > > Document the SPI DT binding as trivial SPI device.
> > > > > 
> > > > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > > > ---
> > > > >  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> > > > >  1 file changed, 2 insertions(+)
> > > > > 
> > > > > diff --git
> > > > > a/Documentation/devicetree/bindings/trivial-devices.yaml
> > > > > b/Documentation/devicetree/bindings/trivial-devices.yaml index
> > > > > fadbd3c041c8..5d736a9792c2 100644 ---
> > > > > a/Documentation/devicetree/bindings/trivial-devices.yaml +++
> > > > > b/Documentation/devicetree/bindings/trivial-devices.yaml @@
> > > > > -161,6 +161,8 @@ properties:
> > > > >            - jedec,spd5118
> > > > >              # Linear Technology LTC2488
> > > > >            - lineartechnology,ltc2488
> > > > > +            # Liebherr on-board measurement SPI device
> > > > > +          - lwe,btt    
> >                           ^^
> > Are these two trailing spaces an artefact of the mail?
> > 
> 
> No, there shall not be any.
> 
> > > > 
> > > > How does "btt" translate to what the device actually is? Seems
> > > > kinda random!  
> > > 
> > > Btt is a family of devices (bttc, btt3, xea) - to control heavy duty
> > > machines.
> > > 
> > > That was the original codename - conceived probably 30+ years ago.  
> > 
> > If there's 3 different devices, how come there aren't 3 compatibles, 1
> > for each?
> 
> There are devices from a single "family" of them, but different.
> 
> They are using similar approach for spidev devices connected.

"Similar" means different, and therefore you need to differentiate
between devices. In turn that means they should have distinct
compatibles.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]