From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: Jonathan Santos <Jonathan.Santos@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, lars@metafoo.de,
Michael.Hennerich@analog.com, marcelo.schmitt@analog.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
jonath4nns@gmail.com, marcelo.schmitt1@gmail.com
Subject: Re: [PATCH RESEND v3 06/17] Documentation: ABI: add wideband filter type to sysfs-bus-iio
Date: Sat, 22 Feb 2025 11:51:11 +0000 [thread overview]
Message-ID: <20250222115111.63a1cb89@jic23-huawei> (raw)
In-Reply-To: <42296bf2-2818-4224-9e52-d1fef59d8a76@baylibre.com>
On Thu, 20 Feb 2025 15:28:09 -0600
David Lechner <dlechner@baylibre.com> wrote:
> On 2/12/25 12:16 PM, Jonathan Santos wrote:
> > The Wideband Low Ripple filter is used for AD7768-1 Driver.
> > Document wideband filter option into filter_type_available
> > attribute.
> >
> > Signed-off-by: Jonathan Santos <Jonathan.Santos@analog.com>
> > ---
> > v3 Changes:
> > * None, since we still did not agree on a better name for this filter type.
> >
>
> I'm convinced at this point that "wideband" is fine.
>
> > v2 Changes:
> > * Removed FIR mentions.
> > ---
> > Documentation/ABI/testing/sysfs-bus-iio | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> > index f83bd6829285..9b879e7732cd 100644
> > --- a/Documentation/ABI/testing/sysfs-bus-iio
> > +++ b/Documentation/ABI/testing/sysfs-bus-iio
> > @@ -2291,6 +2291,8 @@ Description:
> > * "sinc3+pf2" - Sinc3 + device specific Post Filter 2.
> > * "sinc3+pf3" - Sinc3 + device specific Post Filter 3.
> > * "sinc3+pf4" - Sinc3 + device specific Post Filter 4.
> > + * "wideband" - filter with wideband low ripple passband
> > + and sharp transition band.
>
> The description could perhaps be made a bit more generic though
> instead of using specifics from the AD7768-1 datasheet. Something
> along the lines of Jonathan's 'flattish to a wide range of frequencies'
> description.
That is sort of what what low ripple passband and sharp transition band means
but with technical (sounding :) terms. The only missing bit is it isn't
a narrow pass filter.
>
> >
> > What: /sys/.../events/in_proximity_thresh_either_runningperiod
> > KernelVersion: 6.6
>
next prev parent reply other threads:[~2025-02-22 11:51 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 18:15 [PATCH RESEND v3 00/17] iio: adc: ad7768-1: Add features, improvements, and fixes Jonathan Santos
2025-02-12 18:15 ` [PATCH RESEND v3 01/17] iio: adc: ad7768-1: Fix conversion result sign Jonathan Santos
2025-02-12 18:16 ` [PATCH RESEND v3 02/17] iio: adc: ad7768-1: set MOSI idle state to prevent accidental reset Jonathan Santos
2025-02-16 15:59 ` Jonathan Cameron
2025-02-12 18:16 ` [PATCH RESEND v3 03/17] dt-bindings: iio: adc: ad7768-1: add trigger-sources property Jonathan Santos
2025-02-13 20:24 ` Conor Dooley
2025-02-27 21:30 ` Jonathan Santos
2025-03-21 14:39 ` Rob Herring
2025-02-12 18:16 ` [PATCH RESEND v3 04/17] dt-bindings: iio: adc: ad7768-1: Document GPIO controller Jonathan Santos
2025-02-12 18:16 ` [PATCH RESEND v3 05/17] dt-bindings: iio: adc: ad7768-1: document regulator provider property Jonathan Santos
2025-02-13 20:25 ` Conor Dooley
2025-02-20 21:22 ` David Lechner
2025-02-12 18:16 ` [PATCH RESEND v3 06/17] Documentation: ABI: add wideband filter type to sysfs-bus-iio Jonathan Santos
2025-02-20 21:28 ` David Lechner
2025-02-22 11:51 ` Jonathan Cameron [this message]
2025-02-12 18:17 ` [PATCH RESEND v3 07/17] iio: adc: ad7768-1: remove unnecessary locking Jonathan Santos
2025-02-20 21:30 ` David Lechner
2025-02-12 18:17 ` [PATCH RESEND v3 08/17] iio: adc: ad7768-1: convert driver to use regmap Jonathan Santos
2025-02-16 16:06 ` Jonathan Cameron
2025-02-20 21:41 ` David Lechner
2025-02-12 18:17 ` [PATCH RESEND v3 09/17] iio: adc: ad7768-1: Add reset gpio Jonathan Santos
2025-02-12 18:17 ` [PATCH RESEND v3 10/17] iio: adc: ad7768-1: Move buffer allocation to a separate function Jonathan Santos
2025-02-20 21:43 ` David Lechner
2025-02-12 18:17 ` [PATCH RESEND v3 11/17] iio: adc: ad7768-1: add regulator to control VCM output Jonathan Santos
2025-02-13 22:57 ` kernel test robot
2025-02-16 16:11 ` Jonathan Cameron
2025-02-20 22:20 ` David Lechner
2025-02-12 18:18 ` [PATCH RESEND v3 12/17] iio: adc: ad7768-1: Add GPIO controller support Jonathan Santos
2025-02-16 16:14 ` Jonathan Cameron
2025-02-19 20:34 ` Linus Walleij
2025-02-20 22:27 ` David Lechner
2025-02-27 21:36 ` Jonathan Santos
2025-02-27 21:54 ` David Lechner
2025-02-28 8:52 ` Linus Walleij
2025-02-28 15:55 ` David Lechner
2025-03-04 8:03 ` Linus Walleij
2025-02-12 18:18 ` [PATCH RESEND v3 13/17] iio: adc: ad7768-1: add multiple scan types to support 16-bits mode Jonathan Santos
2025-02-20 22:38 ` David Lechner
2025-02-12 18:18 ` [PATCH RESEND v3 14/17] iio: adc: ad7768-1: add support for Synchronization over SPI Jonathan Santos
2025-02-12 18:18 ` [PATCH RESEND v3 15/17] iio: adc: ad7768-1: replace manual attribute declaration Jonathan Santos
2025-02-16 16:21 ` Jonathan Cameron
2025-02-12 18:18 ` [PATCH RESEND v3 16/17] iio: adc: ad7768-1: add filter type and oversampling ratio attributes Jonathan Santos
2025-02-16 16:31 ` Jonathan Cameron
2025-02-20 13:28 ` Jonathan Santos
2025-02-12 18:19 ` [PATCH RESEND v3 17/17] iio: adc: ad7768-1: add low pass -3dB cutoff attribute Jonathan Santos
2025-02-16 16:33 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250222115111.63a1cb89@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Santos@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jonath4nns@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox