Re: [PATCH 2/2] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2325 bytes --]

On Fri, Feb 21, 2025 at 09:56:59PM +0100, Lukasz Majewski wrote:
> Hi Conor,
> 
> > On Fri, Feb 21, 2025 at 04:54:18PM +0100, Lukasz Majewski wrote:
> > > The measurement device on Liebherr's (LWE) boards is used to monitor
> > > the overall state of the device. It does have SPI interface to
> > > communicate with Linux host via spidev driver. Document the SPI DT
> > > binding as trivial SPI device.
> > > 
> > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > ---
> > >  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml
> > > b/Documentation/devicetree/bindings/trivial-devices.yaml index
> > > fadbd3c041c8..5d736a9792c2 100644 ---
> > > a/Documentation/devicetree/bindings/trivial-devices.yaml +++
> > > b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -161,6
> > > +161,8 @@ properties:
> > >            - jedec,spd5118
> > >              # Linear Technology LTC2488
> > >            - lineartechnology,ltc2488
> > > +            # Liebherr on-board measurement SPI device
> > > +          - lwe,btt  
                          ^^
Are these two trailing spaces an artefact of the mail?

> > 
> > How does "btt" translate to what the device actually is? Seems kinda
> > random!
> 
> Btt is a family of devices (bttc, btt3, xea) - to control heavy duty
> machines.
> 
> That was the original codename - conceived probably 30+ years ago.

If there's 3 different devices, how come there aren't 3 compatibles, 1
for each?

> 
> > Also, where is patch 3, adding the lwe,btt to the spidev driver so
> > that it will probe?
> 
> I've posted it to Mark Brown (and also linux-spi ML) for review.
> 
> > 
> > Cheers,
> > Conor.
> > 
> > >              # 5 Bit Programmable, Pulse-Width Modulator
> > >            - maxim,ds1050
> > >              # 10 kOhm digital potentiometer with I2C interface
> > > -- 
> > > 2.39.5
> > >   
> 
> 
> 
> 
> Best regards,
> 
> Lukasz Majewski
> 
> --
> 
> DENX Software Engineering GmbH,      Managing Director: Erika Unter
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]