Re: [PATCH 2/2] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2199 bytes --]

On Mon, Feb 24, 2025 at 08:21:31PM +0100, Lukasz Majewski wrote:
> Hi Conor,
> 
> > On Fri, Feb 21, 2025 at 09:56:59PM +0100, Lukasz Majewski wrote:
> > > Hi Conor,
> > >   
> > > > On Fri, Feb 21, 2025 at 04:54:18PM +0100, Lukasz Majewski wrote:  
> > > > > The measurement device on Liebherr's (LWE) boards is used to
> > > > > monitor the overall state of the device. It does have SPI
> > > > > interface to communicate with Linux host via spidev driver.
> > > > > Document the SPI DT binding as trivial SPI device.
> > > > > 
> > > > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > > > ---
> > > > >  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> > > > >  1 file changed, 2 insertions(+)
> > > > > 
> > > > > diff --git
> > > > > a/Documentation/devicetree/bindings/trivial-devices.yaml
> > > > > b/Documentation/devicetree/bindings/trivial-devices.yaml index
> > > > > fadbd3c041c8..5d736a9792c2 100644 ---
> > > > > a/Documentation/devicetree/bindings/trivial-devices.yaml +++
> > > > > b/Documentation/devicetree/bindings/trivial-devices.yaml @@
> > > > > -161,6 +161,8 @@ properties:
> > > > >            - jedec,spd5118
> > > > >              # Linear Technology LTC2488
> > > > >            - lineartechnology,ltc2488
> > > > > +            # Liebherr on-board measurement SPI device
> > > > > +          - lwe,btt    
> >                           ^^
> > Are these two trailing spaces an artefact of the mail?
> > 
> 
> No, there shall not be any.
> 
> > > > 
> > > > How does "btt" translate to what the device actually is? Seems
> > > > kinda random!  
> > > 
> > > Btt is a family of devices (bttc, btt3, xea) - to control heavy duty
> > > machines.
> > > 
> > > That was the original codename - conceived probably 30+ years ago.  
> > 
> > If there's 3 different devices, how come there aren't 3 compatibles, 1
> > for each?
> 
> There are devices from a single "family" of them, but different.
> 
> They are using similar approach for spidev devices connected.

"Similar" means different, and therefore you need to differentiate
between devices. In turn that means they should have distinct
compatibles.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]