devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Peter De Schrijver <pdeschrijver@nvidia.com>,
	Prashant Gaikwad <pgaikwad@nvidia.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Georgi Djakov <djakov@kernel.org>,
	Dmitry Osipenko <digetx@gmail.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v1 6/9] dt-bindings: memory: Document Tegra114 External Memory Controller
Date: Wed, 26 Feb 2025 09:15:29 -0600	[thread overview]
Message-ID: <20250226151529.GA2338510-robh@kernel.org> (raw)
In-Reply-To: <20250225143501.68966-7-clamor95@gmail.com>

On Tue, Feb 25, 2025 at 04:34:58PM +0200, Svyatoslav Ryhel wrote:
> Document External Memory Controller found in the Tegra 4 SoC.

This all looks very close to tegra124. Could have missed something, but 
I see 1 property difference and 'nvidia,emc-configuration' is slightly 
different. I'd just add tegra114 to the existing schema. For 
'nvidia,emc-configuration', I would just list the range for the length. 
It's just a list of magic register values, so we can't really do any 
validation of it. And I don't care what register is which entry. If you 
really want to document that, then keep the existing list and put 0 
value entries for any registers that don't exist on tegra114 and put new 
registers on the end of the list.

> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>  .../nvidia,tegra114-emc.yaml                  | 431 ++++++++++++++++++
>  1 file changed, 431 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra114-emc.yaml

  parent reply	other threads:[~2025-02-26 15:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-25 14:34 [PATCH v1 0/9] Tegra114: implement EMC support Svyatoslav Ryhel
2025-02-25 14:34 ` [PATCH v1 1/9] ARM: tegra: Add ACTMON support on Tegra114 Svyatoslav Ryhel
2025-02-25 17:33   ` Krzysztof Kozlowski
2025-02-25 14:34 ` [PATCH v1 2/9] dt-bindings: memory: Document Tegra114 Memory Controller Svyatoslav Ryhel
2025-02-25 17:37   ` Krzysztof Kozlowski
2025-02-25 14:34 ` [PATCH v1 3/9] drivers: memory: tegra: implement EMEM regs and ICC ops for T114 Svyatoslav Ryhel
2025-02-25 14:34 ` [PATCH v1 4/9] dt-bindings: memory: tegra114: Add memory client IDs Svyatoslav Ryhel
2025-02-25 17:33   ` Krzysztof Kozlowski
2025-02-25 14:34 ` [PATCH v1 5/9] clk: tegra114: remove emc to mc clock mux Svyatoslav Ryhel
2025-02-25 14:34 ` [PATCH v1 6/9] dt-bindings: memory: Document Tegra114 External Memory Controller Svyatoslav Ryhel
2025-02-25 17:41   ` Krzysztof Kozlowski
2025-02-26 15:15   ` Rob Herring [this message]
2025-02-26 15:28     ` Svyatoslav Ryhel
2025-02-25 14:34 ` [PATCH v1 7/9] memory: tegra: Add Tegra114 EMC driver Svyatoslav Ryhel
2025-03-06 19:42   ` Dmitry Osipenko
2025-03-06 19:48     ` Svyatoslav Ryhel
2025-03-06 20:06       ` Dmitry Osipenko
2025-03-07  6:58         ` Svyatoslav Ryhel
2025-02-25 14:35 ` [PATCH v1 8/9] ARM: tegra: Add External Memory Controller node on Tegra114 Svyatoslav Ryhel
2025-02-25 14:35 ` [PATCH v1 9/9] ARM: tegra: Add EMC OPP and ICC properties to Tegra114 EMC and ACTMON device-tree nodes Svyatoslav Ryhel
2025-02-26 15:42 ` [PATCH v1 0/9] Tegra114: implement EMC support Rob Herring (Arm)
2025-04-08  5:43 ` Svyatoslav Ryhel
2025-04-08  5:47   ` Krzysztof Kozlowski
2025-04-08  5:49     ` Svyatoslav Ryhel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250226151529.GA2338510-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=clamor95@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=digetx@gmail.com \
    --cc=djakov@kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzk@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=pdeschrijver@nvidia.com \
    --cc=pgaikwad@nvidia.com \
    --cc=sboyd@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).