Re: [PATCH 4/6] dt-bindings: gpu: v3d: Add SMS to the registers' list

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1755 bytes --]

On Wed, Feb 26, 2025 at 04:59:02PM -0300, Maíra Canal wrote:
> V3D 7.1 exposes a new register block, called V3D_SMS. As BCM2712 has a
> V3D 7.1 core, add a new register item to the list. Similar to the GCA
> and bridge register, SMS is optional and should only be added for V3D
> 7.1 variants.
> 
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Nicolas Saenz Julienne <nsaenz@kernel.org>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
>  Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
> index dc078ceeca9ac3447ba54a7c8830821f0b2a7f9f..8a3d3fc6065d7756da141bda4dc522f63be5e9a1 100644
> --- a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
> +++ b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
> @@ -27,14 +27,16 @@ properties:
>        - description: core0 register (required)
>        - description: GCA cache controller register (if GCA controller present)
>        - description: bridge register (if no external reset controller)
> +      - description: SMS register (if SMS controller present)
>      minItems: 2
>  
>    reg-names:
>      items:
>        - const: hub
>        - const: core0
> -      - enum: [ bridge, gca ]
> -      - enum: [ bridge, gca ]
> +      - enum: [ bridge, gca, sms ]
> +      - enum: [ bridge, gca, sms ]
> +      - enum: [ bridge, gca, sms ]
>      minItems: 2

Can you add a per-compatible restriction, to only allow maxItems: 2
when the compatible is not mcb2712 please?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]