From: Yixun Lan <dlan@gentoo.org>
To: Zixian Zeng <sycamoremoon376@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Chen Wang <unicorn_wang@outlook.com>,
Inochi Amaoto <inochiama@outlook.com>,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, sophgo@lists.linux.dev
Subject: Re: [PATCH] riscv: dts: sophgo: sg2042: Add spi devices
Date: Fri, 28 Feb 2025 03:55:07 +0000 [thread overview]
Message-ID: <20250228035507-GYA52348@gentoo> (raw)
In-Reply-To: <20250228-sfg-spi-v1-1-b989aed94911@gmail.com>
Hi Zixian:
On 10:47 Fri 28 Feb , Zixian Zeng wrote:
> Add spi devices for the sg2042 soc.
>
> Signed-off-by: Zixian Zeng <sycamoremoon376@gmail.com>
> ---
> arch/riscv/boot/dts/sophgo/sg2042.dtsi | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sophgo/sg2042.dtsi b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> index 0fca16c469cc95aa897b6b57e0a287a687b4d251..d413daa47cf081f23284851db1eeceb3a157e9c0 100644
> --- a/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> @@ -800,5 +800,35 @@ flash@0 {
> compatible = "jedec,spi-nor";
> };
> };
> +
> + spi0: spi@7040004000 {
> + compatible = "snps,dw-apb-ssi";
> + #address-cells = <0x01>;
> + #size-cells = <0x00>;
> + reg = <0x70 0x40004000 0x00 0x1000>;
for consistency, I'd suggest moving 'reg' info above '#address-cells'
> + interrupt-parent = <&intc>;
> + interrupts = <110 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clkgen GATE_CLK_APB_SPI>,
> + <&clkgen GATE_CLK_SYSDMA_AXI>;
> + clock-frequency = <250000000>;
ditto, move clock above interrupt
> + resets = <&rstgen RST_SPI0>;
> + num-cs = <0x02>;
> + status = "okay";
in dtsi file, please make status disabled by default, then enable it at board file
> + };
> +
> + spi1: spi@7040005000 {
> + compatible = "snps,dw-apb-ssi";
> + #address-cells = <0x01>;
> + #size-cells = <0x00>;
> + reg = <0x70 0x40005000 0x00 0x1000>;
> + interrupt-parent = <&intc>;
> + interrupts = <111 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clkgen GATE_CLK_APB_SPI>,
> + <&clkgen GATE_CLK_SYSDMA_AXI>;
> + clock-frequency = <250000000>;
> + resets = <&rstgen RST_SPI1>;
> + num-cs = <0x02>;
> + status = "okay";
> + };
> };
> };
>
> ---
> base-commit: 9ef5d3235d41a6f5230d3ddf5eb994483853b3e8
> change-id: 20250228-sfg-spi-e3f2aeca09ab
>
> Best regards,
> --
> Zixian Zeng <sycamoremoon376@gmail.com>
>
--
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55
next prev parent reply other threads:[~2025-02-28 3:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 2:47 [PATCH] riscv: dts: sophgo: sg2042: Add spi devices Zixian Zeng
2025-02-28 3:55 ` Yixun Lan [this message]
2025-02-28 7:32 ` Chen Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228035507-GYA52348@gentoo \
--to=dlan@gentoo.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=inochiama@outlook.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=sophgo@lists.linux.dev \
--cc=sycamoremoon376@gmail.com \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox