From: Conor Dooley <conor@kernel.org>
To: Stanley Chu <stanley.chuys@gmail.com>
Cc: frank.li@nxp.com, miquel.raynal@bootlin.com,
alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com
Subject: Re: [PATCH v2 1/4] dt-bindings: i3c: silvaco: Add npcm845 compatible string
Date: Mon, 3 Mar 2025 17:11:27 +0000 [thread overview]
Message-ID: <20250303-chest-presoak-5d3f3b821d1f@spud> (raw)
In-Reply-To: <20250220054330.1711979-2-yschu@nuvoton.com>
[-- Attachment #1: Type: text/plain, Size: 981 bytes --]
On Thu, Feb 20, 2025 at 01:43:27PM +0800, Stanley Chu wrote:
> Add a compatible string for Nuvoton BMC NPCM845 i3c controller.
Why is a fallback not an option here? Your commit message should call
out why not.
>
> Signed-off-by: Stanley Chu <yschu@nuvoton.com>
> ---
> Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> index c56ff77677f1..9be4bc4cc482 100644
> --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> @@ -14,7 +14,9 @@ allOf:
>
> properties:
> compatible:
> - const: silvaco,i3c-master-v1
> + enum:
> + - silvaco,i3c-master-v1
> + - nuvoton,npcm845-i3c
>
> reg:
> maxItems: 1
> --
> 2.34.1
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-03-03 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 5:43 [PATCH v2 0/4] Add support for Nuvoton npcm845 i3c controller Stanley Chu
2025-02-20 5:43 ` [PATCH v2 1/4] dt-bindings: i3c: silvaco: Add npcm845 compatible string Stanley Chu
2025-03-03 17:11 ` Conor Dooley [this message]
2025-02-20 5:43 ` [PATCH v2 2/4] i3c: master: svc: Add support for Nuvoton npcm845 i3c Stanley Chu
2025-02-20 5:43 ` [PATCH v2 3/4] i3c: master: svc: Fix npcm845 FIFO empty issue Stanley Chu
2025-02-20 5:43 ` [PATCH v2 4/4] i3c: master: svc: Fix npcm845 invalid slvstart event Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250303-chest-presoak-5d3f3b821d1f@spud \
--to=conor@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=frank.li@nxp.com \
--cc=kwliu@nuvoton.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=stanley.chuys@gmail.com \
--cc=tomer.maimon@nuvoton.com \
--cc=yschu@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox